#860: wxGUI: About Copyright missing its middle
----------------------+-----------------------------------------------------
Reporter: hamish | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: critical | Milestone: 6.4.0
Component: wxGUI | Version: svn-releasebranch64
Keywords: license | Platform: Linux
Cpu: x86-64 |
----------------------+-----------------------------------------------------
Hi,
when I do help -> about in the 6.4/6.5 wx GUI menu and look in the
Copyright tab I get the text from `g.region -c`, but only the very top and
bottom lines. The middle is missing. It skips from the end of the second
paragraph all the way to "BOSTON, MA ..." & past all the "don't sue us"
stuff.
fwiw, gis.m and g.version -c are fine.
also I notice the "&" gets treated as a keyboard shortcut designator in
some of the other tab text.
> when I do help -> about in the 6.4/6.5 wx GUI menu and look in the
Copyright tab I get the text from `g.region -c`, but only the very top and
bottom lines. The middle is missing. It skips from the end of the second
paragraph all the way to "BOSTON, MA ..." & past all the "don't sue us"
stuff.
This appears to have been intentional; `AboutWindow.PageCopyright` at
help.py:458:
{{{
copytext = wordwrap(''.join(copyright[:11] +
copyright[26:-3]),
575, wx.ClientDC(self))
}}}
Presumably this was to make it fit the window, but that's not necessary
now that it's embedded in a `ScrolledPanel`.
ok, thanks. tested & committed in 6.5, to be ported around as soon as I
get the chance.
I notice that the Copyright, Contributers, and Translators tabs seem to
start their display on line[1] instead of line[0] of the file.
(content is there, it's just the scrollbar)
?
> I notice that the Copyright, Contributers, and Translators tabs seem to
start their display on line![1] instead of line![0] of the file. (content
is there, it's just the scrollbar)
Also, if you scroll to the top, switch tabs, then switch back, it reverts
the scrollbar position. This suggests a bug in `ScrolledPanel`, possibly
in its interactions with `FlatNotebook`. Both of those are wxPython
extensions (i.e. not part of wxWidgets), which generally seem to have more
rough edges than the core wxWidgets components.
Replying to [comment:4 neteler]:
> I just recompiled: help -> about in 6.4 does no longer open a
> Window. Confirmed on Linux and Windows (latest installer from
> today).
presumably this has now been fixed by the str(authors) l10n commit.