On Thu, May 22, 2014 at 5:31 PM, <svn_grass@osgeo.org> wrote:
- _("Either a standard GRASS color, R:G:B triplet, or \"none\"");
+ _("Either a standard color name, R:G:B triplet, or \"none\"");
I definitively agree with adding "name" there. However, I'm not so sure
about leaving "GRASS" out because it is not clear what is "standard color
name". Which standard? DVI, SVG, CSS? Even leaving out "standard" would
make sense since "GRASS color name" is enough, I would say.
Hi,
I was syncing with G_OPT_C_FG, which has “standard color name”. I don’t have a strong opinion against “standard GRASS color name” as long as G_OPT_C_FG and G_OPT_C_BG have the same wording, but I’m not so sure if we really need to say “GRASS” when we’re using GRASS. For example, even “mapset/region” should be “GRASS mapset/region” then? No other standard options had “GRASS” other than G_OPT_C_BG. Why do you think this case can be more confusing than other GRASS specific words? Just wondering.
Huidae
On Thu, May 22, 2014 at 5:57 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:
On Thu, May 22, 2014 at 5:31 PM, <svn_grass@osgeo.org> wrote:
- _(“Either a standard GRASS color, R:G:B triplet, or "none"”);
- _(“Either a standard color name, R:G:B triplet, or "none"”);
I definitively agree with adding “name” there. However, I’m not so sure about leaving “GRASS” out because it is not clear what is “standard color name”. Which standard? DVI, SVG, CSS? Even leaving out “standard” would make sense since “GRASS color name” is enough, I would say.
On Fri, May 23, 2014 at 7:14 AM, Huidae Cho <grass4u@gmail.com> wrote:
Hi,
I was syncing with G_OPT_C_FG, which has "standard color name". I don't
have a strong opinion against "standard GRASS color name" as long as
G_OPT_C_FG and G_OPT_C_BG have the same wording, but I'm not so sure if we
really need to say "GRASS" when we're using GRASS. For example, even
"mapset/region" should be "GRASS mapset/region" then? No other standard
options had "GRASS" other than G_OPT_C_BG. Why do you think this case can
be more confusing than other GRASS specific words? Just wondering.OK, this sounds reasonable. I was considering that the modules accepting
aspect or direction usually speak about "grass" convention or something
like this. Although in case of r.ros, I might be the one who added it there.
http://trac.osgeo.org/grass/browser/grass/trunk/display/d.rast.arrow/main.c#L105
http://trac.osgeo.org/grass/browser/grass/trunk/raster/r.ros/main.c#L303
Huidae
On Thu, May 22, 2014 at 5:57 PM, Vaclav Petras <wenzeslaus@gmail.com>wrote:
On Thu, May 22, 2014 at 5:31 PM, <svn_grass@osgeo.org> wrote:
- _("Either a standard GRASS color, R:G:B triplet, or
\"none\"");
+ _("Either a standard color name, R:G:B triplet, or
\"none\"");I definitively agree with adding "name" there. However, I'm not so sure
about leaving "GRASS" out because it is not clear what is "standard color
name". Which standard? DVI, SVG, CSS? Even leaving out "standard" would
make sense since "GRASS color name" is enough, I would say.
In case of aspect or direction, there are different coding schemes in different formats, but color names are more generic even though there are only 16 standard colors. BTW, I doubt there is a way for the user to see all these standard color names and R:G:B triplet pairs.
On Fri, May 23, 2014 at 10:06 AM, Vaclav Petras <wenzeslaus@gmail.com> wrote:
On Fri, May 23, 2014 at 7:14 AM, Huidae Cho <grass4u@gmail.com> wrote:
Hi,
I was syncing with G_OPT_C_FG, which has “standard color name”. I don’t have a strong opinion against “standard GRASS color name” as long as G_OPT_C_FG and G_OPT_C_BG have the same wording, but I’m not so sure if we really need to say “GRASS” when we’re using GRASS. For example, even “mapset/region” should be “GRASS mapset/region” then? No other standard options had “GRASS” other than G_OPT_C_BG. Why do you think this case can be more confusing than other GRASS specific words? Just wondering.
OK, this sounds reasonable. I was considering that the modules accepting aspect or direction usually speak about “grass” convention or something like this. Although in case of r.ros, I might be the one who added it there.
http://trac.osgeo.org/grass/browser/grass/trunk/display/d.rast.arrow/main.c#L105
http://trac.osgeo.org/grass/browser/grass/trunk/raster/r.ros/main.c#L303
Huidae
On Thu, May 22, 2014 at 5:57 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:
On Thu, May 22, 2014 at 5:31 PM, <svn_grass@osgeo.org> wrote:
- _(“Either a standard GRASS color, R:G:B triplet, or "none"”);
- _(“Either a standard color name, R:G:B triplet, or "none"”);
I definitively agree with adding “name” there. However, I’m not so sure about leaving “GRASS” out because it is not clear what is “standard color name”. Which standard? DVI, SVG, CSS? Even leaving out “standard” would make sense since “GRASS color name” is enough, I would say.