Hi,
the original motivation for the commit was actually terminology. When talking about the raster/vector/3D raster file on disk, we should use “map” rather then “layer” to be consistent with the rest of GRASS. Let me know if you think otherwise.
Vaclav
PS: You were silent for some time so I took the liberty to edit the code.
PPS: I’ve used the data catalog for the first time. It is pretty cool!
···
On Thu, Jul 10, 2014 at 3:03 PM, <svn_grass@osgeo.org> wrote:
Author: wenzeslaus
Date: 2014-07-10 12:03:00 -0700 (Thu, 10 Jul 2014)
New Revision: 61236Modified:
grass/trunk/gui/wxpython/lmgr/datacatalog.py
Log:
wxGUI/datacatalog: use GRASS standard message format with <>, use string formatting instead of plus (to enable good translations), use keyword arguments when parameter names are unclear, prefer shorter linesModified: grass/trunk/gui/wxpython/lmgr/datacatalog.py
— grass/trunk/gui/wxpython/lmgr/datacatalog.py 2014-07-10 18:51:58 UTC (rev 61235)
+++ grass/trunk/gui/wxpython/lmgr/datacatalog.py 2014-07-10 19:03:00 UTC (rev 61236)
@@ -402,7 +402,9 @@
string = self.GetItemText(self.selected_layer)
self.ChangeEnvironment(self.GetItemText(self.selected_location), self.GetItemText(self.selected_mapset))
removed = 0
- if (self.confirmDialog((‘Do you really want to delete layer’) +string+‘?’, _(‘Delete map’)) == wx.ID_YES):
TODO: rewrite this that it will tell map type in the dialog
- if (self.confirmDialog(question=(‘Do you really want to delete map <{m}>?’).format(m=string),
- title=_(‘Delete map’)) == wx.ID_YES):
label = _(“Deleting”) + " " + string + " …"
self.showNotification.emit(message=label)
if (self.GetItemText(self.selected_type)==‘vect’):
grass-commit mailing list
grass-commit@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-commit