[GRASS-dev] [GRASS-SVN] r61944 - in grass/trunk/lib/python: gunittest imaging pygrass pygrass/modules/interface pygrass/raster pygrass/shell pygrass/vector script

Hi Luca,

concerning the changes in:
   grass/trunk/lib/python/imaging/images2gif.py
   grass/trunk/lib/python/imaging/images2swf.py

... wouldn't it be good to get that upstream fixed in the original files, too?

thanks,
Markus

On Sep 14, 2014 6:48 AM, <svn_grass@osgeo.org> wrote:

Author: lucadelu
Date: 2014-09-14 06:47:40 -0700 (Sun, 14 Sep 2014)
New Revision: 61944

Modified:
   grass/trunk/lib/python/gunittest/case.py
   grass/trunk/lib/python/gunittest/gmodules.py
   grass/trunk/lib/python/imaging/images2gif.py
   grass/trunk/lib/python/imaging/images2swf.py
   grass/trunk/lib/python/pygrass/functions.py
   grass/trunk/lib/python/pygrass/modules/interface/flag.py
   grass/trunk/lib/python/pygrass/modules/interface/module.py
   grass/trunk/lib/python/pygrass/raster/__init__.py
   grass/trunk/lib/python/pygrass/raster/abstract.py
   grass/trunk/lib/python/pygrass/raster/category.py
   grass/trunk/lib/python/pygrass/shell/conversion.py
   grass/trunk/lib/python/pygrass/vector/__init__.py
   grass/trunk/lib/python/pygrass/vector/basic.py
   grass/trunk/lib/python/pygrass/vector/find.py
   grass/trunk/lib/python/pygrass/vector/geometry.py
   grass/trunk/lib/python/pygrass/vector/table.py
   grass/trunk/lib/python/script/db.py
   grass/trunk/lib/python/script/raster.py
   grass/trunk/lib/python/script/task.py
   grass/trunk/lib/python/script/utils.py
   grass/trunk/lib/python/script/vector.py
Log:
lib python: documentation cleanup, fix sphinx warning

On 22 September 2014 22:31, Markus Neteler <neteler@osgeo.org> wrote:

Hi Luca,

concerning the changes in:
   grass/trunk/lib/python/imaging/images2gif.py
   grass/trunk/lib/python/imaging/images2swf.py

... wouldn't it be good to get that upstream fixed in the original files, too?

I don't thins so, the changes was only related to pep8 and
documentation clean up

thanks,
Markus

--
ciao
Luca

http://gis.cri.fmach.it/delucchi/
www.lucadelu.org

On Fri, Oct 10, 2014 at 8:46 AM, Luca Delucchi <lucadeluge@gmail.com> wrote:

On 22 September 2014 22:31, Markus Neteler <neteler@osgeo.org> wrote:

Hi Luca,

concerning the changes in:
   grass/trunk/lib/python/imaging/images2gif.py
   grass/trunk/lib/python/imaging/images2swf.py

... wouldn't it be good to get that upstream fixed in the original files, too?

I don't thins so, the changes was only related to pep8 and
documentation clean up

Exactly! I could not resist, so the first patch is submitted and the
author contacted:

http://code.google.com/p/visvis/issues/detail?id=83

ciao
Markus

On Fri, Oct 10, 2014 at 2:40 PM, Markus Neteler <neteler@osgeo.org> wrote:

On Fri, Oct 10, 2014 at 8:46 AM, Luca Delucchi <lucadeluge@gmail.com> wrote:

On 22 September 2014 22:31, Markus Neteler <neteler@osgeo.org> wrote:

Hi Luca,

concerning the changes in:
   grass/trunk/lib/python/imaging/images2gif.py
   grass/trunk/lib/python/imaging/images2swf.py

... wouldn't it be good to get that upstream fixed in the original files, too?

I don't thins so, the changes was only related to pep8 and
documentation clean up

Exactly! I could not resist, so the first patch is submitted and the
author contacted:

...

so, patches accepted upstream :slight_smile:

On Tue, Nov 4, 2014 at 2:16 PM, <visvis@googlecode.com> wrote:

Updates:
        Status: Done

Comment #2 on issue 83 by almar.klein: Patch for /vvmovie/images2gif.py
https://code.google.com/p/visvis/issues/detail?id=83

and

On Tue, Nov 4, 2014 at 2:18 PM, <visvis@googlecode.com> wrote:

Updates:
        Status: Done

Comment #1 on issue 84 by almar.klein: Patch for /vvmovie/images2swf.py
https://code.google.com/p/visvis/issues/detail?id=84

Thanks. This functionality will soon be available in imageio as well.

cheers
Markus