[GRASS-dev] [GRASS-SVN] r62845 - in grass/trunk/scripts: . d.shadedmap r.shadedmap

GRASS GIS GRASS GIS developer
1

____________________
C. Michael Barton
Director, Center for Social Dynamics & Complexity
Professor of Anthropology, School of Human Evolution & Social Change
Head, Graduate Faculty in Complex Adaptive Systems Science
Arizona State University

voice: 480-965-6262 (SHESC), 480-965-8130/727-9746 (CSDC)
fax: 480-965-7671 (SHESC), 480-727-0709 (CSDC)
www: http://www.public.asu.edu/~cmbarton, http://csdc.asu.edu

Probably nothing to be done about this since r.shaded.relief goes back a long time. But a more sensible renaming would have the script now called r.chaded.relief renamed to simply r.relief. Then the modules that drape a colored map onto a relief map could be called x.shaded.relief, x.shadedrelief, or something like that.

Michael

On Nov 28, 2014, at 1:31 AM, grass-dev-request@lists.osgeo.org<mailto:grass-dev-request@lists.osgeo.org> wrote:

From: Vaclav Petras <wenzeslaus@gmail.com<mailto:wenzeslaus@gmail.com>>
Cc: GRASS developers list <grass-dev@lists.osgeo.org<mailto:grass-dev@lists.osgeo.org>>
To: Martin Landa <landa.martin@gmail.com<mailto:landa.martin@gmail.com>>
Date: November 27, 2014 at 8:18:51 PM MST
Subject: Re: [GRASS-dev] [GRASS-SVN] r62845 - in grass/trunk/scripts: . d.shadedmap r.shadedmap

On Thu, Nov 27, 2014 at 12:15 PM, Martin Landa <landa.martin@gmail.com<mailto:landa.martin@gmail.com>> wrote:
2014-11-27 18:12 GMT+01:00 Markus Neteler <neteler@osgeo.org<mailto:neteler@osgeo.org>>:

Then it should be renamed.

We cannot add continuously new scripts with similar names...

+1

You mean r.shaded.relief versus [dr].shadedmap?

r.shaded.relief should probably stay the same. [dr].shadedmap could be changed. I don't particularly like the name from the beginning but I didn't get any better idea than keeping the name [dr].shadedmap. There are just two ideas worth mentioning and they does not seem different enough. First is [dr].shade.rast(er) as in "put shade on raster" and the second is [dr].rast(er).shade which is inspired by d.vect.thematic or d.rast.arrow).

The possible combinations mentioned above are:

d.rast.shade
r.rast.shade
d.shade.rast
r.shade.rast
d.raster.shade
r.raster.shade
d.shade.raster
r.shade.raster

Vaclav

Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa

2

On Fri, Nov 28, 2014 at 5:40 PM, Michael Barton <Michael.Barton@asu.edu> wrote:

Probably nothing to be done about this since r.shaded.relief goes back a long time. But a more sensible renaming would have the script now called r.chaded.relief renamed to simply r.relief. Then the modules that drape a colored map onto a relief map could be called x.shaded.relief, x.shadedrelief, or something like that.

That’s an interesting option. I’m not sure if I like it but it’s worth exploring. If we go even further we get:

r.shaded.relief → r.relief
r.shadedmap → r.shade

d.shadedmap → d.shade

Vaclav

Michael

On Nov 28, 2014, at 1:31 AM, Vaclav Petras <wenzeslaus@gmail.com> wrote:
On Thu, Nov 27, 2014 at 12:15 PM, Martin Landa <landa.martin@gmail.com> wrote:

2014-11-27 18:12 GMT+01:00 Markus Neteler <neteler@osgeo.org>:

Then it should be renamed.

We cannot add continuously new scripts with similar names…

+1

You mean r.shaded.relief versus [dr].shadedmap?

r.shaded.relief should probably stay the same. [dr].shadedmap could be changed. I don’t particularly like the name from the beginning but I didn’t get any better idea than keeping the name [dr].shadedmap. There are just two ideas worth mentioning and they does not seem different enough. First is [dr].shade.rast(er) as in “put shade on raster” and the second is [dr].rast(er).shade which is inspired by d.vect.thematic or d.rast.arrow).

The possible combinations mentioned above are:

d.rast.shade
r.rast.shade
d.shade.rast
r.shade.rast
d.raster.shade
r.raster.shade
d.shade.raster
r.shade.raster

Vaclav

3

On Sat, Nov 29, 2014 at 12:37 AM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

On Fri, Nov 28, 2014 at 5:40 PM, Michael Barton <Michael.Barton@asu.edu>
wrote:

Probably nothing to be done about this since r.shaded.relief goes back a
long time. But a more sensible renaming would have the script now called
r.chaded.relief renamed to simply r.relief. Then the modules that drape a
colored map onto a relief map could be called x.shaded.relief,
x.shadedrelief, or something like that.

That's an interesting option. I'm not sure if I like it but it's worth
exploring. If we go even further we get:

r.shaded.relief -> r.relief
r.shadedmap -> r.shade
d.shadedmap -> d.shade

... along with:
- r.blend

Yes, I like this list better than the current names of discussed modules.

Markus

4

On Sat, Nov 29, 2014 at 9:30 AM, Markus Neteler <neteler@osgeo.org> wrote:

On Sat, Nov 29, 2014 at 12:37 AM, Vaclav Petras <wenzeslaus@gmail.com>
wrote:
>
> On Fri, Nov 28, 2014 at 5:40 PM, Michael Barton <Michael.Barton@asu.edu>
> wrote:
>>
>> Probably nothing to be done about this since r.shaded.relief goes back a
>> long time. But a more sensible renaming would have the script now called
>> r.chaded.relief renamed to simply r.relief. Then the modules that drape
a
>> colored map onto a relief map could be called x.shaded.relief,
>> x.shadedrelief, or something like that.
>>
> That's an interesting option. I'm not sure if I like it but it's worth
> exploring. If we go even further we get:
>
> r.shaded.relief -> r.relief
> r.shadedmap -> r.shade
> d.shadedmap -> d.shade

... along with:
- r.blend

Yes, I like this list better than the current names of discussed modules.

So, if you like it, I can like it too and I will change it hopefully soon.

Just to be sure: including r.shaded.relief -> r.relief?

Vaclav

Markus

5

On Sat, Nov 29, 2014 at 9:43 AM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

On Sat, Nov 29, 2014 at 9:30 AM, Markus Neteler <neteler@osgeo.org> wrote:

On Sat, Nov 29, 2014 at 12:37 AM, Vaclav Petras <wenzeslaus@gmail.com>
wrote:
>
> On Fri, Nov 28, 2014 at 5:40 PM, Michael Barton <Michael.Barton@asu.edu
>
> wrote:
>>
>> Probably nothing to be done about this since r.shaded.relief goes back
a
>> long time. But a more sensible renaming would have the script now
called
>> r.chaded.relief renamed to simply r.relief. Then the modules that
drape a
>> colored map onto a relief map could be called x.shaded.relief,
>> x.shadedrelief, or something like that.
>>
> That's an interesting option. I'm not sure if I like it but it's worth
> exploring. If we go even further we get:
>
> r.shaded.relief -> r.relief
> r.shadedmap -> r.shade
> d.shadedmap -> d.shade

... along with:
- r.blend

Yes, I like this list better than the current names of discussed modules.

So, if you like it, I can like it too and I will change it hopefully

soon. Just to be sure: including r.shaded.relief -> r.relief?

r.shaded.relief -> r.relief
r.shadedmap -> r.shade
d.shadedmap -> d.shade

Done in r63305 with few other improvements.

Now I'm not sure with [rd].shade parameters. reliefmap and drapemap are not
particularly explanatory. My idea was shade and color which is better when
shade=slope compared to relief=slope. color=elevation is also quite
understandable but of course it is quite unexpected that the color option
is a raster map.

There is also one detail I'm not sure about. r.relief might be now missing
one keyword and that is "shaded relief". "relief" should be there too but
having also "shaded relief" distinguishes it from things like "local relief
(model)".

http://trac.osgeo.org/grass/changeset/63305

Vaclav

Markus