[GRASS-dev] [GRASS-SVN] r64253 - grass-addons/grass7/imagery/i.spec.sam

GRASS GIS GRASS GIS developer
1

On Tue, Jan 20, 2015 at 8:29 AM, <svn_grass@osgeo.org> wrote:

Fixed the flag.quiet structure issue

This should be replaced with G_verbose_message()

2

Thanks Vaclav,

will try.

Yann

···

On 20 January 2015 at 19:28, Vaclav Petras <wenzeslaus@gmail.com> wrote:

grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

–

On Tue, Jan 20, 2015 at 8:29 AM, <svn_grass@osgeo.org> wrote:

Fixed the flag.quiet structure issue

This should be replaced with G_verbose_message()

3

Hi Vaclav,

I have replaced all but one (in i.spec.sam/open.c):

if (!flag_quiet->answer)
{
m_output(A);
}

tentatively replaced by:
if (G_verbose == 3)
{
m_output(A);
}

is that OK?

Thanks

Yann

···

On 20 January 2015 at 20:15, Yann Chemin <ychemin@gmail.com> wrote:

Thanks Vaclav,

will try.

Yann

–

On 20 January 2015 at 19:28, Vaclav Petras <wenzeslaus@gmail.com> wrote:

grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

–

On Tue, Jan 20, 2015 at 8:29 AM, <svn_grass@osgeo.org> wrote:

Fixed the flag.quiet structure issue

This should be replaced with G_verbose_message()

4

2015-01-20 16:04 GMT+01:00 Yann Chemin <ychemin@gmail.com>:

tentatively replaced by:
    if (G_verbose == 3)
    {
        m_output(A);
    }

is that OK?

no, should be

if (G_verbose() > G_verbose_std())

Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa

5

Thanks Martin, done in r64256

···

On 20 January 2015 at 20:36, Martin Landa <landa.martin@gmail.com> wrote:

2015-01-20 16:04 GMT+01:00 Yann Chemin <ychemin@gmail.com>:

tentatively replaced by:
if (G_verbose == 3)
{
m_output(A);
}

is that OK?

no, should be

if (G_verbose() > G_verbose_std())

Martin

–
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa

–

6

On Tue, Jan 20, 2015 at 10:04 AM, Yann Chemin <ychemin@gmail.com> wrote:

m_output(A);

It also depends on what the function is doing, for example if it is
outputting some map or time series, it could be a separate option.