[GRASS-dev] [GRASS-SVN] r68061 - grass/trunk/lib/gis

Hi,

2016-03-15 9:56 GMT+01:00 <svn_grass@osgeo.org>:

Author: hcho
Date: 2016-03-15 01:56:28 -0700 (Tue, 15 Mar 2016)
New Revision: 68061

Modified:
   grass/trunk/lib/gis/parser.c
Log:
G_recreate_command: Add empty answers.
Fix the command history for e.g., v.edit where="". Without this fix, where="" is not included, which makes an invalid command.

I tried to backport this commit to relbr70. My quick test:

v.random out=n n=100 --o
v.db.addtable n

leads to the all features removed.

v.edit n tool=delete where=""
Selecting features...
100 of 100 features selected from vector map <n@PERMANENT>
100 features deleted

I thought that this should be fixed by this commit, right? So no
features removed (?)

Thanks for explanation. Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

Hi Martin,

This fix only affects the history, not its behavior. “v.info -h n” gives you:

COMMAND: v.edit map=“n” layer=“1” type=“point,line,boundary,centroid” tool=“delete” threshold=-1,0,0 where=“” snap=“no”

Without this fix, you’ll see:

COMMAND: v.edit map=“n” layer=“1” type=“point,line,boundary,centroid” tool=“delete” threshold=-1,0,0 snap=“no”

and cannot reuse this command without manually adding where=“”.

BTW, I think v.edit n tool=delete where=“” should delete all features because you’re selecting all records by “select * from n” without any where conditions. So your results look OK.

Huidae

···

On Sun, May 1, 2016 at 4:51 PM, Martin Landa <landa.martin@gmail.com> wrote:

Hi,

2016-03-15 9:56 GMT+01:00 <svn_grass@osgeo.org>:

Author: hcho
Date: 2016-03-15 01:56:28 -0700 (Tue, 15 Mar 2016)
New Revision: 68061

Modified:
grass/trunk/lib/gis/parser.c
Log:
G_recreate_command: Add empty answers.
Fix the command history for e.g., v.edit where=“”. Without this fix, where=“” is not included, which makes an invalid command.

I tried to backport this commit to relbr70. My quick test:

v.random out=n n=100 --o
v.db.addtable n

leads to the all features removed.

v.edit n tool=delete where=“”
Selecting features…
100 of 100 features selected from vector map n@PERMANENT
100 features deleted

I thought that this should be fixed by this commit, right? So no
features removed (?)

Thanks for explanation. Martin


Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa


grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev