[GRASS-dev] [GRASS-SVN] r70821 - grass/trunk/include/Make

GRASS GRASS developer
1

Hi Maris,

and, shall I backport this one?

Markus

On Sat, Apr 1, 2017 at 2:35 PM, <svn_grass@osgeo.org> wrote:

Author: marisn
Date: 2017-04-01 05:35:46 -0700 (Sat, 01 Apr 2017)
New Revision: 70821

Modified:
   grass/trunk/include/Make/Rules.make
Log:
Enforce C language when running Python during compilation as LANGUAGE has a preference over LC_ALL.

Modified: grass/trunk/include/Make/Rules.make

--- grass/trunk/include/Make/Rules.make 2017-04-01 11:48:43 UTC (rev 70820)
+++ grass/trunk/include/Make/Rules.make 2017-04-01 12:35:46 UTC (rev 70821)
@@ -38,7 +38,7 @@
        PATH="$(ARCH_DISTDIR)/bin:$(GISBASE)/bin:$(GISBASE)/scripts:$$PATH" \
        PYTHONPATH="$(GRASS_PYTHONPATH)" \
        $(LD_LIBRARY_PATH_VAR)="$(BIN):$(GISBASE)/bin:$(GISBASE)/scripts:$(ARCH_LIBDIR):$(BASE_LIBDIR):$($(LD_LIBRARY_PATH_VAR))" \
- LC_ALL=C \
+ LC_ALL=C LANG=C LANGUAGE=C \
        $(1)

# default clean rules

_______________________________________________
grass-commit mailing list
grass-commit@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-commit

2

Yes, this one looks safe too, although it affects only compilation
running on non English locales thus a minority of users.

Māris.

2017-05-30 11:44 GMT+03:00 Markus Neteler <neteler@osgeo.org>:

Hi Maris,

and, shall I backport this one?

Markus

On Sat, Apr 1, 2017 at 2:35 PM, <svn_grass@osgeo.org> wrote:

Author: marisn
Date: 2017-04-01 05:35:46 -0700 (Sat, 01 Apr 2017)
New Revision: 70821

Modified:
   grass/trunk/include/Make/Rules.make
Log:
Enforce C language when running Python during compilation as LANGUAGE has a preference over LC_ALL.

Modified: grass/trunk/include/Make/Rules.make

--- grass/trunk/include/Make/Rules.make 2017-04-01 11:48:43 UTC (rev 70820)
+++ grass/trunk/include/Make/Rules.make 2017-04-01 12:35:46 UTC (rev 70821)
@@ -38,7 +38,7 @@
        PATH="$(ARCH_DISTDIR)/bin:$(GISBASE)/bin:$(GISBASE)/scripts:$$PATH" \
        PYTHONPATH="$(GRASS_PYTHONPATH)" \
        $(LD_LIBRARY_PATH_VAR)="$(BIN):$(GISBASE)/bin:$(GISBASE)/scripts:$(ARCH_LIBDIR):$(BASE_LIBDIR):$($(LD_LIBRARY_PATH_VAR))" \
- LC_ALL=C \
+ LC_ALL=C LANG=C LANGUAGE=C \
        $(1)

# default clean rules

_______________________________________________
grass-commit mailing list
grass-commit@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-commit

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

3

Hi,

I guess I have to revert it:

grass72_svn/lib/cdhc]$ make
if [ "" != "" -a -f "".html ] ; then make html ; fi
==============TEST=============
make test
make[1]: Entering directory '/home/mundialis/software/grass72_svn/lib/cdhc'
GISRC=/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/demolocation/.grassrc72
GISBASE=/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu
PATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/scripts:$PATH"
PYTHONPATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/etc/python:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/gui/wxpython:$PYTHONPATH"
LD_LIBRARY_PATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/scripts:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/lib:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/lib:"
LC_ALL=C LANG=C LANGUAGE=C OBJ.x86_64-pc-linux-gnu/test <
test_numbers.csv
TESTS:
N: 30
/bin/sh: line 1: 28663 Illegal instruction (core dumped)
GISRC=/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/demolocation/.grassrc72
GISBASE=/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu
PATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/scripts:$PATH"
PYTHONPATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/etc/python:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/gui/wxpython:$PYTHONPATH"
LD_LIBRARY_PATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/scripts:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/lib:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/lib:"
LC_ALL=C LANG=C LANGUAGE=C OBJ.x86_64-pc-linux-gnu/test <
test_numbers.csv
Makefile:19: recipe for target 'test' failed
make[1]: *** [test] Error 132
make[1]: Leaving directory '/home/mundialis/software/grass72_svn/lib/cdhc'
Makefile:13: recipe for target 'default' failed
make: *** [default] Error 2

Any idea why this fails?

Markus

On Wed, May 31, 2017 at 8:47 AM, Maris Nartiss <maris.gis@gmail.com> wrote:

Yes, this one looks safe too, although it affects only compilation
running on non English locales thus a minority of users.

Māris.

2017-05-30 11:44 GMT+03:00 Markus Neteler <neteler@osgeo.org>:

Hi Maris,

and, shall I backport this one?

Markus

On Sat, Apr 1, 2017 at 2:35 PM, <svn_grass@osgeo.org> wrote:

Author: marisn
Date: 2017-04-01 05:35:46 -0700 (Sat, 01 Apr 2017)
New Revision: 70821

Modified:
   grass/trunk/include/Make/Rules.make
Log:
Enforce C language when running Python during compilation as LANGUAGE has a preference over LC_ALL.

Modified: grass/trunk/include/Make/Rules.make

--- grass/trunk/include/Make/Rules.make 2017-04-01 11:48:43 UTC (rev 70820)
+++ grass/trunk/include/Make/Rules.make 2017-04-01 12:35:46 UTC (rev 70821)
@@ -38,7 +38,7 @@
        PATH="$(ARCH_DISTDIR)/bin:$(GISBASE)/bin:$(GISBASE)/scripts:$$PATH" \
        PYTHONPATH="$(GRASS_PYTHONPATH)" \
        $(LD_LIBRARY_PATH_VAR)="$(BIN):$(GISBASE)/bin:$(GISBASE)/scripts:$(ARCH_LIBDIR):$(BASE_LIBDIR):$($(LD_LIBRARY_PATH_VAR))" \
- LC_ALL=C \
+ LC_ALL=C LANG=C LANGUAGE=C \
        $(1)

# default clean rules

_______________________________________________
grass-commit mailing list
grass-commit@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-commit

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

--
Markus Neteler, PhD
http://www.mundialis.de - free data with free software
http://grass.osgeo.org
http://courses.neteler.org/blog

4

Hello Markus,
no idea, as it runs just fine on my system and I do not see any easy
to spot problem with test.c code. You should run it under valgrind /
gdb or just send me the core file.
Ah, yes, while at it, include also
/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/demolocation/.grassrc72

Setting all locale stuff to C should prevent failures when translated
strings are used or comma is the decimal separator thus it *should* be
harmless.

Māris.

2017-05-31 14:56 GMT+03:00 Markus Neteler <neteler@osgeo.org>:

Hi,

I guess I have to revert it:

grass72_svn/lib/cdhc]$ make
if [ "" != "" -a -f "".html ] ; then make html ; fi
==============TEST=============
make test
make[1]: Entering directory '/home/mundialis/software/grass72_svn/lib/cdhc'
GISRC=/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/demolocation/.grassrc72
GISBASE=/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu
PATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/scripts:$PATH"
PYTHONPATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/etc/python:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/gui/wxpython:$PYTHONPATH"
LD_LIBRARY_PATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/scripts:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/lib:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/lib:"
LC_ALL=C LANG=C LANGUAGE=C OBJ.x86_64-pc-linux-gnu/test <
test_numbers.csv
TESTS:
N: 30
/bin/sh: line 1: 28663 Illegal instruction (core dumped)
GISRC=/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/demolocation/.grassrc72
GISBASE=/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu
PATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/scripts:$PATH"
PYTHONPATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/etc/python:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/gui/wxpython:$PYTHONPATH"
LD_LIBRARY_PATH="/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/bin:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/scripts:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/lib:/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/lib:"
LC_ALL=C LANG=C LANGUAGE=C OBJ.x86_64-pc-linux-gnu/test <
test_numbers.csv
Makefile:19: recipe for target 'test' failed
make[1]: *** [test] Error 132
make[1]: Leaving directory '/home/mundialis/software/grass72_svn/lib/cdhc'
Makefile:13: recipe for target 'default' failed
make: *** [default] Error 2

Any idea why this fails?

Markus

On Wed, May 31, 2017 at 8:47 AM, Maris Nartiss <maris.gis@gmail.com> wrote:

Yes, this one looks safe too, although it affects only compilation
running on non English locales thus a minority of users.

Māris.

2017-05-30 11:44 GMT+03:00 Markus Neteler <neteler@osgeo.org>:

Hi Maris,

and, shall I backport this one?

Markus

On Sat, Apr 1, 2017 at 2:35 PM, <svn_grass@osgeo.org> wrote:

Author: marisn
Date: 2017-04-01 05:35:46 -0700 (Sat, 01 Apr 2017)
New Revision: 70821

Modified:
   grass/trunk/include/Make/Rules.make
Log:
Enforce C language when running Python during compilation as LANGUAGE has a preference over LC_ALL.

Modified: grass/trunk/include/Make/Rules.make

--- grass/trunk/include/Make/Rules.make 2017-04-01 11:48:43 UTC (rev 70820)
+++ grass/trunk/include/Make/Rules.make 2017-04-01 12:35:46 UTC (rev 70821)
@@ -38,7 +38,7 @@
        PATH="$(ARCH_DISTDIR)/bin:$(GISBASE)/bin:$(GISBASE)/scripts:$$PATH" \
        PYTHONPATH="$(GRASS_PYTHONPATH)" \
        $(LD_LIBRARY_PATH_VAR)="$(BIN):$(GISBASE)/bin:$(GISBASE)/scripts:$(ARCH_LIBDIR):$(BASE_LIBDIR):$($(LD_LIBRARY_PATH_VAR))" \
- LC_ALL=C \
+ LC_ALL=C LANG=C LANGUAGE=C \
        $(1)

# default clean rules

_______________________________________________
grass-commit mailing list
grass-commit@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-commit

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

--
Markus Neteler, PhD
http://www.mundialis.de - free data with free software
http://grass.osgeo.org
http://courses.neteler.org/blog

5

Hi Māris,

On Wed, May 31, 2017 at 5:25 PM, Maris Nartiss <maris.gis@gmail.com> wrote:

Hello Markus,
no idea, as it runs just fine on my system and I do not see any easy
to spot problem with test.c code. You should run it under valgrind /
gdb or just send me the core file.
Ah, yes, while at it, include also
/home/mundialis/software/grass72_svn/dist.x86_64-pc-linux-gnu/demolocation/.grassrc72

Setting all locale stuff to C should prevent failures when translated
strings are used or comma is the decimal separator thus it *should* be
harmless.

indeed it is.
I got into a trap with a gcc compiler flag which collided in an
"interesting" way after having virtualised my workhorse machine at the
same time when I backported the change.

Sorry for the noise, all good.

Markus