[GRASS-dev] [GRASS-SVN] r71332 - in grass/trunk/gui/wxpython: . core

GRASS GRASS developer
1

Hi,

2017-08-06 23:56 GMT+02:00 <svn_grass@osgeo.org>:

Author: annakrat
Date: 2017-08-06 14:56:32 -0700 (Sun, 06 Aug 2017)
New Revision: 71332

Modified:
   grass/trunk/gui/wxpython/core/globalvar.py
   grass/trunk/gui/wxpython/wxgui.py
Log:
wxGUI: fix launching with Phoenix on Mac (splash screen), more robust version parsing

this commit causes GUI crash on my PC (Debian unstable, python 2.7,
wxpython 3.0.2)

Traceback (most recent call last):
  File "/var/local/src/grass_trunk/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py",
line 167, in <module>
    sys.exit(main())
  File "/var/local/src/grass_trunk/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py",
line 154, in main
    app = GMApp(workspaceFile)
  File "/var/local/src/grass_trunk/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py",
line 48, in __init__
    wx.App.__init__(self, False)
  File "/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/_core.py",
line 8628, in __init__
    self._BootstrapApp()
  File "/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/_core.py",
line 8196, in _BootstrapApp
    return _core_.PyApp__BootstrapApp(*args, **kwargs)
  File "/var/local/src/grass_trunk/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py",
line 62, in OnInit
    introImage = wx.Image(introImagePath, wx.BITMAP_TYPE_PNG)
UnboundLocalError: local variable 'wx' referenced before assignment

Any idea? Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

2

Thanks for catching this, could you please revert it, I can’t do it now. I will look at it later.

···

On Aug 8, 2017 9:03 AM, “Martin Landa” <landa.martin@gmail.com> wrote:

Hi,

2017-08-06 23:56 GMT+02:00 <svn_grass@osgeo.org>:

Author: annakrat
Date: 2017-08-06 14:56:32 -0700 (Sun, 06 Aug 2017)
New Revision: 71332

Modified:
grass/trunk/gui/wxpython/core/globalvar.py
grass/trunk/gui/wxpython/wxgui.py
Log:
wxGUI: fix launching with Phoenix on Mac (splash screen), more robust version parsing

this commit causes GUI crash on my PC (Debian unstable, python 2.7,
wxpython 3.0.2)

Traceback (most recent call last):
File “/var/local/src/grass_trunk/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py”,
line 167, in
sys.exit(main())
File “/var/local/src/grass_trunk/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py”,
line 154, in main
app = GMApp(workspaceFile)
File “/var/local/src/grass_trunk/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py”,
line 48, in init
wx.App.init(self, False)
File “/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/_core.py”,
line 8628, in init
self._BootstrapApp()
File “/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/_core.py”,
line 8196, in _BootstrapApp
return core.PyApp__BootstrapApp(*args, **kwargs)
File “/var/local/src/grass_trunk/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py”,
line 62, in OnInit
introImage = wx.Image(introImagePath, wx.BITMAP_TYPE_PNG)
UnboundLocalError: local variable ‘wx’ referenced before assignment

Any idea? Ma

–
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

3

2017-08-08 15:06 GMT+02:00 Anna Petrášová <kratochanna@gmail.com>:

Thanks for catching this, could you please revert it, I can't do it now. I
will look at it later.

done in r71341. Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

4

On Tue, Aug 8, 2017 at 9:10 AM, Martin Landa <landa.martin@gmail.com> wrote:

2017-08-08 15:06 GMT+02:00 Anna Petrášová <kratochanna@gmail.com>:

Thanks for catching this, could you please revert it, I can't do it now. I
will look at it later.

done in r71341. Ma

Thank you, I hopefully fixed in r71346, although I still don't
understand what is the problem exactly.

Anna

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

5

Hi,

2017-08-09 0:40 GMT+02:00 Anna Petrášová <kratochanna@gmail.com>:

Thank you, I hopefully fixed in r71346, although I still don't
understand what is the problem exactly.

confirmed, works. Thanks, Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa