[GRASS-dev] [GRASS-SVN] r74422 - grass/trunk/lib/python/pygrass/modules/interface/testsuite

GRASS GRASS developer
1

Hi,

<svn_grass@osgeo.org> schrieb am Mi., 24. Apr. 2019, 22:33:

Author: sbl
Date: 2019-04-24 13:33:36 -0700 (Wed, 24 Apr 2019)
New Revision: 74422

Modified:
grass/trunk/lib/python/pygrass/modules/interface/testsuite/test_pygrass_modules_interface_doctests.py
Log:
temporarily deactivate for Python 3; see #3825

Modified: grass/trunk/lib/python/pygrass/modules/interface/testsuite/test_pygrass_modules_interface_doctests.py

— grass/trunk/lib/python/pygrass/modules/interface/testsuite/test_pygrass_modules_interface_doctests.py 2019-04-24 20:33:02 UTC (rev 74421)
+++ grass/trunk/lib/python/pygrass/modules/interface/testsuite/test_pygrass_modules_interface_doctests.py 2019-04-24 20:33:36 UTC (rev 74422)
@@ -39,4 +39,8 @@

if name == ‘main’:

  • grass.gunittest.main.test()

  • Temporarily skip test for Python 3

  • if sys.version_info[0] > 2:
  • pass
  • else:
  • grass.gunittest.main.test()

IMHO there should be at least a message… Like this the skipped test will be forgotten quickly.

Just my 0.02 cents,
Markus

2

Hi again,

#3825 was opened for not forgetting it.

But indeed, issuing a warning message makes sense if test is run individually.

As mentioned, in multirunner it should be visible (0 tests succeeded).

Cheers,

Stefan

···

Hi,

<svn_grass@osgeo.org> schrieb am Mi., 24. Apr. 2019, 22:33:

Author: sbl
Date: 2019-04-24 13:33:36 -0700 (Wed, 24 Apr 2019)
New Revision: 74422

Modified:
grass/trunk/lib/python/pygrass/modules/interface/testsuite/test_pygrass_modules_interface_doctests.py
Log:
temporarily deactivate for Python 3; see #3825

Modified: grass/trunk/lib/python/pygrass/modules/interface/testsuite/test_pygrass_modules_interface_doctests.py

— grass/trunk/lib/python/pygrass/modules/interface/testsuite/test_pygrass_modules_interface_doctests.py 2019-04-24 20:33:02 UTC (rev 74421)
+++ grass/trunk/lib/python/pygrass/modules/interface/testsuite/test_pygrass_modules_interface_doctests.py 2019-04-24 20:33:36 UTC (rev 74422)
@@ -39,4 +39,8 @@

if name == ‘main’:

  • grass.gunittest.main.test()

  • Temporarily skip test for Python 3

  • if sys.version_info[0] > 2:
  • pass
  • else:
  • grass.gunittest.main.test()

IMHO there should be at least a message… Like this the skipped test will be forgotten quickly.

Just my 0.02 cents,

Markus