[GRASS-dev] [GRASS-trac] #12: gis.m->Help->About system doesn't work (launches another gis.m instance)

#12: gis.m->Help->About system doesn't work (launches another gis.m instance)
---------------------+------------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: major | Milestone: 6.3.0
Component: default | Version: unspecified
Keywords: |
---------------------+------------------------------------------------------
Clicking on 'About System' within the gis.m Help menu launches a new set
of gis.m windows instead of opening a tcl/tk window with system
parameters. The newly created gis manager toolbar says "Tk System
Information".

PS: moved here from
http://wald.intevation.org/tracker/?func=detail&atid=204&aid=553&group_id=21

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/12&gt;
GRASS-trac <http://grass.osgeo.org>
Commonly referred to as GRASS, this is a Geographic Information System (GIS) used for geospatial data management and analysis, image processing, graphics/maps production, spatial modeling, and visualization. GRASS is currently used in academic and commercial settings around the world, as well as by many governmental agencies and environmental consulting companies.

#12: gis.m->Help->About system doesn't work (launches another gis.m instance)
----------------------+-----------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.3.0
Component: default | Version: unspecified
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by cmbarton):

Replying to [ticket:12 neteler]:
> Clicking on 'About System' within the gis.m Help menu launches a new set
of gis.m windows instead of opening a tcl/tk window with system
parameters. The newly created gis manager toolbar says "Tk System
Information".
>
> PS: moved here from
http://wald.intevation.org/tracker/?func=detail&atid=204&aid=553&group_id=21

Is this function worth the trouble of trying to fix? It is very old,
heavily patched code. It returns the following information from within the
GRASS TclTk GUI, but I think better information could be had by utilities
common to all systems on which GRASS runs.

  "Platform "
  "Operating System "
  "OS Version "
  "Processor Type (arch) "
  "User Name "
  "Hostname "
  "Tcl Version "
  "Name of Executable "
  "Tcl Version/Patchlevel "
  "Full OS ID "
  "Name of current Script "

Michael

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/12#comment:1&gt;
GRASS-trac <http://grass.osgeo.org>
Commonly referred to as GRASS, this is a Geographic Information System (GIS) used for geospatial data management and analysis, image processing, graphics/maps production, spatial modeling, and visualization. GRASS is currently used in academic and commercial settings around the world, as well as by many governmental agencies and environmental consulting companies.

GRASS-trac wrote:

#12: gis.m->Help->About system doesn't work (launches another gis.m instance)
----------------------+-----------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.3.0
Component: default | Version: unspecified
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by cmbarton):

Replying to [ticket:12 neteler]:
> Clicking on 'About System' within the gis.m Help menu launches a new set
of gis.m windows instead of opening a tcl/tk window with system
parameters. The newly created gis manager toolbar says "Tk System
Information".
>
> PS: moved here from
http://wald.intevation.org/tracker/?func=detail&atid=204&aid=553&group_id=21

Is this function worth the trouble of trying to fix?

This is just a symptom of a larger problem, namely that the Gm::errmsg
procedure is defined in gm.tcl, which cannot be "source"d (because
doing so will "run" gis.m).

Gm::errmsg belongs in a "library", i.e. a Tcl source file which can be
"source"d from other Tcl source files.

Also: gm.tcl calls Gm::errmsg from top-level code at the beginning of
the file (the code which copies various g.gisenv settings into $env),
although the procedure isn't actually defined until much later in the
file. If any of those "catch" statements actually catch an error, the
handler will throw an error due to Gm::errmsg being undefined.

--
Glynn Clements <glynn@gclements.plus.com>

#12: gis.m->Help->About system doesn't work (launches another gis.m instance)
----------------------+-----------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: new
  Priority: major | Milestone: 6.3.0
Component: default | Version: unspecified
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by neteler):

(copied here from the Mailing list)

This is just a symptom of a larger problem, namely that the Gm::errmsg
procedure is defined in gm.tcl, which cannot be "source"d (because
doing so will "run" gis.m).

Gm::errmsg belongs in a "library", i.e. a Tcl source file which can be
"source"d from other Tcl source files.

Also: gm.tcl calls Gm::errmsg from top-level code at the beginning of
the file (the code which copies various g.gisenv settings into $env),
although the procedure isn't actually defined until much later in the
file. If any of those "catch" statements actually catch an error, the
handler will throw an error due to Gm::errmsg being undefined.

--
Glynn Clements <glynn@...>

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/12#comment:2&gt;
GRASS-trac <http://grass.osgeo.org>
Commonly referred to as GRASS, this is a Geographic Information System (GIS) used for geospatial data management and analysis, image processing, graphics/maps production, spatial modeling, and visualization. GRASS is currently used in academic and commercial settings around the world, as well as by many governmental agencies and environmental consulting companies.

#12: gis.m->Help->About system doesn't work (launches another gis.m instance)
----------------------+-----------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: closed
  Priority: major | Milestone: 6.3.0
Component: default | Version: unspecified
Resolution: fixed | Keywords:
----------------------+-----------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

fixed with Changeset [29647] by cmbarton

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/12#comment:3&gt;
GRASS-trac <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

#12: gis.m->Help->About system doesn't work (launches another gis.m instance)
----------------------+-----------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: closed
  Priority: major | Milestone: 6.3.0
Component: default | Version: unspecified
Resolution: fixed | Keywords:
----------------------+-----------------------------------------------------
Comment (by hamish):

Michael,

r29647 does not appear to be backported to the 6.3 branch. Should it be?
any other gis.m bug fixes that need to be backported?

?,
Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/12#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

Yes, this should be backported. I thought that was fixed before the 6.3.0 branch. But apparently it didn't get ported over. I've tried to keep Markus up to date on any other bug fixes since the 6.3.0 branch. I hope I haven't missed anything else. Thanks for spotting it.

Michael
____________________
C. Michael Barton, Professor of Anthropology
Director of Graduate Studies
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

Phone: 480-965-6262
Fax: 480-965-7671
www: <www.public.asu.edu/~cmbarton>

On Mar 3, 2008, at 9:49 PM, GRASS GIS wrote:

#12: gis.m->Help->About system doesn't work (launches another gis.m instance)
----------------------+-----------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: closed
  Priority: major | Milestone: 6.3.0
Component: default | Version: unspecified
Resolution: fixed | Keywords:
----------------------+-----------------------------------------------------
Comment (by hamish):

Michael,

r29647 does not appear to be backported to the 6.3 branch. Should it be?
any other gis.m bug fixes that need to be backported?

?,
Hamish

--
Ticket URL: <#12 (gis.m->Help->About system doesn't work (launches another gis.m instance)) – GRASS GIS;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

#12: gis.m->Help->About system doesn't work (launches another gis.m instance)
----------------------+-----------------------------------------------------
  Reporter: neteler | Owner: grass-dev@lists.osgeo.org
      Type: defect | Status: closed
  Priority: major | Milestone: 6.3.0
Component: default | Version: unspecified
Resolution: fixed | Keywords:
----------------------+-----------------------------------------------------
Comment (by hamish):

Replying to [comment:4 hamish]:
> Michael,
>
> r29647 does not appear to be backported to the 6.3 branch. Should it be?
any other gis.m bug fixes that need to be backported?

tip: in the trac SVN browser click on the Rev number next to a directory
name to see change history of all files in that dir.

   http://trac.osgeo.org/grass/log/grass/trunk/gui/tcltk/gis.m

H

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/12#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

Michael wrote:

Yes, this should be backported. I thought that was fixed before the
6.3.0 branch. But apparently it didn't get ported over.

the change does not apply cleanly, the 6.3.0RC version has gmlib.tcl
not gm.tcl.

what to do? remove gmlib.tcl line from releasebranch_6_3 or was gm.tcl
removed from trunk when it should have been changed to gmlib.tcl ?

http://trac.osgeo.org/grass/changeset?new=grass%2Ftrunk%2Fgui%2Ftcltk%2Fgis.m%2Ftksys.tcl%4029624&old=grass%2Ftrunk%2Fgui%2Ftcltk%2Fgis.m%2Ftksys.tcl%4024717

Hamish

      ____________________________________________________________________________________
Looking for last minute shopping deals?
Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping

Some functions, primarily from Gm.tcl, were moved into a gmlib.tcl

It's probably simply a replacement of gmlib::[proc] with gm::[proc].

I'll have to look into it. Today is pretty busy. Maybe tonight or tomorrow.

Michael

On Mar 3, 2008, at 10:52 PM, Hamish wrote:

Michael wrote:

Yes, this should be backported. I thought that was fixed before the
6.3.0 branch. But apparently it didn't get ported over.

the change does not apply cleanly, the 6.3.0RC version has gmlib.tcl
not gm.tcl.

what to do? remove gmlib.tcl line from releasebranch_6_3 or was gm.tcl
removed from trunk when it should have been changed to gmlib.tcl ?

http://trac.osgeo.org/grass/changeset?new=grass%2Ftrunk%2Fgui%2Ftcltk%2Fgis.m%2Ftksys.tcl%4029624&old=grass%2Ftrunk%2Fgui%2Ftcltk%2Fgis.m%2Ftksys.tcl%4024717

Hamish

      ____________________________________________________________________________________
Looking for last minute shopping deals?
Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping