[GRASS-dev] GRASS7 ImageryLib

GRASS GIS GRASS GIS developer
1

All,

I found these here[1] and says many things which needed help. So I thought to give a try in order

  1. Imagery Library needs fundamental clean up (the library is not maintained from GRASS 5)

Anyone can elaborate on this line?

  1. Reimplement groups to be generic element (in GIS Library)

I guess i.group module should be g.group which can groups both raster/vector maps

Is that correct?

please reply back with some comments/suggestion regarding these two

[1] http://trac.osgeo.org/grass/wiki/Grass7/ImageryLib

–

Regards,
Rashad

2

On Fri, Nov 30, 2012 at 5:26 AM, Mohammed Rashad
<mohammedrashadkm@gmail.com> wrote:

All,

I found these here[1] and says many things which needed help. So I thought
to give a try in order

1. Imagery Library needs fundamental clean up (the library is not maintained
from GRASS 5)

Anyone can elaborate on this line?

Fully agreed.

It might be sensible to merge the various image libraries:

GRASS 6/7:
* lib/imagery/: standard lib, in use (i.* except for i.points3,
i.rectify3, see below)
* imagery/i.ortho.photo/libes/: standard lib, in use (i.ortho.photo, photo.*)

GRASS 5 (! only) image3 lib:
* libes/image3/: never finished improvement which integrated the
standard lib and the ortho lib. Seems to provide also ortho
rectification for satellite data (i.points3, i.rectify3)

GRASS 5/6 image proc commands:
* merge of i.points, i.vpoints, i.points3 (see above)
* merge of i.rectify and i.rectify3 (see above)

Overall
* add other warping methods (maybe lanczos or thin splines from GDAL?)

However, the library cleanup in GRASS 7 would be essential.

2. Reimplement groups to be generic element (in GIS Library)

I guess i.group module should be g.group which can groups both raster/vector
maps

Is that correct?

Correct I don't know, maybe subject to discussion.

Best
Markus

3

On Fri, Nov 30, 2012 at 7:46 PM, Markus Neteler <neteler@osgeo.org> wrote:

On Fri, Nov 30, 2012 at 5:26 AM, Mohammed Rashad
<mohammedrashadkm@gmail.com> wrote:
>
> All,
>
>
> I found these here[1] and says many things which needed help. So I
thought
> to give a try in order
>
>
> 1. Imagery Library needs fundamental clean up (the library is not
maintained
> from GRASS 5)
>
> Anyone can elaborate on this line?

Fully agreed.

It might be sensible to merge the various image libraries:

GRASS 6/7:
* lib/imagery/: standard lib, in use (i.* except for i.points3,
i.rectify3, see below)
* imagery/i.ortho.photo/libes/: standard lib, in use (i.ortho.photo,
photo.*)

i.points3 and i.rectify3 doesnt uses standard lib. So adding API style code
which can be used by i.point3 and i.rectify3 is what you are saying. Am I
correct?

i.ortho.photo uses i.ortho.photo/libes right?

so merging both libs will provide an API which any grass imagery module can
share right?

GRASS 5 (! only) image3 lib:
* libes/image3/: never finished improvement which integrated the
standard lib and the ortho lib. Seems to provide also ortho
rectification for satellite data (i.points3, i.rectify3)

GRASS 5/6 image proc commands:
* merge of i.points, i.vpoints, i.points3 (see above)
* merge of i.rectify and i.rectify3 (see above)

Overall
* add other warping methods (maybe lanczos or thin splines from GDAL?)

This part is not clear to me at all

However, the library cleanup in GRASS 7 would be essential.

> 2. Reimplement groups to be generic element (in GIS Library)
>
> I guess i.group module should be g.group which can groups both
raster/vector
> maps
>
> Is that correct?

Correct I don't know, maybe subject to discussion.

Anyone have any comments ?

Best
Markus

--
Regards,
   Rashad

4

[answering here because I have worked on some of the affected modules]

On Wed, Dec 5, 2012 at 6:16 PM, Mohammed Rashad
<mohammedrashadkm@gmail.com> wrote:

On Fri, Nov 30, 2012 at 7:46 PM, Markus Neteler <neteler@osgeo.org> wrote:

On Fri, Nov 30, 2012 at 5:26 AM, Mohammed Rashad
<mohammedrashadkm@gmail.com> wrote:
>
> All,
>
>
> I found these here[1] and says many things which needed help. So I
> thought
> to give a try in order
>
>
> 1. Imagery Library needs fundamental clean up (the library is not
> maintained
> from GRASS 5)
>
> Anyone can elaborate on this line?

Fully agreed.

It might be sensible to merge the various image libraries:

GRASS 6/7:
* lib/imagery/: standard lib, in use (i.* except for i.points3,
i.rectify3, see below)
* imagery/i.ortho.photo/libes/: standard lib, in use (i.ortho.photo,
photo.*)

i.points3 and i.rectify3 doesnt uses standard lib. So adding API style code
which can be used by i.point3 and i.rectify3 is what you are saying. Am I
correct?

I guess so, but I would suggest to move the libs needed by i.points3
and i.rectify3 to a separate GRASS lib, probably ortholib

i.ortho.photo uses i.ortho.photo/libes right?

No, it uses (will use) ortholib, currently i.ortho.photo/lib, but I am
busy porting it and related modules to trunk.

so merging both libs will provide an API which any grass imagery module can
share right?

I would suggest to separate standard imagery lib and
orthorectification, because these two use substantially different
algorithms. The ortholib depends on imager lib.

GRASS 5 (! only) image3 lib:
* libes/image3/: never finished improvement which integrated the
standard lib and the ortho lib. Seems to provide also ortho
rectification for satellite data (i.points3, i.rectify3)

GRASS 5/6 image proc commands:
* merge of i.points, i.vpoints, i.points3 (see above)
* merge of i.rectify and i.rectify3 (see above)

Overall
* add other warping methods (maybe lanczos or thin splines from GDAL?)

This part is not clear to me at all

Lanczos is already available.

What could be gained by adding thin splines to the existing bilinear,
bicubic, bspline, lanczos methods?

Markus M

However, the library cleanup in GRASS 7 would be essential.

> 2. Reimplement groups to be generic element (in GIS Library)
>
> I guess i.group module should be g.group which can groups both
> raster/vector
> maps
>
> Is that correct?

Correct I don't know, maybe subject to discussion.

Anyone have any comments ?

Best
Markus

--
Regards,
   Rashad

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

5

On Sun, Dec 9, 2012 at 1:51 AM, Markus Metz
<markus.metz.giswork@gmail.com>wrote:

[answering here because I have worked on some of the affected modules]

On Wed, Dec 5, 2012 at 6:16 PM, Mohammed Rashad
<mohammedrashadkm@gmail.com> wrote:
>
>
>
> On Fri, Nov 30, 2012 at 7:46 PM, Markus Neteler <neteler@osgeo.org>
wrote:
>>
>> On Fri, Nov 30, 2012 at 5:26 AM, Mohammed Rashad
>> <mohammedrashadkm@gmail.com> wrote:
>> >
>> > All,
>> >
>> >
>> > I found these here[1] and says many things which needed help. So I
>> > thought
>> > to give a try in order
>> >
>> >
>> > 1. Imagery Library needs fundamental clean up (the library is not
>> > maintained
>> > from GRASS 5)
>> >
>> > Anyone can elaborate on this line?
>>
>> Fully agreed.
>>
>> It might be sensible to merge the various image libraries:
>>
>> GRASS 6/7:
>> * lib/imagery/: standard lib, in use (i.* except for i.points3,
>> i.rectify3, see below)
>> * imagery/i.ortho.photo/libes/: standard lib, in use (i.ortho.photo,
>> photo.*)
>>
>
>
> i.points3 and i.rectify3 doesnt uses standard lib. So adding API style
code
> which can be used by i.point3 and i.rectify3 is what you are saying. Am I
> correct?

I guess so, but I would suggest to move the libs needed by i.points3
and i.rectify3 to a separate GRASS lib, probably ortholib
>
> i.ortho.photo uses i.ortho.photo/libes right?

No, it uses (will use) ortholib, currently i.ortho.photo/lib, but I am
busy porting it and related modules to trunk.

>
> so merging both libs will provide an API which any grass imagery module
can
> share right?

I would suggest to separate standard imagery lib and
orthorectification, because these two use substantially different
algorithms. The ortholib depends on imager lib.

i.ortho.photo is under progress right? . So moving imager to a lib called
ortholib under imagery like imagery/ortholib or as grass_trunk/ortholib is
need to be done. right?

So If I start moving code around will it affect the current work on i.ortho
and friends?

>
>
>
>>
>> GRASS 5 (! only) image3 lib:
>> * libes/image3/: never finished improvement which integrated the
>> standard lib and the ortho lib. Seems to provide also ortho
>> rectification for satellite data (i.points3, i.rectify3)
>>
>> GRASS 5/6 image proc commands:
>> * merge of i.points, i.vpoints, i.points3 (see above)
>> * merge of i.rectify and i.rectify3 (see above)
>>
>> Overall
>> * add other warping methods (maybe lanczos or thin splines from GDAL?)
>
>
> This part is not clear to me at all

Lanczos is already available.

What could be gained by adding thin splines to the existing bilinear,
bicubic, bspline, lanczos methods?

This question is not clear for me

Markus M

>
>
>>
>>
>> However, the library cleanup in GRASS 7 would be essential.
>>
>> > 2. Reimplement groups to be generic element (in GIS Library)
>> >
>> > I guess i.group module should be g.group which can groups both
>> > raster/vector
>> > maps
>> >
>> > Is that correct?
>>
>> Correct I don't know, maybe subject to discussion.
>
>
>
> Anyone have any comments ?
>
>>
>>
>> Best
>> Markus
>
>
>
>
> --
> Regards,
> Rashad
>
>
> _______________________________________________
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/grass-dev

--
Regards,
   Rashad

6

On Sun, Dec 9, 2012 at 5:30 AM, Mohammed Rashad
<mohammedrashadkm@gmail.com> wrote:

On Sun, Dec 9, 2012 at 1:51 AM, Markus Metz <markus.metz.giswork@gmail.com>
wrote:

[answering here because I have worked on some of the affected modules]

On Wed, Dec 5, 2012 at 6:16 PM, Mohammed Rashad
<mohammedrashadkm@gmail.com> wrote:
>
>
>
> On Fri, Nov 30, 2012 at 7:46 PM, Markus Neteler <neteler@osgeo.org>
> wrote:
>>
>> On Fri, Nov 30, 2012 at 5:26 AM, Mohammed Rashad
>> <mohammedrashadkm@gmail.com> wrote:
>> >
>> > All,
>> >
>> >
>> > I found these here[1] and says many things which needed help. So I
>> > thought
>> > to give a try in order
>> >
>> >
>> > 1. Imagery Library needs fundamental clean up (the library is not
>> > maintained
>> > from GRASS 5)
>> >
>> > Anyone can elaborate on this line?
>>
>> Fully agreed.
>>
>> It might be sensible to merge the various image libraries:
>>
>> GRASS 6/7:
>> * lib/imagery/: standard lib, in use (i.* except for i.points3,
>> i.rectify3, see below)
>> * imagery/i.ortho.photo/libes/: standard lib, in use (i.ortho.photo,
>> photo.*)
>>
>
>
> i.points3 and i.rectify3 doesnt uses standard lib. So adding API style
> code
> which can be used by i.point3 and i.rectify3 is what you are saying. Am
> I
> correct?

I guess so, but I would suggest to move the libs needed by i.points3
and i.rectify3 to a separate GRASS lib, probably ortholib
>
> i.ortho.photo uses i.ortho.photo/libes right?

No, it uses (will use) ortholib, currently i.ortho.photo/lib, but I am
busy porting it and related modules to trunk.

>
> so merging both libs will provide an API which any grass imagery module
> can
> share right?

I would suggest to separate standard imagery lib and
orthorectification, because these two use substantially different
algorithms. The ortholib depends on imager lib.

i.ortho.photo is under progress right? . So moving imager to a lib called
ortholib under imagery like imagery/ortholib or as grass_trunk/ortholib is
need to be done. right?

I would prefer lib/ortho.

So If I start moving code around will it affect the current work on i.ortho
and friends?

Yes. I have already modified imagery/i.ortho.photo/lib in trunk but
not yet submitted. It's working now for me in trunk, as well as
i.photo.rectify. Please don't modify imagery/i.ortho.photo/lib before
I have submitted my changes.

>
>
>
>>
>> GRASS 5 (! only) image3 lib:
>> * libes/image3/: never finished improvement which integrated the
>> standard lib and the ortho lib. Seems to provide also ortho
>> rectification for satellite data (i.points3, i.rectify3)
>>
>> GRASS 5/6 image proc commands:
>> * merge of i.points, i.vpoints, i.points3 (see above)
>> * merge of i.rectify and i.rectify3 (see above)
>>
>> Overall
>> * add other warping methods (maybe lanczos or thin splines from GDAL?)
>
>
> This part is not clear to me at all

Lanczos is already available.

What could be gained by adding thin splines to the existing bilinear,
bicubic, bspline, lanczos methods?

This question is not clear for me

These interpolation methods are used by i.rectify, i.photo.rectify,
r.proj, r.resamp.interp. Adding thin splines might be a valuable
addition, but it could also cause confusion (too many methods to
choose from). These methods are in lib/raster/interp.c.

Markus M

>
>
>>
>>
>> However, the library cleanup in GRASS 7 would be essential.
>>
>> > 2. Reimplement groups to be generic element (in GIS Library)
>> >
>> > I guess i.group module should be g.group which can groups both
>> > raster/vector
>> > maps
>> >
>> > Is that correct?
>>
>> Correct I don't know, maybe subject to discussion.
>
>
>
> Anyone have any comments ?
>
>>
>>
>> Best
>> Markus
>
>
>
>
> --
> Regards,
> Rashad
>
>
> _______________________________________________
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/grass-dev

--
Regards,
   Rashad