[GRASS-dev] grass7: rename some G_OPTs in parser.c

GRASS GRASS developer
1

Hi,

I would suggest to rename DB related G_OPTs in parser.c to G_OPT_DB_, e.g.

G_OPT_WHERE to G_OPT_DB_WHERE.

Since those defines were added recently, maybe could be possible to
rename them also in grass6 (or to define aliases) ?

Martin

--
Martin Landa <landa.martin gmail.com> * http://gama.fsv.cvut.cz/~landa *

2

Martin Landa:

I would suggest to rename DB related G_OPTs in parser.c to
G_OPT_DB_, e.g.

G_OPT_WHERE to G_OPT_DB_WHERE.

yes, I had thoughts to do the same.
+1

Since those defines were added recently, maybe could be possible to
rename them also in grass6 (or to define aliases) ?

+0 (devbr6)

Hamish

3

Martin Landa:
> I would suggest to rename DB related G_OPTs in parser.c to
> G_OPT_DB_, e.g. G_OPT_WHERE to G_OPT_DB_WHERE.

...

> Since those defines were added recently, maybe could be possible to
> rename them also in grass6 (or to define aliases) ?

no aliases cluttering things up please, lets just do the job right, once.
AFAIK we only guarantee the user interface is stable within grass 6.x, not the library interface.

Hamish

4

On Sun, Aug 10, 2008 at 3:16 PM, Hamish <hamish_b@yahoo.com> wrote:

Martin Landa:
> I would suggest to rename DB related G_OPTs in parser.c to
> G_OPT_DB_, e.g. G_OPT_WHERE to G_OPT_DB_WHERE.

...

+1

> Since those defines were added recently, maybe could be possible to
> rename them also in grass6 (or to define aliases) ?

no aliases cluttering things up please, lets just do the job right, once.
AFAIK we only guarantee the user interface is stable within grass 6.x, not the library interface.

Are these G_OPTs externally used (GDAL, SWIG..)?
If not, let's do it also in (devbr6).

Markus

5

Hamish:

> no aliases cluttering things up please, lets just do the job right,
> once. AFAIK we only guarantee the user interface is stable
> within grass 6.x, not the library interface.

Markus:

Are these G_OPTs externally used (GDAL, SWIG..)?

(R interface, QGIS, ...)

Well I doubt they are used much. Especially as these are DB options.

If not, let's do it also in (devbr6).

upon reflection, one thing to consider is- are these used by addon C modules?

Looking through the addons svn I see 190 G_OPT_*, but those are limited to
G_OPT_R_INPUT
G_OPT_R_INPUTS
G_OPT_R_OUTPUT
G_OPT_V_FIELD
G_OPT_V_INPUT
G_OPT_V_OUTPUT
G_OPT_V_TYPE

so ok?

Hamish

6

Markus Neteler wrote:

>> > I would suggest to rename DB related G_OPTs in parser.c to
>> > G_OPT_DB_, e.g. G_OPT_WHERE to G_OPT_DB_WHERE.
> ...

+1

>> > Since those defines were added recently, maybe could be possible to
>> > rename them also in grass6 (or to define aliases) ?
>
> no aliases cluttering things up please, lets just do the job right, once.
> AFAIK we only guarantee the user interface is stable within grass 6.x, not the library interface.

Are these G_OPTs externally used (GDAL, SWIG..)?
If not, let's do it also in (devbr6).

You might also consider back-porting r31628, which checks that the
module was built with the same version of gis.h as libgis.

--
Glynn Clements <glynn@gclements.plus.com>

7

On Tue, Aug 12, 2008 at 2:14 AM, Glynn Clements
<glynn@gclements.plus.com> wrote:
...

You might also consider back-porting r31628, which checks that the
module was built with the same version of gis.h as libgis.

Done.

Markus

8

Hi,

2008/8/12 Hamish <hamish_b@yahoo.com>:

done in trunk, r33006

Are these G_OPTs externally used (GDAL, SWIG..)?

(R interface, QGIS, ...)

Well I doubt they are used much. Especially as these are DB options.

so we don't backport this change to devbr6 (?)

Martin

--
Martin Landa <landa.martin gmail.com> * http://gama.fsv.cvut.cz/~landa *