[GRASS-dev] i.image.mosaic/i.landsat.rgb

GRASS GIS GRASS GIS developer
1

Hello,

i.image.mosaic errors out with the following:

GRASS 6.3.cvs (black_rock):~ > i.image.mosaic image1=etm1.1
image2=etm2.1 image3=etm3.1

ATTENTION: Do not forget to set region properly to cover all images!

i.image.mosaic: line 85: [: argument expected
i.image.mosaic: line 106: [: argument expected
i.image.mosaic: line 119: [: too many arguments

With i.landsat.rgb, I get a bit farther, but produces a blank display.
I'm quite certain that is not a desirable feature. :slight_smile:

Could a good shell scripter take a look?

--
Brad Douglas <rez touchofmadness com> KB8UYR/6
Address: 37.493,-121.924 / WGS84 National Map Corps #TNMC-3785

2

Brad,

Try this version.

Daniel.

On 1/7/07, Brad Douglas <rez@touchofmadness.com> wrote:

Hello,

i.image.mosaic errors out with the following:

GRASS 6.3.cvs (black_rock):~ > i.image.mosaic image1=etm1.1
image2=etm2.1 image3=etm3.1

ATTENTION: Do not forget to set region properly to cover all images!

i.image.mosaic: line 85: [: argument expected
i.image.mosaic: line 106: [: argument expected
i.image.mosaic: line 119: [: too many arguments

With i.landsat.rgb, I get a bit farther, but produces a blank display.
I'm quite certain that is not a desirable feature. :slight_smile:

Could a good shell scripter take a look?

--
Brad Douglas <rez touchofmadness com> KB8UYR/6
Address: 37.493,-121.924 / WGS84 National Map Corps #TNMC-3785

_______________________________________________
grass-dev mailing list
grass-dev@grass.itc.it
http://grass.itc.it/mailman/listinfo/grass-dev

--
-- Daniel Calvelo Aros

(attachments)

i.image.mosaic (5.14 KB)

3

Daniel Calvelo wrote:

> i.image.mosaic errors out with the following:
>
> GRASS 6.3.cvs (black_rock):~ > i.image.mosaic image1=etm1.1
> image2=etm2.1 image3=etm3.1
>
> ATTENTION: Do not forget to set region properly to cover all images!
>
> i.image.mosaic: line 85: [: argument expected
> i.image.mosaic: line 106: [: argument expected
> i.image.mosaic: line 119: [: too many arguments

Try this version.

Looks good to me.

FWIW, looking for unquoted variable substitutions with:

  cd $GISBASE/scripts
  grep -n '[^"]\$' *

suggests that there may be quite a lot of these issues remaining.

Many of those are false positives, e.g. because the variable
substitution appears later in a quoted string rather than immediately
after the opening quote.

Also, some don't actually matter because the variable will always have
a value which is a single word to the shell, but it's always a good
idea to quote every variable substitution unless you actually *need*
the value to be subjected to further parsing.

Unquoted variable substitutions should be the exception rather than
the norm.

--
Glynn Clements <glynn@gclements.plus.com>

4

On Mon, 2007-01-08 at 15:34 +0000, Glynn Clements wrote:

Daniel Calvelo wrote:

> > i.image.mosaic errors out with the following:
> >
> > GRASS 6.3.cvs (black_rock):~ > i.image.mosaic image1=etm1.1
> > image2=etm2.1 image3=etm3.1
> >
> > ATTENTION: Do not forget to set region properly to cover all images!
> >
> > i.image.mosaic: line 85: [: argument expected
> > i.image.mosaic: line 106: [: argument expected
> > i.image.mosaic: line 119: [: too many arguments
>
> Try this version.

Looks good to me.

BTW, while that version got i.image.mosaic working, it's just as broken
as i.landsat.rgb. It clips all images to the dimensions of the first
one and overlays them, not patch them together.

I've been using r.patch, instead. :frowning:

--
Brad Douglas <rez touchofmadness com> KB8UYR/6
Address: 37.493,-121.924 / WGS84 National Map Corps #TNMC-3785