[GRASS-dev] i.landsat.rgb -p after using i.fusion.brovey

Hi,

i.landsat.rgb -p fails for me with maps created with i.fusion.brovey:
line 138: [: 47.9603: integer expression expected
[...]

Attached you find the small changes that make it work at least for me again.

Regards,
Otto

(attachments)

i.landsat.rgb.diff (1.4 KB)

Hi,

2008/2/6, Otto Dassau <otto.dassau@gmx.de>:

i.landsat.rgb -p fails for me with maps created with i.fusion.brovey:
line 138: [: 47.9603: integer expression expected
[...]

Attached you find the small changes that make it work at least for me again.

it seems to be same the issue as (patch already attached).

http://www.nabble.com/i.landsat.rgb-problem-td14917120.html#a14917120

Martin

--
Martin Landa <landa.martin@gmail.com> * http://gama.fsv.cvut.cz/~landa *

[cc: grass-dev]
Hi,

2008/2/6, Otto Dassau <otto.dassau@gmx.de>:

On Wed, 6 Feb 2008 16:53:31 +0100
yes, applied, tested and thanks a lot :-)! but it is not in svn yet, or?

no, since I was not sure.

We should definitely use Trac for such kind of patches, it is hard to
find them in ML, Trac seems to be a perfect place where to "stock"
patches.

If no objections I can commint my/your patch to SVN.

Martin

--
Martin Landa <landa.martin@gmail.com> * http://gama.fsv.cvut.cz/~landa *

On Wed, 6 Feb 2008 17:39:38 +0100
"Martin Landa" <landa.martin@gmail.com> wrote:

[cc: grass-dev]
Hi,

2008/2/6, Otto Dassau <otto.dassau@gmx.de>:
> On Wed, 6 Feb 2008 16:53:31 +0100
> yes, applied, tested and thanks a lot :-)! but it is not in svn yet, or?

no, since I was not sure.

We should definitely use Trac for such kind of patches, it is hard to
find them in ML, Trac seems to be a perfect place where to "stock"
patches.

good idea

If no objections I can commint my/your patch to SVN.

I just used your patch and it works fine for me!

thanks a lot
  Otto

Martin

Otto Dassau:

> i.landsat.rgb -p fails for me with maps created with
i.fusion.brovey:
> line 138: [: 47.9603: integer expression expected
> [...]
>
> Attached you find the small changes that make it work at least for
> me again.

Martin Landa:

it seems to be same the issue as (patch already attached).
http://www.nabble.com/i.landsat.rgb-problem-td14917120.html#a14917120

Hi,

I have merged the patches and applied now in 6.3svn.
Please test, both i.landsat.rgb and yesterday's changes to
i.fusion.brovey.

It could be argued that i.fusion.brovey should output 0-255 CELL maps,
not 0.0-255.0 DCELL maps, but I don't think it's worth much to be
pedantic about that ... and maybe there is a tiny bit extra info in
those extra decimals, which is in line with i.fusion.brovey's purpose.
shrug.

Hamish

      ____________________________________________________________________________________
Be a better friend, newshound, and
know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ