[GRASS-dev] i.pca errors compiling GRASS 6.4 release branch

Here is the error message. Any thoughts or does this need a ticket?

Errors in:
/Users/cmbarton/Dropbox/GRASS_dropbox/source/grass64_rb/imagery/i.pca

In case of errors please change into the directory with error and run ‘make’.
If you get multiple errors, you need to deal with them in the order they
appear in the error log. If you get an error building a library, you will
also get errors from anything which uses the library.

Finished compilation: Wed May 14 11:26:52 MST 2014
make: *** [default] Error 1
anthgradpc7:grass64_rb cmbarton$ cd /Users/cmbarton/Dropbox/GRASS_dropbox/source/grass64_rb/imagery/i.pca
anthgradpc7:i.pca cmbarton$ make
gcc -I/Users/cmbarton/Dropbox/GRASS_dropbox/source/grass64_rb/dist.x86_64-apple-darwin13.1.0/include -I/usr/local/include -g -O2 -arch i386 -arch x86_64 -isysroot /Developer/SDKs/MacOSX10.7.sdk -I/usr/local/include -DPACKAGE="“grassmods”" -I/Users/cmbarton/Dropbox/GRASS_dropbox/source/grass64_rb/dist.x86_64-apple-darwin13.1.0/include -o OBJ.x86_64-apple-darwin13.1.0/support.o -c support.c
support.c:66:30: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
sprintf(hist.edhist[i + 1], tmpeigen);
^~~~~~~~
/Developer/SDKs/MacOSX10.7.sdk/usr/include/secure/_stdio.h:50:56: note: expanded from macro ‘sprintf’
__builtin___sprintf_chk (str, 0, __darwin_obsz(str), VA_ARGS)
^
support.c:79:5: error: void function ‘write_history’ should not return a value [-Wreturn-type]
return G_write_history(outname, &hist);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
make: *** [OBJ.x86_64-apple-darwin13.1.0/support.o] Error 1

Michael


C. Michael Barton
Director, Center for Social Dynamics & Complexity
Professor of Anthropology, School of Human Evolution & Social Change
Head, Graduate Faculty in Complex Adaptive Systems Science
Arizona State University
Tempe, AZ 85287-2402
USA

voice: 480-965-6262 (SHESC), 480-965-8130/727-9746 (CSDC)
fax: 480-965-7671(SHESC), 480-727-0709 (CSDC)
www: http://csdc.asu.edu, http://shesc.asu.edu
http://www.public.asu.edu/~cmbarton

On Wed, May 14, 2014 at 8:52 PM, Michael Barton <Michael.Barton@asu.edu> wrote:

Here is the error message. Any thoughts or does this need a ticket?

Errors in:
/Users/cmbarton/Dropbox/GRASS_dropbox/source/grass64_rb/imagery/i.pca

...

support.c:79:5: error: void function 'write_history' should not return a
value [-Wreturn-type]
    return G_write_history(outname, &hist);
    ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
make: *** [OBJ.x86_64-apple-darwin13.1.0/support.o] Error 1

The function is declared void

    22 static void write_history(int bands, char *outname, double
**eigmat, double *eigval)
    23 {
    24 int i, j;
...

but returns:
    58 return G_write_history(outname, &hist);
    59 }

Attached a proposal for fix by simply deleting the "return" (I
compared to grass70/imagery/i.pca/support.c).

Will that help?

Markus

(attachments)

i.pca.diff (400 Bytes)

That seems to have fixed it. I’ve compiled and posted GRASS 6.4.4 now. I won’t get to 6.5 before I leave, but was thinking about stopping support for that version anyway.

Michael
______________________________
C. Michael Barton
Director, Center for Social Dynamics & Complexity
Professor of Anthropology, School of Human Evolution & Social Change
Head, Graduate Faculty in Complex Adaptive Systems Science
Arizona State University
Tempe, AZ 85287-2402
USA

voice: 480-965-6262 (SHESC), 480-965-8130/727-9746 (CSDC)
fax: 480-965-7671(SHESC), 480-727-0709 (CSDC)
www: http://csdc.asu.edu, http://shesc.asu.edu
    http://www.public.asu.edu/~cmbarton

On May 15, 2014, at 10:09 AM, Markus Neteler <neteler@osgeo.org> wrote:

On Wed, May 14, 2014 at 8:52 PM, Michael Barton <Michael.Barton@asu.edu> wrote:

Here is the error message. Any thoughts or does this need a ticket?

Errors in:
/Users/cmbarton/Dropbox/GRASS_dropbox/source/grass64_rb/imagery/i.pca

...

support.c:79:5: error: void function 'write_history' should not return a
value [-Wreturn-type]
   return G_write_history(outname, &hist);
   ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
make: *** [OBJ.x86_64-apple-darwin13.1.0/support.o] Error 1

The function is declared void

   22 static void write_history(int bands, char *outname, double
**eigmat, double *eigval)
   23 {
   24 int i, j;
...

but returns:
   58 return G_write_history(outname, &hist);
   59 }

Attached a proposal for fix by simply deleting the "return" (I
compared to grass70/imagery/i.pca/support.c).

Will that help?

Markus
<i.pca.diff>

Michael,

On Thu, May 15, 2014 at 10:50 PM, Michael Barton <Michael.Barton@asu.edu> wrote:

That seems to have fixed it. I’ve compiled and posted GRASS 6.4.4 now.

... it's not released yet.. could you please rename the file from

GRASS 6.4.4
to
GRASS 6.4 development snapshot?

I try hard to get 6.4.4RC1 tagged...

Markus