[GRASS-dev] Layer Manager notebook

annakrat · January 26, 2016, 2:02am

Hi,

I plan to change the style of the Layer Manager tabs in the bottom of the window from wx.FlatNotebook to wx.Notebook. The results look like this:

https://drive.google.com/file/d/0B1j-R6U3_Ct9RFd1V3JSbDRjdGc/view?usp=sharing

Reasons include:

FlatNotebook behaves strangely on Ubuntu 15+ with wxpython3 wxGTK, switching tabs doesn’t work well
FlatNotebook rendering glitch on MacOSX with wxpython 3 (visible in the screenshot)
FlatNotebook causes crashing when switching from 3D to 2D on MacOSX with wxpython 3 http://trac.wxwidgets.org/ticket/16357
FlatNotebook probably causes loosing focus when switching to command console
FlatNotebook probably causes some GDK critical warnings on Ubuntu

Overall, by using native widget (wx.Notebook) we avoid many glitches. However, the appearance will be different for different OS. I personally don’t have problem with that, but I would suggest applying this to Mac and Linux, not Windows, because on Windows it looks ugly and since we still use wxpython 2.8, the described glitches don’t apply there. Opinions?

Related to this, any opinion on making the labels of the tabs shorter?

Map layers → Layers
Command console → Console
Search modules → Search
Data catalogue → Catalogue
Python shell → Python

Best,
Anna

ecodiv · January 26, 2016, 6:04am

Looks good to me on MacOSX and Linux, while you are right about Window… it would look very outdated. +1

···

On 26-01-16 03:02, Anna Petrášová wrote:

Hi,

I plan to change the style of the Layer Manager tabs in the bottom of the window from wx.FlatNotebook to wx.Notebook. The results look like this:

https://drive.google.com/file/d/0B1j-R6U3_Ct9RFd1V3JSbDRjdGc/view?usp=sharing

Reasons include:

FlatNotebook behaves strangely on Ubuntu 15+ with wxpython3 wxGTK, switching tabs doesn’t work well

FlatNotebook rendering glitch on MacOSX with wxpython 3 (visible in the screenshot)

FlatNotebook causes crashing when switching from 3D to 2D on MacOSX with wxpython 3 http://trac.wxwidgets.org/ticket/16357

FlatNotebook probably causes loosing focus when switching to command console

FlatNotebook probably causes some GDK critical warnings on Ubuntu

Overall, by using native widget (wx.Notebook) we avoid many glitches. However, the appearance will be different for different OS. I personally don’t have problem with that, but I would suggest applying this to Mac and Linux, not Windows, because on Windows it looks ugly and since we still use wxpython 2.8, the described glitches don’t apply there. Opinions?

Related to this, any opinion on making the labels of the tabs shorter?

Map layers → Layers
Command console → Console
Search modules → Search
Data catalogue → Catalogue
Python shell → Python

Best,
Anna

_______________________________________________
grass-dev mailing list
[grass-dev@lists.osgeo.org](mailto:grass-dev@lists.osgeo.org)
[http://lists.osgeo.org/mailman/listinfo/grass-dev](http://lists.osgeo.org/mailman/listinfo/grass-dev)

mlennert · January 26, 2016, 7:56am

On 26/01/16 03:02, Anna Petrášová wrote:

Hi,

I plan to change the style of the Layer Manager tabs in the bottom of
the window from wx.FlatNotebook to wx.Notebook. The results look like this:

https://drive.google.com/file/d/0B1j-R6U3_Ct9RFd1V3JSbDRjdGc/view?usp=sharing

Reasons include:
* FlatNotebook behaves strangely on Ubuntu 15+ with wxpython3 wxGTK,
switching tabs doesn't work well
* FlatNotebook rendering glitch on MacOSX with wxpython 3 (visible in
the screenshot)
* FlatNotebook causes crashing when switching from 3D to 2D on MacOSX
with wxpython 3 http://trac.wxwidgets.org/ticket/16357
* FlatNotebook probably causes loosing focus when switching to command
console
* FlatNotebook probably causes some GDK critical warnings on Ubuntu

Overall, by using native widget (wx.Notebook) we avoid many glitches.

+1

However, the appearance will be different for different OS. I personally
don't have problem with that, but I would suggest applying this to Mac
and Linux, not Windows, because on Windows it looks ugly and since we
still use wxpython 2.8, the described glitches don't apply there. Opinions?

I think that ideally, whenever possible, we should avoid having different treatments for different OS's. But if you all think that the windows version looks too ugly (I'm quite insensitive to such issues, so not a good judge), then +1 as long as windows is still wxpython 2.8.

Related to this, any opinion on making the labels of the tabs shorter?

For me they can be as short as you want, as I know what they are about, but we have to try to think like a GRASS newbie, here. So, my reflections in detail:

Map layers -> Layers

+1

Command console -> Console
Search modules -> Search

For these two I'm not sure if the short version is clear enough on what these are about: will most users understand what a 'Console' is ? At what is it you can search there ?

Data catalogue -> Catalogue

+1

Python shell -> Python

Again, not sure if just 'Python' is enough to make it clear.

IIUC, the reason for shortening is essentially OSX, or ? Wouldn't it be possible to just slightly reduce font size ?

Moritz

Vincent_Bain · January 26, 2016, 8:02am

Hi,

perhaps the tab widget does not support it, but could the label "long
name" be provided by a mouse-over tip ?

Vincent.

Le mardi 26 janvier 2016 à 08:56 +0100, Moritz Lennert a écrit :

On 26/01/16 03:02, Anna Petrášová wrote:
> Hi,
>
> I plan to change the style of the Layer Manager tabs in the bottom of
> the window from wx.FlatNotebook to wx.Notebook. The results look like this:
>
> https://drive.google.com/file/d/0B1j-R6U3_Ct9RFd1V3JSbDRjdGc/view?usp=sharing
>
> Reasons include:
> * FlatNotebook behaves strangely on Ubuntu 15+ with wxpython3 wxGTK,
> switching tabs doesn't work well
> * FlatNotebook rendering glitch on MacOSX with wxpython 3 (visible in
> the screenshot)
> * FlatNotebook causes crashing when switching from 3D to 2D on MacOSX
> with wxpython 3 http://trac.wxwidgets.org/ticket/16357
> * FlatNotebook probably causes loosing focus when switching to command
> console
> * FlatNotebook probably causes some GDK critical warnings on Ubuntu
>
> Overall, by using native widget (wx.Notebook) we avoid many glitches.

+1

> However, the appearance will be different for different OS. I personally
> don't have problem with that, but I would suggest applying this to Mac
> and Linux, not Windows, because on Windows it looks ugly and since we
> still use wxpython 2.8, the described glitches don't apply there. Opinions?

I think that ideally, whenever possible, we should avoid having
different treatments for different OS's. But if you all think that the
windows version looks too ugly (I'm quite insensitive to such issues, so
not a good judge), then +1 as long as windows is still wxpython 2.8.

>
>
> Related to this, any opinion on making the labels of the tabs shorter?

For me they can be as short as you want, as I know what they are about,
but we have to try to think like a GRASS newbie, here. So, my
reflections in detail:

>
> Map layers -> Layers

+1

> Command console -> Console
> Search modules -> Search

For these two I'm not sure if the short version is clear enough on what
these are about: will most users understand what a 'Console' is ? At
what is it you can search there ?

> Data catalogue -> Catalogue

+1

> Python shell -> Python

Again, not sure if just 'Python' is enough to make it clear.

IIUC, the reason for shortening is essentially OSX, or ? Wouldn't it be
possible to just slightly reduce font size ?

Moritz
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

annakrat · January 27, 2016, 3:20am

On Tue, Jan 26, 2016 at 2:56 AM, Moritz Lennert <
mlennert@club.worldonline.be> wrote:

On 26/01/16 03:02, Anna Petrášová wrote:

Hi,

I plan to change the style of the Layer Manager tabs in the bottom of
the window from wx.FlatNotebook to wx.Notebook. The results look like
this:

https://drive.google.com/file/d/0B1j-R6U3_Ct9RFd1V3JSbDRjdGc/view?usp=sharing

Reasons include:
* FlatNotebook behaves strangely on Ubuntu 15+ with wxpython3 wxGTK,
switching tabs doesn't work well
* FlatNotebook rendering glitch on MacOSX with wxpython 3 (visible in
the screenshot)
* FlatNotebook causes crashing when switching from 3D to 2D on MacOSX
with wxpython 3 http://trac.wxwidgets.org/ticket/16357
* FlatNotebook probably causes loosing focus when switching to command
console
* FlatNotebook probably causes some GDK critical warnings on Ubuntu

Overall, by using native widget (wx.Notebook) we avoid many glitches.

+1

However, the appearance will be different for different OS. I personally

don't have problem with that, but I would suggest applying this to Mac
and Linux, not Windows, because on Windows it looks ugly and since we
still use wxpython 2.8, the described glitches don't apply there.
Opinions?

I think that ideally, whenever possible, we should avoid having different
treatments for different OS's. But if you all think that the windows
version looks too ugly (I'm quite insensitive to such issues, so not a good
judge), then +1 as long as windows is still wxpython 2.8.

Done in r67679.

Related to this, any opinion on making the labels of the tabs shorter?

For me they can be as short as you want, as I know what they are about,
but we have to try to think like a GRASS newbie, here. So, my reflections
in detail:

Map layers -> Layers

+1

Command console -> Console

Search modules -> Search

For these two I'm not sure if the short version is clear enough on what
these are about: will most users understand what a 'Console' is ? At what
is it you can search there ?

I would think console is pretty clear, but that's just my feeling. I agree
Search is ambiguous, although it might not be a huge problem for users.

Data catalogue -> Catalogue

this was supposed to be catalog

+1

Python shell -> Python

Again, not sure if just 'Python' is enough to make it clear.

IIUC, the reason for shortening is essentially OSX, or ? Wouldn't it be
possible to just slightly reduce font size ?

Not just Mac, in my case last tab is hidden but I can see a small arrow
showing that there is another tab. We don't have to decide this now, I was
thinking about this for some time and I was wondering if others agree we
need this.

Thanks,
Anna

Moritz

annakrat · January 27, 2016, 3:22am

On Tue, Jan 26, 2016 at 3:02 AM, Vincent Bain <bain@toraval.fr> wrote:

Hi,

perhaps the tab widget does not support it, but could the label "long
name" be provided by a mouse-over tip ?

No, that's not supported. I doubt people would use the tooltip anyway, you
can just switch the tab and see.

Anna

Vincent.

Le mardi 26 janvier 2016 à 08:56 +0100, Moritz Lennert a écrit :
> On 26/01/16 03:02, Anna Petrášová wrote:
> > Hi,
> >
> > I plan to change the style of the Layer Manager tabs in the bottom of
> > the window from wx.FlatNotebook to wx.Notebook. The results look like
this:
> >
> >
https://drive.google.com/file/d/0B1j-R6U3_Ct9RFd1V3JSbDRjdGc/view?usp=sharing
> >
> > Reasons include:
> > * FlatNotebook behaves strangely on Ubuntu 15+ with wxpython3 wxGTK,
> > switching tabs doesn't work well
> > * FlatNotebook rendering glitch on MacOSX with wxpython 3 (visible in
> > the screenshot)
> > * FlatNotebook causes crashing when switching from 3D to 2D on MacOSX
> > with wxpython 3 http://trac.wxwidgets.org/ticket/16357
> > * FlatNotebook probably causes loosing focus when switching to command
> > console
> > * FlatNotebook probably causes some GDK critical warnings on Ubuntu
> >
> > Overall, by using native widget (wx.Notebook) we avoid many glitches.
>
> +1
>
> > However, the appearance will be different for different OS. I
personally
> > don't have problem with that, but I would suggest applying this to Mac
> > and Linux, not Windows, because on Windows it looks ugly and since we
> > still use wxpython 2.8, the described glitches don't apply there.
Opinions?
>
> I think that ideally, whenever possible, we should avoid having
> different treatments for different OS's. But if you all think that the
> windows version looks too ugly (I'm quite insensitive to such issues, so
> not a good judge), then +1 as long as windows is still wxpython 2.8.
>
> >
> >
> > Related to this, any opinion on making the labels of the tabs shorter?
>
> For me they can be as short as you want, as I know what they are about,
> but we have to try to think like a GRASS newbie, here. So, my
> reflections in detail:
>
> >
> > Map layers -> Layers
>
> +1
>
> > Command console -> Console
> > Search modules -> Search
>
> For these two I'm not sure if the short version is clear enough on what
> these are about: will most users understand what a 'Console' is ? At
> what is it you can search there ?
>
> > Data catalogue -> Catalogue
>
> +1
>
> > Python shell -> Python
>
> Again, not sure if just 'Python' is enough to make it clear.
>
> IIUC, the reason for shortening is essentially OSX, or ? Wouldn't it be
> possible to just slightly reduce font size ?
>
> Moritz
> _______________________________________________
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/grass-dev

wenzeslaus · January 29, 2016, 4:07am

On Mon, Jan 25, 2016 at 9:02 PM, Anna Petrášová <kratochanna@gmail.com>
wrote:

Related to this, any opinion on making the labels of the tabs shorter?

Map layers -> Layers
Command console -> Console
Search modules -> Search
Data catalogue -> Catalogue
Python shell -> Python

I think they should be shorter. It will completely solve all the issues
with hidden tabs. I'm attaching some suggestions as screenshot but I think
I like

Layers, Console, Search, Catalog, Python

but also

Layers, Console, Modules, Data, Python

which is more explicit about what Catalog/Data is and what you are
searching for - mostly modules.

Vaclav

(attachments)

wenzeslaus · February 15, 2016, 4:50pm

I think

Layers, Console, Modules, Data, Python

are the best.

Layers - layers in the map (as opposed to data)

Console - this is how many programs call the place where you put commands and get text output

Modules - browse and search modules

Data - show, rename, delete data, perhaps also reproject and import in the future; close to “GRASS database” which is what we are actually showing there; even now goes beyond catalog which usually just describes organized list but not something you can change

Python - the only message we need to convey is that it is Python, you need go there anyway to see how it works

In documentation all can be referred to as tab [1]:

See raster map layer in the Layer tab in Layer Manager. Type the command into the Console tab. See the result in the Console tab. Find the related modules in the Module tab. Manage data in Data tab. Rename raster map in the Data tab. Execute simple Python code in the Python tab.

Another issue with these tabs is that people often miss them. I met several people who were using Layers (Map layers) and Console (Command console) and never tried Modules (Search modules) and Python (Python shell), although they actually wanted to see something like the module/toolbox tree or wanted to execute short Python code. I’m not sure if shorter names will help but I can hope.

I would like to commit this to trunk soon.

Vaclav

[1] https://en.wikipedia.org/wiki/Tab_%28GUI%29

···

On Thu, Jan 28, 2016 at 11:07 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

On Mon, Jan 25, 2016 at 9:02 PM, Anna Petrášová <kratochanna@gmail.com> wrote:

Related to this, any opinion on making the labels of the tabs shorter?

Map layers → Layers
Command console → Console
Search modules → Search
Data catalogue → Catalogue
Python shell → Python

I think they should be shorter. It will completely solve all the issues with hidden tabs. I’m attaching some suggestions as screenshot but I think I like

Layers, Console, Search, Catalog, Python

but also

Layers, Console, Modules, Data, Python

which is more explicit about what Catalog/Data is and what you are searching for - mostly modules.

Vaclav

martinl · February 15, 2016, 4:56pm

Hi,

2016-02-15 17:50 GMT+01:00 Vaclav Petras <wenzeslaus@gmail.com>:

Layers, Console, Modules, Data, Python

are the best.

agreed. +1 for this change. Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

Pietro2 · February 16, 2016, 4:12am

Il 15 feb 2016 5:56 PM, “Martin Landa” <landa.martin@gmail.com> ha scritto:

Hi,

2016-02-15 17:50 GMT+01:00 Vaclav Petras <wenzeslaus@gmail.com>:

Layers, Console, Modules, Data, Python

are the best.

agreed. +1 for this change. Martin

I like it too, so +1

Pietro

veroandreo · February 16, 2016, 3:01pm

Hi

2016-02-15 17:50 GMT+01:00 Vaclav Petras <wenzeslaus@gmail.com>:
> Layers, Console, Modules, Data, Python
>
> are the best.

agreed. +1 for this change. Martin

I like it too, so +1

Can I also say +1 even if not a dev?

Vero

neteler · February 16, 2016, 3:23pm

On Tue, Feb 16, 2016 at 4:01 PM, Veronica Andreo <veroandreo@gmail.com> wrote:

Hi

2016-02-15 17:50 GMT+01:00 Vaclav Petras <wenzeslaus@gmail.com>:
> Layers, Console, Modules, Data, Python
>
> are the best.

agreed. +1 for this change. Martin

I like it too, so +1

+1

Can I also say +1 even if not a dev?

of course

Markus

wenzeslaus · February 17, 2016, 3:35am

On Mon, Feb 15, 2016 at 11:50 AM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

Layers, Console, Modules, Data, Python

In documentation all can be referred to as tab.

I would like to commit this to trunk soon.

Done in r67852. I updated the other strings and doc which mentioned them.

I did not update the screenshots in the main wxGUI page. I want to wait on how we solve #2799, so both screenshots can be done at once.

Vaclav

https://trac.osgeo.org/grass/changeset/67852
https://trac.osgeo.org/grass/ticket/2799