[GRASS-dev] method does not change the output v.surf.bspline

GRASS GRASS developer
1

Dear all,

Running v.surf.bspline using the bicubic or bilinear method yields the same results (running grass 7.8.4 dev on Linux).

To reproduce using the nc_spm_08_grass7 data set:


g.region -a vector=precip_30ynormals res=1000

v.surf.bspline input=precip_30ynormals column=jan raster_output=bspline01 ew_step=40000 ns_step=40000 method=bicubic

v.surf.bspline input=precip_30ynormals column=jan raster_output=bspline02 ew_step=40000 ns_step=40000 method=bilinear

Am I missing something?

With kind regards,

Paulo

2

On Mon, Jun 22, 2020 at 12:49 PM Paulo van Breugel
<p.vanbreugel@gmail.com> wrote:

Dear all,

Running v.surf.bspline using the bicubic or bilinear method yields the same results (running grass 7.8.4 dev on Linux).

Please try
https://github.com/OSGeo/grass/pull/727

The method selector lacked an update after method renaming.

Best,
Markus

--
Markus Neteler, PhD
https://www.mundialis.de - free data with free software
https://grass.osgeo.org
https://courses.neteler.org/blog

3

Hi Markus,

Thanks. I’ll like to try out, but I am not sure how this works. Do I need to recompile grass gis? But how to incorporate the pull request? Sorry, not very familiar with the procedure?

Best regards,

Paulo

On Mon, Jun 22, 2020 at 3:35 PM Markus Neteler <neteler@osgeo.org> wrote:

On Mon, Jun 22, 2020 at 12:49 PM Paulo van Breugel
<p.vanbreugel@gmail.com> wrote:

Dear all,

Running v.surf.bspline using the bicubic or bilinear method yields the same results (running grass 7.8.4 dev on Linux).

Please try
https://github.com/OSGeo/grass/pull/727

The method selector lacked an update after method renaming.

Best,
Markus

–
Markus Neteler, PhD
https://www.mundialis.de - free data with free software
https://grass.osgeo.org
https://courses.neteler.org/blog

4

Hi Paulo,

On Mon, Jun 22, 2020 at 4:19 PM Paulo van Breugel
<p.vanbreugel@gmail.com> wrote:

Hi Markus,

Thanks. I'll like to try out, but I am not sure how this works. Do I need to recompile grass gis? But how to incorporate the pull request? Sorry, not very familiar with the procedure?

That's pretty easy:

# go to wherever your local source code copy is:
cd grass78_git_src/

# fetch diff of pull request:
wget https://github.com/OSGeo/grass/pull/727.diff

# apply diff
git apply 727.diff

# check for the change
git status
# ... this should show: `modified: vector/v.surf.bspline/main.c`

# compile it
cd vector/v.surf.bspline/
make

# ONLY in case you always do `make install`
# (e.g. I don't since I use it directly from `bin.x86_64-pc-linux-gnu/grass78`)
cd ../../
sudo make install

# to revert the local change (needed after merge of PR, to be able to
locally update):
git apply 727.diff --reverse

HTH,
Markus

PS: see also
https://trac.osgeo.org/grass/wiki/HowToGit#Applyingadifffilelocally