[GRASS-dev] mysys startup for win grass fails

Hamish:

> note that the nightly build needs some adjustment,
> grass70.bat files are making it into the 6.4 build

Helmut wrote:

in
http://trac.osgeo.org/grass/browser/grass/branches/releasebranch_6_4/mswindows/GRASS-Installer.nsi

I can't see anything about grass7 there.

no; I expect it could be due to an unclean build enviroment on the
nightly build server.
the 3 files are in C:\Program Files\GRASS-64-SVN\msys\

I've tested it by building a WinGrass-Installer, there are no Grass7-files

also I notice the C:/Program Files/GRASS GIS/GRASS-6-SVN/msys/grass/ dir is empty.

see https://trac.osgeo.org/grass/ticket/629#comment:7

"The empty grass dir is a mount point for
the install directory and allows the grass with msys shortcuts
to be executed with msys.bat /grass/bin/grass64 -wxpython etc."

> and the msys.bat hacks are not applied?
> (we should just put our version in svn and overcopy it
> as part of the >packaging script)

there are 2 options for this issue:

(1) holding a copy for example in releasebranch_6_4/mswindows/osgeo4w
    and replacing the osgeo4w-msys.bat version by GRASS-Packager.bat and/or NSIS-script
  
(2) write out msys.bat by the NSIS-installer itself

   ;Create the msys.bat
          ClearErrors
           FileOpen $0 $INSTALL_DIR\msys\msys.bat w
          FileWrite $0 ...

which msys.bat-hacks?
maybe this mentionend in
http://trac.osgeo.org/grass/wiki/CompileOnWindows#RemoveOSGeo4WTracesfromPackage

these changes are clear.

yes, and in the patches here:
  https://trac.osgeo.org/grass/ticket/629
(so whatever Colin builds with)
Hamish

following the thread in ticket #629 isn't easy.

some comments:

- GRASS-Installer.patch is in svn, see
http://trac.osgeo.org/grass/browser/grass/branches/releasebranch_6_4/mswindows/GRASS-Installer.nsi#L673

- msys.bat-version added by Colin to the report

I've built a Wingrass-Installer including this msys.bat-version, but commented out
https://trac.osgeo.org/grass/attachment/ticket/629/msys.bat#L49

  rem if installed in a directory containing spaces prepare for a world of pain
    rem for /F %%i IN ('echo %WD%') DO @set PART1=%%i
    rem if NOT "%PART1%" == "%WD%" (
   rem echo Path names containing spaces are not supported -- aborting.
   rem pause
   rem exit 1
    rem )
  
because WinGrass is installed in path with spaces c:\Program Files\.

I can provide this WinGrass-Installer-version including Colin's msys.bat-version if needed?.

I've tested this WinGrass-Installer-version a little bit in WinGrass+Msys-mode:

msys-commandline is starting and working.

some examples in the msys-command-line:

- v.db.addcol, v.db.dropcol, v.db.select are working

- v.colors isn't working because the color rule "elevation" can't be find (but is
  working in the self-compiled grass64 within the osgeo4w-stack)
  {{{
  GRASS 6.4> v.colors map=mygeology column=GEOL250_ID rgb_column=gc1 color=elevation
  ls: c:/Program: No such file or directory
  ls: Files/GRASS-64-SVN/etc/colors/: No such file or directory
  FEHLER: Invalid color rule <elevation>
       Valid options are: random grey.eq grey.log rules
  }}}
  
best regards
Helmut
______________________________________________________
GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://movieflat.web.de

Hamish:

> grass70.bat files are making it into the 6.4 build
> no; I expect it could be due to an unclean build
> enviroment on the nightly build server.
> the 3 files are in C:\Program Files\GRASS-64-SVN\msys\

Helmut:

I've tested it by building a WinGrass-Installer, there are
no Grass7-files

...

> and the msys.bat hacks are not applied?
> (we should just put our version in svn and overcopy it
> as part of the packaging script)

...

> yes, and in the patches here:
> https://trac.osgeo.org/grass/ticket/629
> (so whatever Colin builds with)

following the thread in ticket #629 isn't easy.

see "patch: fix quoting and handle spaces in path gracefully"
SorceForge bug ID: 2808978
https://sourceforge.net/tracker/index.php?func=detail&aid=2808978&group_id=2435&atid=102435

- msys.bat-version added by Colin to the report

I've built a Wingrass-Installer including this
msys.bat-version, but commented out
https://trac.osgeo.org/grass/attachment/ticket/629/msys.bat#L49

rem if installed in a directory

containing spaces prepare for a world of pain
rem for /F %%i IN ('echo %WD%') DO @set PART1=%%i
rem if NOT "%PART1%" == "%WD%" (
rem echo Path names containing spaces are not supported -- aborting.
rem pause
rem exit 1
rem )

because WinGrass is installed in path with spaces
c:\Program Files\.

Right, I added that into the main patch to make some of the MSys
devs less worried about applying it upstream. For us it should
be removed.

I can provide this WinGrass-Installer-version including
Colin's msys.bat-version if needed?.

I think all future WinGrass builds (both yours/Colin's and the
nightly builds need to use it if they are going to work with
C:\Program Files\.

I've tested this WinGrass-Installer-version a little bit in
WinGrass+Msys-mode:

...

- v.colors isn't working because the color rule "elevation"
can't be find

I think I've fixed this in 6.5svn with r40747. I'll backport
to 6.4 soon.

thanks,
Hamish