As there don't appear to be any show-stopping bugs in the new v.digit,
I've committed it to CVS.
Anyone with a pressing need for the XDRIVER-based version can get it
by updating the vector/v.digit directory with the tag
pre_vdigit_changes_2007023, e.g.
cd vector/v.digit
cvs update -r pre_vdigit_changes_2007023
--
Glynn Clements <glynn@gclements.plus.com>
On Fri, Feb 23, 2007 at 11:32:36PM +0000, Glynn Clements wrote:
As there don't appear to be any show-stopping bugs in the new v.digit,
I've committed it to CVS.
Glynn,
you made an IMPRESSIVE work! Congratulations.
Markus
PS: the preset colors in the "Settings" tab are all black
currently (symbology) - maybe an initialization problem?
PPS: A wish: having "close" buttons in all "Settings" tabs would
be great
On Sat, Feb 24, 2007 at 07:14:16AM +0100, Markus Neteler wrote:
On Fri, Feb 23, 2007 at 11:32:36PM +0000, Glynn Clements wrote:
>
> As there don't appear to be any show-stopping bugs in the new v.digit,
> I've committed it to CVS.
>Glynn,
you made an IMPRESSIVE work! Congratulations.
Markus
PS: the preset colors in the "Settings" tab are all black
currently (symbology) - maybe an initialization problem?PPS: A wish: having "close" buttons in all "Settings" tabs would
be great
A question:
What's the idea of the "-n" flag? I could not find out the last
years 
Can we disable it (in the common "deprecated" way)?
Markus
Markus Neteler wrote:
PS: the preset colors in the "Settings" tab are all black
currently (symbology) - maybe an initialization problem?
Yep; fixed in CVS.
[symb_init_gui() has to come after symb_init(). I had to change the
initialisation because it was originally drawing the map before Tcl/Tk
was initialised; that won't work if you're trying to draw the map on a
Tk canvas.]
PPS: A wish: having "close" buttons in all "Settings" tabs would
be great
Close buttons in *tabs*? For what purpose?
--
Glynn Clements <glynn@gclements.plus.com>
Markus Neteler wrote:
What's the idea of the "-n" flag?
To create a new map. Are you asking why it doesn't just do this
automatically if the map already exists? Possibly so that you don't
accidentally create a new map if you make a mistake entering the name
of an existing map.
I could not find out the last
years
Ignoring it would be trivial; just remove the "if ( new_f->answer ) {"
from around the code which creates a new map.
--
Glynn Clements <glynn@gclements.plus.com>
Glynn Clements wrote:
Markus Neteler wrote:
PS: the preset colors in the "Settings" tab are all black
currently (symbology) - maybe an initialization problem?Yep; fixed in CVS.
Hmm, using CVS checked out just a moment ago I still have this issue.
Maciek
[symb_init_gui() has to come after symb_init(). I had to change the
initialisation because it was originally drawing the map before Tcl/Tk
was initialised; that won't work if you're trying to draw the map on a
Tk canvas.]PPS: A wish: having "close" buttons in all "Settings" tabs would
be great
Just press the window close button (sorry if I didn't understand)?
Maciek
On Sat, Feb 24, 2007 at 06:58:57AM +0000, Glynn Clements wrote:
Markus Neteler wrote:
> PPS: A wish: having "close" buttons in all "Settings" tabs would
> be greatClose buttons in *tabs*? For what purpose?
Right, I meant a close button for the entire window
or something reasonable.
Take for example the "Background" tab:
- click "Add command"
- write "Winnie The Pooh"
- then? Kill the entire settings window - not really obvious
("Winnie The Pooh" is then silently ignored/disappears)
I would expect some "confirm" thing or so or a "Done"
button below all tabs.
Markus
On Sat, Feb 24, 2007 at 07:03:22AM +0000, Glynn Clements wrote:
Markus Neteler wrote:
> What's the idea of the "-n" flag?
To create a new map. Are you asking why it doesn't just do this
automatically if the map already exists?
Yes.
Possibly so that you don't
accidentally create a new map if you make a mistake entering the name
of an existing map.
Well, no other GRASS command behaves like this.
But of course it's no real problem.
> I could not find out the last
> yearsIgnoring it would be trivial; just remove the "if ( new_f->answer ) {"
from around the code which creates a new map.
Interestingly (from a user's perspective), you can always use "-n",
also with existing maps.
Markus
Maciej Sieczka wrote:
>> PS: the preset colors in the "Settings" tab are all black
>> currently (symbology) - maybe an initialization problem?
>
> Yep; fixed in CVS.Hmm, using CVS checked out just a moment ago I still have this issue.
Oops; that should have been "fixed in working copy and forgot to
commit to CVS". It should be there now.
--
Glynn Clements <glynn@gclements.plus.com>
Markus Neteler wrote:
> > PPS: A wish: having "close" buttons in all "Settings" tabs would
> > be great
>
> Close buttons in *tabs*? For what purpose?Right, I meant a close button for the entire window
or something reasonable.
Take for example the "Background" tab:
- click "Add command"
- write "Winnie The Pooh"
- then? Kill the entire settings window - not really obvious("Winnie The Pooh" is then silently ignored/disappears)
I would expect some "confirm" thing or so or a "Done"
button below all tabs.
Ah, an "Ok" button (apply changes and close window).
Add it to the RT as a wish; for now, I would rather stick to fixing
anything which broke as a result of switching from libraster to Tk.
--
Glynn Clements <glynn@gclements.plus.com>
AFAICT, we still need the -n for situations where v.digit is run with the
name of a map that does not yet exist. Using the -n flag will create a new
vector map with the specified name and let you start digitizing this map.
Michael
On 2/23/07 11:17 PM, "Markus Neteler" <neteler@itc.it> wrote:
On Sat, Feb 24, 2007 at 07:14:16AM +0100, Markus Neteler wrote:
On Fri, Feb 23, 2007 at 11:32:36PM +0000, Glynn Clements wrote:
As there don't appear to be any show-stopping bugs in the new v.digit,
I've committed it to CVS.Glynn,
you made an IMPRESSIVE work! Congratulations.
Markus
PS: the preset colors in the "Settings" tab are all black
currently (symbology) - maybe an initialization problem?PPS: A wish: having "close" buttons in all "Settings" tabs would
be greatA question:
What's the idea of the "-n" flag? I could not find out the last
yearsCan we disable it (in the common "deprecated" way)?
Markus
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University
phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton
Michael Barton wrote:
> A question:
> What's the idea of the "-n" flag? I could not find out the last
> yearsAFAICT, we still need the -n for situations where v.digit is run with the
name of a map that does not yet exist. Using the -n flag will create a new
vector map with the specified name and let you start digitizing this map.
The code in question is:
/* Open map */
mapset = G_find_vector2 (map_opt->answer, G_mapset());
if ( mapset == NULL ) {
if ( new_f->answer ) {
G_message(_("New empty map created."));
Vect_open_new (&Map, map_opt->answer, 0 );
Vect_build ( &Map, NULL );
Vect_close (&Map);
Vect_open_update (&Map, map_opt->answer, G_mapset());
} else {
G_message(_("Map does not exist. Add flag -n to create a new map."));
exit(EXIT_FAILURE);
}
} else {
Vect_set_open_level(2);
Vect_open_update (&Map, map_opt->answer, mapset);
}
The -n flag is only checked if the map doesn't already exist. In that
case, it could just skip the -n check and create the map
automatically.
The only issue is whether there is a reason not to.
--
Glynn Clements <glynn@gclements.plus.com>
Glynn,
To go along with your impressive update of v.digit, I was able to now
re-institute automatic background display of any active layers in the GIS
Manager. This was functional in the x11 based d.m, but hasn't been
functional in the new display architecture. Now that it's all in a TclTk
canvas, I was able to get this running again.
I'm currently using the -n switch. If you get rid of it, I can take it out
of the v.digit command (and shorten the code a bit) in vector.tcl.
Michael
On 2/24/07 2:59 PM, "Glynn Clements" <glynn@gclements.plus.com> wrote:
Michael Barton wrote:
A question:
What's the idea of the "-n" flag? I could not find out the last
yearsAFAICT, we still need the -n for situations where v.digit is run with the
name of a map that does not yet exist. Using the -n flag will create a new
vector map with the specified name and let you start digitizing this map.The code in question is:
/* Open map */
mapset = G_find_vector2 (map_opt->answer, G_mapset());
if ( mapset == NULL ) {
if ( new_f->answer ) {
G_message(_("New empty map created."));
Vect_open_new (&Map, map_opt->answer, 0 );
Vect_build ( &Map, NULL );
Vect_close (&Map);
Vect_open_update (&Map, map_opt->answer, G_mapset());
} else {
G_message(_("Map does not exist. Add flag -n to create a new map."));
exit(EXIT_FAILURE);
}
} else {
Vect_set_open_level(2);
Vect_open_update (&Map, map_opt->answer, mapset);
}The -n flag is only checked if the map doesn't already exist. In that
case, it could just skip the -n check and create the map
automatically.The only issue is whether there is a reason not to.
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University
phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton
Glynn,
Do you mind if I change the display and digitizing controls window titles to
"Digitizing $map_name@$map_mapset" (from "v.digit - $map_name@$map_mapset".
This is a bit more descriptive, especially when run from the GIS Manager
rather than from the command line.
"Digitizing controls for $map_name@$map_mapset" might be even better for the
toolbox window, but I'm afraid that title would be too long for some maps.
Michael
On 2/24/07 2:59 PM, "Glynn Clements" <glynn@gclements.plus.com> wrote:
Michael Barton wrote:
A question:
What's the idea of the "-n" flag? I could not find out the last
yearsAFAICT, we still need the -n for situations where v.digit is run with the
name of a map that does not yet exist. Using the -n flag will create a new
vector map with the specified name and let you start digitizing this map.The code in question is:
/* Open map */
mapset = G_find_vector2 (map_opt->answer, G_mapset());
if ( mapset == NULL ) {
if ( new_f->answer ) {
G_message(_("New empty map created."));
Vect_open_new (&Map, map_opt->answer, 0 );
Vect_build ( &Map, NULL );
Vect_close (&Map);
Vect_open_update (&Map, map_opt->answer, G_mapset());
} else {
G_message(_("Map does not exist. Add flag -n to create a new map."));
exit(EXIT_FAILURE);
}
} else {
Vect_set_open_level(2);
Vect_open_update (&Map, map_opt->answer, mapset);
}The -n flag is only checked if the map doesn't already exist. In that
case, it could just skip the -n check and create the map
automatically.The only issue is whether there is a reason not to.
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University
phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton
I added the OK button. It's in the cvs now.
Michael
On 2/24/07 12:19 PM, "Glynn Clements" <glynn@gclements.plus.com> wrote:
Markus Neteler wrote:
PPS: A wish: having "close" buttons in all "Settings" tabs would
be greatClose buttons in *tabs*? For what purpose?
Right, I meant a close button for the entire window
or something reasonable.
Take for example the "Background" tab:
- click "Add command"
- write "Winnie The Pooh"
- then? Kill the entire settings window - not really obvious("Winnie The Pooh" is then silently ignored/disappears)
I would expect some "confirm" thing or so or a "Done"
button below all tabs.Ah, an "Ok" button (apply changes and close window).
Add it to the RT as a wish; for now, I would rather stick to fixing
anything which broke as a result of switching from libraster to Tk.
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University
phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton
Hello Michael
On Sat, 24 Feb 2007, Michael Barton wrote:
Glynn,
Do you mind if I change the display and digitizing controls window titles to
"Digitizing $map_name@$map_mapset" (from "v.digit - $map_name@$map_mapset".This is a bit more descriptive, especially when run from the GIS Manager
rather than from the command line.
I can't see any good reason for "hiding" from the user the fact that they're using v.digit - can only imagine it making it harder for them to find hints and information and make bug reports more obscure?
I'm currently using the -n switch. If you get rid of it, I can take it out
of the v.digit command (and shorten the code a bit) in vector.tcl.
Well what I took from previous discussions was its OK to use the -n flag even if the map already exists, because it is only checked if the map doesn't already exist! So it would be fine to just use it all the time, but probably a more preferable solution is just to get rid of it as it seems to be anomaly with no real use.
Paul
Paul Kelly wrote:
Hello Michael
On Sat, 24 Feb 2007, Michael Barton wrote:
Glynn,
Do you mind if I change the display and digitizing controls window
titles to
"Digitizing $map_name@$map_mapset" (from "v.digit -
$map_name@$map_mapset".This is a bit more descriptive, especially when run from the GIS Manager
rather than from the command line.I can't see any good reason for "hiding" from the user the fact that
they're using v.digit - can only imagine it making it harder for them to
find hints and information and make bug reports more obscure?
Good point. I second that.
I'm currently using the -n switch. If you get rid of it, I can take it
out
of the v.digit command (and shorten the code a bit) in vector.tcl..Well what I took from previous discussions was its OK to use the -n flag
even if the map already exists, because it is only checked if the map
doesn't already exist! So it would be fine to just use it all the time,
but probably a more preferable solution is just to get rid of it as it
seems to be anomaly with no real use.
I don't have a strong opinion about it. However, eventual removal of
the -n flag should be postponed to GRASS 7 I think.
Maciek
Glynn Clements wrote:
Maciej Sieczka wrote:
PS: the preset colors in the "Settings" tab are all black
currently (symbology) - maybe an initialization problem?Yep; fixed in CVS.
Hmm, using CVS checked out just a moment ago I still have this issue.
Oops; that should have been "fixed in working copy and forgot to
commit to CVS". It should be there now.
It is! Thanks.
Maciek
On Sat, February 24, 2007 00:32, Glynn Clements wrote:
As there don't appear to be any show-stopping bugs in the new v.digit,
I've committed it to CVS.
I just compiled and tested this in Windows: I can now digitize in windows
and display the resulting map. The only problem remains the db access
which still doesn't work, but this is more general than v.digit
Moritz
On Sun, 25 Feb 2007, Michael Barton wrote:
I added the OK button. It's in the cvs now.
Hello Michael
I just tested this and as far as I can see it doesn't work correctly. You stil have to press enter in the box after changing the line width for it to be picked up. And the default line width still isn't placed in the box to start with. Also if there is an OK button there should be a cancel too I think.
Paul
Michael
On 2/24/07 12:19 PM, "Glynn Clements" <glynn@gclements.plus.com> wrote:
Markus Neteler wrote:
PPS: A wish: having "close" buttons in all "Settings" tabs would
be greatClose buttons in *tabs*? For what purpose?
Right, I meant a close button for the entire window
or something reasonable.
Take for example the "Background" tab:
- click "Add command"
- write "Winnie The Pooh"
- then? Kill the entire settings window - not really obvious("Winnie The Pooh" is then silently ignored/disappears)
I would expect some "confirm" thing or so or a "Done"
button below all tabs.Ah, an "Ok" button (apply changes and close window).
Add it to the RT as a wish; for now, I would rather stick to fixing
anything which broke as a result of switching from libraster to Tk.__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State Universityphone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton_______________________________________________
grass-dev mailing list
grass-dev@grass.itc.it
http://grass.itc.it/mailman/listinfo/grass-dev