At the beginning of this year, compiling GRASS raised a very high number of compiler warnings. For example with GCC there were about 140 and with Clang about 300 warnings. This was reported with GitHub issue #1247 [1]. Since then these warnings has been addressed in a number of PRs. Today we have reached the point where there are no warnings at all (!) for either GCC and Clang (with default settings) on the main branch.
To keep this level of warning frequency to zero, the compiler flag -Werror has been added to the GitHub "GCC C/C++ standards check" CI builds. This will treat a compiler warning as an error, and will cause the build to fail.
For those who have a PR in the pipeline affecting C or C++ code, should consider making a rebase to main (or otherwise trigger a CI check) before merging.
At the beginning of this year, compiling GRASS raised a very high number of compiler warnings. For example with GCC there were about 140 and with Clang about 300 warnings. This was reported with GitHub issue #1247 [1]. Since then these warnings has been addressed in a number of PRs. Today we have reached the point where there are no warnings at all (!) for either GCC and Clang (with default settings) on the main branch.
To keep this level of warning frequency to zero, the compiler flag -Werror has been added to the GitHub “GCC C/C++ standards check” CI builds. This will treat a compiler warning as an error, and will cause the build to fail.
For those who have a PR in the pipeline affecting C or C++ code, should consider making a rebase to main (or otherwise trigger a CI check) before merging.
I’m not suggesting to do it right now, but for the future, what do you think about adding more warnings/errors? There is, for example, -Wunused-result or -Wunused-but-set-variable which we have in the code.
warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
warning: variable ‘mapone’ set but not used [-Wunused-but-set-variable]
At the beginning of this year, compiling GRASS raised a very high number of compiler warnings. For example with GCC there were about 140 and with Clang about 300 warnings. This was reported with GitHub issue #1247 [1]. Since then these warnings has been addressed in a number of PRs. Today we have reached the point where there are no warnings at all (!) for either GCC and Clang (with default settings) on the main branch.
To keep this level of warning frequency to zero, the compiler flag -Werror has been added to the GitHub “GCC C/C++ standards check” CI builds. This will treat a compiler warning as an error, and will cause the build to fail.
For those who have a PR in the pipeline affecting C or C++ code, should consider making a rebase to main (or otherwise trigger a CI check) before merging.