[GRASS-dev] possible bashism in scripts/mkftcap

GRASS GRASS developer
1

Hi,

I retrieved this from the Debian bugtracker:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530092#20

Should we implement their suggestion?

Markus

2

Markus Neteler wrote:

I retrieved this from the Debian bugtracker:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530092#20

Should we implement their suggestion?

Yes.

--
Glynn Clements <glynn@gclements.plus.com>

3

On Mon, Aug 3, 2009 at 8:09 PM, Glynn Clements<glynn@gclements.plus.com> wrote:

Markus Neteler wrote:

I retrieved this from the Debian bugtracker:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530092#20

Should we implement their suggestion?

Yes.

This?

svn diff tools/mkftcap/mkftcap
Index: tools/mkftcap/mkftcap

--- tools/mkftcap/mkftcap (revision 38574)
+++ tools/mkftcap/mkftcap (working copy)
@@ -31,7 +31,7 @@
         fi
     done

- if which fc-list >&/dev/null ; then
+ if which fc-list >/dev/null 2>&1 ; then
         fc-list :outline file index \
             | sed -n \
                   -e 's!^\(.*\)/\(.*\)\.\([^.]*\):
:index=0$!\2:\1/\2.\3:utf-8:!p' \

?
BTW: In my dash also the original works...

Markus

4

On Mon, Aug 3, 2009 at 8:24 PM, Markus Neteler<neteler@osgeo.org> wrote:

On Mon, Aug 3, 2009 at 8:09 PM, Glynn Clements<glynn@gclements.plus.com> wrote:

Markus Neteler wrote:

I retrieved this from the Debian bugtracker:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530092#20

Should we implement their suggestion?

Yes.

This?

svn diff tools/mkftcap/mkftcap
Index: tools/mkftcap/mkftcap

--- tools/mkftcap/mkftcap (revision 38574)
+++ tools/mkftcap/mkftcap (working copy)
@@ -31,7 +31,7 @@
fi
done

- if which fc-list >&/dev/null ; then
+ if which fc-list >/dev/null 2>&1 ; then
fc-list :outline file index \
| sed -n \
-e 's!^\(.*\)/\(.*\)\.\([^.]*\):
:index=0$!\2:\1/\2.\3:utf-8:!p' \

Done:

http://trac.osgeo.org/grass/changeset/38618
http://trac.osgeo.org/grass/changeset/38619

Markus