[GRASS-dev] Possible typos error in ./general/manage/cmd/rename.c:103

GRASS GIS GRASS GIS developer
1

I think there may be an error in ./general/manage/cmd/rename.c:103 (Renaming in reclassed map%s), but not sure the right form (¿map %s, mapset?)
Carlos

2

Carlos Dávila wrote:

I think there may be an error in ./general/manage/cmd/rename.c:103
(Renaming in reclassed map%s), but not sure the right form (¿map %s,

G_message(_("Renaming in reclassed map%s"),
    (nrmaps > 1 ? "s" : ""));

if there is more than 1 map it adds an "s" to the end of the string.
this sort of pluralization trick is probably not very transaltion safe,
and should be avoided. Beyond that, I'm not really sure what that
message is trying to say.

Hamish

3

Hamish wrote:

Carlos Dávila wrote:
>
> I think there may be an error in ./general/manage/cmd/rename.c:103
> (Renaming in reclassed map%s), but not sure the right form (¿map %s,

G_message(_("Renaming in reclassed map%s"),
    (nrmaps > 1 ? "s" : ""));

if there is more than 1 map it adds an "s" to the end of the string.
this sort of pluralization trick is probably not very transaltion safe,
and should be avoided. Beyond that, I'm not really sure what that
message is trying to say.

The "in" is a grammatical error; I've changed that line to:

  G_message(_("Renaming reclass maps"));

It's usually better to just always use the plural in such situations
than adding a special case for n == 1.

--
Glynn Clements <glynn@gclements.plus.com>