[GRASS-dev] prefer GeoPackage over Shapefile

Jachym_Cepicky · October 18, 2017, 12:28pm

Hi,

I would like to submit following commit to GRASS GIS - master

Index: vector/v.out.ogr/args.c

— vector/v.out.ogr/args.c (revision 71566)
+++ vector/v.out.ogr/args.c (working copy)
@@ -32,7 +32,7 @@
options->format->type = TYPE_STRING;
options->format->required = YES;
options->format->multiple = NO;

options->format->answer = “ESRI_Shapefile”;

options->format->answer = “DPKG”;
options->format->options = OGR_list_write_drivers();
options->format->description = _(“Data format to write”);

any objections?

Reasoning: all is written at http://switchtoshapefile.org

Jachym

rouault · October 18, 2017, 12:36pm

On mercredi 18 octobre 2017 12:28:36 CEST Jachym Cepicky wrote:

Hi,

I would like to submit following commit to GRASS GIS - master

Index: vector/v.out.ogr/args.c

--- vector/v.out.ogr/args.c (revision 71566)
+++ vector/v.out.ogr/args.c (working copy)
@@ -32,7 +32,7 @@
     options->format->type = TYPE_STRING;
     options->format->required = YES;
     options->format->multiple = NO;
- options->format->answer = "ESRI_Shapefile";
+ options->format->answer = "DPKG";
     options->format->options = OGR_list_write_drivers();
     options->format->description = _("Data format to write");

any objections?

I'm not a GRASS dev, but do I have a major objection... There's a typo in your
patch Should be GPKG

Joke aside, the SQLite dependency in GDAL builds is optional, so in theory you
could have a GDAL build without SQLite/GPKG support. But this is really
unlikely in practice as no sane packager would do that. Perhaps checking if
the GPKG driver is there would be safer, and if not fallback to good old
shapefile.

Even

--
Spatialys - Geospatial professional services
http://www.spatialys.com

Jachym_Cepicky · October 18, 2017, 1:07pm

Hi Evan,
oh, thanks for the typo, fixed in my code

There is driver check in the code

https://svn.osgeo.org/grass/grass/trunk/vector/v.out.ogr/main.c

line 457

for (i = 0; i < OGRGetDriverCount(); i++) {
…

I could probably commit, but before I do, I would like to get confirmed by PSC, this is OK to GRASS community.

Jachym

P.S. I’ve prepared similar patch for QGIS for those, who are interested https://github.com/qgis/QGIS/pull/5385

st 18. 10. 2017 v 14:36 odesílatel Even Rouault <even.rouault@spatialys.com> napsal:

On mercredi 18 octobre 2017 12:28:36 CEST Jachym Cepicky wrote:

Hi,

I would like to submit following commit to GRASS GIS - master

Index: vector/v.out.ogr/args.c

— vector/v.out.ogr/args.c (revision 71566)
+++ vector/v.out.ogr/args.c (working copy)
@@ -32,7 +32,7 @@
options->format->type = TYPE_STRING;
options->format->required = YES;
options->format->multiple = NO;

options->format->answer = “ESRI_Shapefile”;

options->format->answer = “DPKG”;
options->format->options = OGR_list_write_drivers();
options->format->description = _(“Data format to write”);

any objections?

I’m not a GRASS dev, but do I have a major objection… There’s a typo in your
patch Should be GPKG

Joke aside, the SQLite dependency in GDAL builds is optional, so in theory you
could have a GDAL build without SQLite/GPKG support. But this is really
unlikely in practice as no sane packager would do that. Perhaps checking if
the GPKG driver is there would be safer, and if not fallback to good old
shapefile.

Even

–
Spatialys - Geospatial professional services
http://www.spatialys.com

Jachym_Cepicky · October 18, 2017, 1:45pm

Thanks again

This is not a good day for pushing for such complex changes for me. It would be safer, not to get out of the bed today.

switchfromshapefile.org is the page

J

st 18. 10. 2017 v 15:27 odesílatel Vincent Bain <bain@toraval.fr> napsal:

Hi Jachym : devil is in the details, ah, ah !

Le mercredi 18 octobre 2017 à 12:28 +0000, Jachym Cepicky a
écrit :

Reasoning: all is written at http://switchtoshapefile.org

You probably meant switchfromshapefile.org ?

Thanks for all; here in France students massively still use shapefiles,
and worse! dumb tiff+tfw rasters. As though they had lived 30 years
sooner and would refuse improvements…

Vincent

martinl · October 18, 2017, 2:25pm

Hi,

please create a valid ticket on Trac for this issue. Thanks. Ma

2017-10-18 14:28 GMT+02:00 Jachym Cepicky <jachym.cepicky@gmail.com>:

Hi,

I would like to submit following commit to GRASS GIS - master

Index: vector/v.out.ogr/args.c

--- vector/v.out.ogr/args.c (revision 71566)
+++ vector/v.out.ogr/args.c (working copy)
@@ -32,7 +32,7 @@
     options->format->type = TYPE_STRING;
     options->format->required = YES;
     options->format->multiple = NO;
- options->format->answer = "ESRI_Shapefile";
+ options->format->answer = "DPKG";
     options->format->options = OGR_list_write_drivers();
     options->format->description = _("Data format to write");

any objections?

Reasoning: all is written at http://switchtoshapefile.org

Jachym

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

neteler · October 18, 2017, 2:30pm

On Oct 18, 2017 4:25 PM, “Martin Landa” <landa.martin@gmail.com> wrote:

Hi,

please create a valid ticket on Trac for this issue. Thanks. Ma

Yes please.
And only for trunk (future 7.4) since we cannot touch default settings in released versions.

Markus

Jachym_Cepicky · October 18, 2017, 2:40pm

Hi,

https://trac.osgeo.org/grass/ticket/3428

J

st 18. 10. 2017 v 16:30 odesílatel Markus Neteler <neteler@osgeo.org> napsal:

On Oct 18, 2017 4:25 PM, “Martin Landa” <landa.martin@gmail.com> wrote:

Hi,

please create a valid ticket on Trac for this issue. Thanks. Ma

Yes please.
And only for trunk (future 7.4) since we cannot touch default settings in released versions.

Markus