[GRASS-dev] problem with r59163

Hi devs, specially Maris

the changeset r59163 broke grass70 startup.
In our group we had three different situation:
- I have no problem in wx file I had language;locale;lc_all;C
- one my colleague cannot start grass70 because language was missing
in his wx file
- another colleague had language;locale;lc_all;None he was able to
start grass70.

Can I suggest to set up the os environment language if language is
missing in the wx file and show a dialog that suggest to the user to
change the language in the setting preferences?

This is the error that my colleague had:

Traceback (most recent call last):
File "/usr/local/bin/grass70", line 1279, in <module>
   set_language()
File "/usr/local/bin/grass70", line 778, in set_language
   if language == 'None':
UnboundLocalError: local variable 'language' referenced before assignment

[0] http://trac.osgeo.org/grass/changeset/59163

--
ciao
Luca

http://gis.cri.fmach.it/delucchi/
www.lucadelu.org

I'm so sorry, Luca.
I was under a false assumption that language is always present in wx
file (even if it's None). I pushed a simple fix as r59176. Now it
should just fail silently if language override is not in force.

As goes for offering the user to switch the language - it could go to
the startup screen as a dropdown list, but there is no need to ask for
it if it's absent as it's a language override - i.e. if you, as a
Italian speaker, have to work with GRASS in Japan on a computer
configured with Japanese locale. Thus for every day use on your own
computer, you shouldn't need it at all.

Just ping me back, if there are any other issues, as getting this
locale stuff right is hard and on some OSes (Windows) even impossible.

With apologies,
Maris.

2014-03-03 11:29 GMT+02:00 Luca Delucchi <lucadeluge@gmail.com>:

Hi devs, specially Maris

the changeset r59163 broke grass70 startup.
In our group we had three different situation:
- I have no problem in wx file I had language;locale;lc_all;C
- one my colleague cannot start grass70 because language was missing
in his wx file
- another colleague had language;locale;lc_all;None he was able to
start grass70.

Can I suggest to set up the os environment language if language is
missing in the wx file and show a dialog that suggest to the user to
change the language in the setting preferences?

This is the error that my colleague had:

Traceback (most recent call last):
File "/usr/local/bin/grass70", line 1279, in <module>
   set_language()
File "/usr/local/bin/grass70", line 778, in set_language
   if language == 'None':
UnboundLocalError: local variable 'language' referenced before assignment

[0] http://trac.osgeo.org/grass/changeset/59163

--
ciao
Luca

http://gis.cri.fmach.it/delucchi/
www.lucadelu.org
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev