OK. I have replicated the memory allocation changes from r.cva.
It seems to run without bad allocs now. I cannot confirm that
it no longer crashes on Windows. Someone with a Windows GRASS
setup will need to do that.
The patch also contains a fix done by Mark Lake years ago that
never made it back into r.los. It fixes a problem with calculating
cell neighbourhoods in combination with raster masks (see. pts_elim.c).
Ben
----- Original Message -----
From: "Hamish" <hamish_b@yahoo.com>
To: "developers grass" <grass-dev@lists.osgeo.org>, "Benjamin Ducke" <benjamin.ducke@oxfordarch.co.uk>
Sent: Sunday, March 1, 2009 10:17:22 AM GMT +00:00 GMT Britain, Ireland, Portugal
Subject: Re: [GRASS-dev] r.los on windows question
Markus:
Given the extreme speed improvement of r.viewshed from addons
I consider fixing r.los a waste of time.
If it is a trivial fix, and right in front of us, we might as well do it.
It is a small cost to have a working & well tested LOS module in 6.4.0,
even if it is horribly slow.
Hamish
------
Files attached to this email may be in ISO 26300 format (OASIS Open Document Format). If you have difficulty opening them, please visit http://iso26300.info for more information.
(attachments)
r.los.patch (5.31 KB)