[GRASS-dev] r.plane commits breaks winGRASS builds

looking into winGRASS build logs:

https://wingrass.fsv.cvut.cz/grass73/x86_64/logs/log-r71566-385/error.log
https://wingrass.fsv.cvut.cz/grass73/x86_64/logs/log-r71567-385/error.log

recent r.plane commits seems to break winGRASS builds:

GRASS GIS 7.3.svn r71567 compilation log
--------------------------------------------------
Started compilation: Thu Oct 19 23:40:19 2017
--
Errors in:
/c/msys64/usr/src/grass_trunk/scripts/r.plane
--
In case of errors please change into the directory with error and run
'make'.
If you get multiple errors, you need to deal with them in the order they
appear in the error log. If you get an error building a library, you will
also get errors from anything which uses the library.
--
Finished compilation: Fri Oct 20 00:17:27 2017

-----
best regards
Helmut
--
Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html

Hi,

2017-10-20 9:16 GMT+02:00 Helmut Kudrnovsky <hellik@web.de>:

looking into winGRASS build logs:

https://wingrass.fsv.cvut.cz/grass73/x86_64/logs/log-r71566-385/error.log
https://wingrass.fsv.cvut.cz/grass73/x86_64/logs/log-r71567-385/error.log

see https://wingrass.fsv.cvut.cz/grass73/x86_64/logs/log-r71567-385/package.log

"""
SyntaxError: Non-ASCII character '\xc3' in file
C:/msys64/usr/src/grass_trunk/dist.x86_64-w64-mingw32/scripts/r.plane.py
on line 6, but no encoding declared; see
http://python.org/dev/peps/pep-0263/ for details
../../include/Make/Html.make:14: recipe for target 'r.plane.tmp.html' failed
make[3]: *** [r.plane.tmp.html] Error 1
GISRC=/c/msys64/usr/src/grass_trunk/dist.x86_64-w64-mingw32/demolocation/.grassrc7
"""

putting

"""
# -*- coding: utf-8 -*-
"""

in r.plane.py should fix the issue.

Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

On Fri, Oct 20, 2017 at 10:03 AM, Martin Landa <landa.martin@gmail.com> wrote:

Hi,

2017-10-20 9:16 GMT+02:00 Helmut Kudrnovsky <hellik@web.de>:

looking into winGRASS build logs:

https://wingrass.fsv.cvut.cz/grass73/x86_64/logs/log-r71566-385/error.log
https://wingrass.fsv.cvut.cz/grass73/x86_64/logs/log-r71567-385/error.log

see https://wingrass.fsv.cvut.cz/grass73/x86_64/logs/log-r71567-385/package.log

"""
SyntaxError: Non-ASCII character '\xc3' in file
C:/msys64/usr/src/grass_trunk/dist.x86_64-w64-mingw32/scripts/r.plane.py
on line 6, but no encoding declared; see
http://python.org/dev/peps/pep-0263/ for details
../../include/Make/Html.make:14: recipe for target 'r.plane.tmp.html' failed
make[3]: *** [r.plane.tmp.html] Error 1
GISRC=/c/msys64/usr/src/grass_trunk/dist.x86_64-w64-mingw32/demolocation/.grassrc7
"""

putting

"""
# -*- coding: utf-8 -*-
"""

in r.plane.py should fix the issue.

Sorry for accidentially haven broken this. I was not aware that
putting an umlaut into a .py file may become an issue.

Background: I am currently sitting next to this original r.plane
developer Stefan Jäger :slight_smile: He noted that his name got lost time ago
and I promised to put it back.
Also the r.statistics original author Martin Schröder is here. Funny
to meet them first time ~23 years after inception of the modules...

Re: bugfix. I could also change the name to "Jaeger". Let me know what
you prefer.

best,
Markus

--
Markus Neteler, PhD
http://www.mundialis.de - free data with free software
http://grass.osgeo.org
http://courses.neteler.org/blog

Re: bugfix. I could also change the name to "Jaeger". Let me know what
you prefer.

any chance for the bugfix? winGRASS will be still broken until the fix.

I'm in favor of:

"""
# -*- coding: utf-8 -*-
"""

-----
best regards
Helmut
--
Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html

Helmut Kudrnovsky wrote

Re: bugfix. I could also change the name to "Jaeger". Let me know what
you prefer.

any chance for the bugfix? winGRASS will be still broken until the fix.

I'm in favor of:

"""
# -*- coding: utf-8 -*-
"""

done by

r71569 - grass/trunk/scripts/r.plane
r71570 - grass/branches/releasebranch_7_2/scripts/r.plane
r71571 - grass/branches/releasebranch_7_0/scripts/r.plane

fix for grass/branches/releasebranch_6_4/scripts/r.plane is still open.

-----
best regards
Helmut
--
Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html

On Fri, Oct 20, 2017 at 9:51 PM, Helmut Kudrnovsky <hellik@web.de> wrote:

Helmut Kudrnovsky wrote

Re: bugfix. I could also change the name to "Jaeger". Let me know what
you prefer.

any chance for the bugfix? winGRASS will be still broken until the fix.

I'm in favor of:

"""
# -*- coding: utf-8 -*-
"""

done by

r71569 - grass/trunk/scripts/r.plane
r71570 - grass/branches/releasebranch_7_2/scripts/r.plane
r71571 - grass/branches/releasebranch_7_0/scripts/r.plane

thanks!

fix for grass/branches/releasebranch_6_4/scripts/r.plane is still open.

For now I have written the original author's name without umlaut (r71572).

Markus