[GRASS-dev] Re: [GRASS-CVS] hamish: grass6/display/d.vect main.c, 1.71, 1.72

GRASS GIS GRASS GIS developer
1

Agreed! But, it's inconsistent with "attrcol"? Should we keep it for
historical reason?

Huidae Cho

On Wed, May 17, 2006 at 02:45:37AM +0200, grass@intevation.de wrote:

Author: hamish

Update of /grassrepository/grass6/display/d.vect
In directory doto:/tmp/cvs-serv26217/grass6/display/d.vect

Modified Files:
  main.c
Log Message:
wcol -> wcolumn. don't abbreviate (harder to understand), the parser can take care of that.

Index: main.c

RCS file: /grassrepository/grass6/display/d.vect/main.c,v
retrieving revision 1.71
retrieving revision 1.72
diff -u -d -r1.71 -r1.72
--- main.c 16 May 2006 21:11:21 -0000 1.71
+++ main.c 17 May 2006 00:45:35 -0000 1.72
@@ -188,7 +188,7 @@
   width_opt->description= _("Line width");

   wcol_opt = G_define_option() ;
- wcol_opt->key = "wcol" ;
+ wcol_opt->key = "wcolumn" ;
   wcol_opt->type = TYPE_STRING ;
   wcol_opt->description= _("Name of column for line widths (these values will be scaled by wscale)");

_______________________________________________
grass-commit mailing list
grass-commit@grass.itc.it
http://grass.itc.it/mailman/listinfo/grass-commit

2

Update of /grassrepository/grass6/display/d.vect
In directory doto:/tmp/cvs-serv26217/grass6/display/d.vect

Modified Files:
  main.c
Log Message:
wcol -> wcolumn. don't abbreviate (harder to understand), the parser
  can take care of that.

Agreed! But, it's inconsistent with "attrcol"?

yes, but I think that's minor inconsistency. Consistency is to be
followed wherever possible, but at the same time we shouldn't perpetuate
bad habits. (how do non-english speakers begin to decode "attrcol"?)
The goal is to be intuitive. I don't mind following which-ever is the
better path to get there.

Should we keep it for historical reason?

the parser will treat any attrcol= call in a script or habit the same as
attrcolumn=, so no worries about backwards compatibility if that were to
change. Changing it to attr_column= would be backwards incompatible
however.

Hamish