[GRASS-dev] Re: [GRASS-SVN] r32550 - grass/trunk/raster/r.colors

GRASS GRASS developer
1

On Wed, Aug 6, 2008 at 2:57 AM, <svn_grass@osgeo.org> wrote:
...

Modified:
  grass/trunk/raster/r.colors/main.c
Log:
Remove color=rules (redundant; use -i instead)

I have updated the description.html accordingly.

But:
-i Enter rules interactively

I find this description somewhat misleading for the example in
description.html (think newcomer here):

"The color table can then by assigned to map 'threecats' by the following
GRASS command:

cat rules.file | r.colors -i map=threecats
"

Suggestions for better wording in the flag description (main.c)?

Markus

2

Markus Neteler wrote:

> Modified:
> grass/trunk/raster/r.colors/main.c
> Log:
> Remove color=rules (redundant; use -i instead)

I have updated the description.html accordingly.

But:
-i Enter rules interactively

I find this description somewhat misleading for the example in
description.html (think newcomer here):

"The color table can then by assigned to map 'threecats' by the following
GRASS command:

cat rules.file | r.colors -i map=threecats
"

Suggestions for better wording in the flag description (main.c)?

  "Read rules from standard input (stdin)"
?

--
Glynn Clements <glynn@gclements.plus.com>

3

On Wed, Aug 6, 2008 at 5:47 PM, Glynn Clements <glynn@gclements.plus.com> wrote:

Markus Neteler wrote:

> Modified:
> grass/trunk/raster/r.colors/main.c
> Log:
> Remove color=rules (redundant; use -i instead)

I have updated the description.html accordingly.

But:
-i Enter rules interactively

I find this description somewhat misleading for the example in
description.html (think newcomer here):

"The color table can then by assigned to map 'threecats' by the following
GRASS command:

cat rules.file | r.colors -i map=threecats
"

Suggestions for better wording in the flag description (main.c)?

       "Read rules from standard input (stdin)"
?

Possibly you didn't submit? Or am I looking at the wrong file?

[neteler@markus r.colors]$ pwd
/home/neteler/grass70/raster/r.colors
[neteler@markus r.colors]$ nl main.c

     1 /****************************************************************************
     2 *
     3 * MODULE: r.colors
     4 *
     5 * AUTHOR(S): Michael Shapiro - CERL
     6 * David Johnson
     7 *
     8 * PURPOSE: Allows creation and/or modification of the color table
     9 * for a raster map layer.
...
   180 flag.i = G_define_flag();
   181 flag.i->key = 'i';
   182 flag.i->description = _("Enter rules interactively");

?
Markus

4

Markus Neteler wrote:

>> But:
>> -i Enter rules interactively
>>
>> I find this description somewhat misleading for the example in
>> description.html (think newcomer here):

>> Suggestions for better wording in the flag description (main.c)?
>
> "Read rules from standard input (stdin)"
> ?

Possibly you didn't submit? Or am I looking at the wrong file?

I didn't change it, I just offered the suggestion.

But I've just removed -i from 7.x in favour of "rules=-".

--
Glynn Clements <glynn@gclements.plus.com>