[GRASS-dev] Re: [GRASS-SVN] r33046 - in grass/trunk/lib: cairodriver pngdriver

GRASS GRASS developer
1

svn_grass@osgeo.org pisze:

Author: glynn
Date: 2008-08-23 22:20:30 -0400 (Sat, 23 Aug 2008)
New Revision: 33046

Modified:
   grass/trunk/lib/cairodriver/Graph.c
   grass/trunk/lib/pngdriver/Draw_line.c
   grass/trunk/lib/pngdriver/Polygon.c
Log:
Fix bug with cairo driver failing to erase background
Fix bug with PNG driver skipping topmost line of polygon
Change PNG driver's line-drawing to use FP throughout

From the changes as above, is the "Fix bug with PNG driver skipping topmost line of polygon" appropriate for backporting?

Maciek

--
Maciej Sieczka
www.sieczka.org

2

Maciej Sieczka wrote:

> Author: glynn
> Date: 2008-08-23 22:20:30 -0400 (Sat, 23 Aug 2008)
> New Revision: 33046
>
> Modified:
> grass/trunk/lib/cairodriver/Graph.c
> grass/trunk/lib/pngdriver/Draw_line.c
> grass/trunk/lib/pngdriver/Polygon.c
> Log:
> Fix bug with cairo driver failing to erase background
> Fix bug with PNG driver skipping topmost line of polygon
> Change PNG driver's line-drawing to use FP throughout

From the changes as above, is the "Fix bug with PNG driver skipping
topmost line of polygon" appropriate for backporting?

No.

The display architecture has been substantially rewritten to use
floating-point coordinates throughout. In most cases, it isn't
practical to backport changes.

I suspect that this particular bug was introduced in the conversion to
FP, so there's nothing to backport.

--
Glynn Clements <glynn@gclements.plus.com>