[GRASS-dev] Re: [GRASS-SVN] r48622 - grass/trunk/gui/wxpython/gui_modules

2011/10/5 <svn_grass@osgeo.org>:

Author: cmbarton
Date: 2011-10-05 00:37:36 -0700 (Wed, 05 Oct 2011)
New Revision: 48622

Modified:
grass/trunk/gui/wxpython/gui_modules/mapdisp.py
grass/trunk/gui/wxpython/gui_modules/preferences.py
grass/trunk/gui/wxpython/gui_modules/toolbars.py
grass/trunk/gui/wxpython/gui_modules/wxplot.py
grass/trunk/gui/wxpython/gui_modules/wxplot_dialogs.py
Log:
wxgui: added new bivariate scatter plot tool; code refactoring for profile and histogram plots.

this commit completely breaks wxGUI, mostly because of the fact that
preferences.py is replaced by wxplot_dialogs.py. I have reverted this
commit due to this fact. Please fix it locally first before
re-committing this change.

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

Martin,

You will need to be more informative about what you see as a problem if it is to be fixed. I added sections to both preferences.py and wxplot_dialogs.py to accommodate the new scatterplot tool, of course. But both are running fine locally and wxgui is not broken.

Michael
____________________
C. Michael Barton
Director, Center for Social Dynamics & Complexity
Professor of Anthropology, School of Human Evolution & Social Change
Arizona State University

voice: 480-965-6262 (SHESC), 480-727-9746 (CSDC)
fax: 480-965-7671 (SHESC), 480-727-0709 (CSDC)
www: http://www.public.asu.edu/~cmbarton, http://csdc.asu.edu

On Oct 5, 2011, at 12:56 AM, Martin Landa wrote:

2011/10/5 <svn_grass@osgeo.org>:

Author: cmbarton
Date: 2011-10-05 00:37:36 -0700 (Wed, 05 Oct 2011)
New Revision: 48622

Modified:
  grass/trunk/gui/wxpython/gui_modules/mapdisp.py
  grass/trunk/gui/wxpython/gui_modules/preferences.py
  grass/trunk/gui/wxpython/gui_modules/toolbars.py
  grass/trunk/gui/wxpython/gui_modules/wxplot.py
  grass/trunk/gui/wxpython/gui_modules/wxplot_dialogs.py
Log:
wxgui: added new bivariate scatter plot tool; code refactoring for profile and histogram plots.

this commit completely breaks wxGUI, mostly because of the fact that
preferences.py is replaced by wxplot_dialogs.py. I have reverted this
commit due to this fact. Please fix it locally first before
re-committing this change.

Martin

--
Martin Landa <landa.martin gmail.com> * Studijní program Geodézie a kartografie – GeoWikiCZ

2011/10/5 Michael Barton <Michael.Barton@asu.edu>:

You will need to be more informative about what you see as a problem if it is to be fixed. I added sections to both preferences.py and wxplot_dialogs.py

no, you just replaced content of preferences.py by wxplot_dialogs.py [1].

to accommodate the new scatterplot tool, of course. But both are running fine locally and wxgui is not broken.

That's really impossible to the fact I noted above.

Martin

[1] http://trac.osgeo.org/grass/changeset/48622#file1

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa