[GRASS-dev] Re: [GRASS-SVN] r49437 - grass/trunk/gui/wxpython

Hi Martin

the idea was that wx related docs should
not be generated if GRASS
is compiled without wxwidgets. That's why the
condition was added.

Markus

On 11/30/11, svn_grass@osgeo.org <svn_grass@osgeo.org> wrote:

Author: martinl
Date: 2011-11-30 10:21:36 -0800 (Wed, 30 Nov 2011)
New Revision: 49437

Modified:
   grass/trunk/gui/wxpython/Makefile
Log:
don't conditionize `wxpython`, there is nothing to compile
`--with-widgets` is used during compilation, see eg.
`vizualization/wximgview`

Modified: grass/trunk/gui/wxpython/Makefile

--- grass/trunk/gui/wxpython/Makefile 2011-11-30 16:18:40 UTC (rev 49436)
+++ grass/trunk/gui/wxpython/Makefile 2011-11-30 18:21:36 UTC (rev 49437)
@@ -19,10 +19,8 @@
   mapdisp modules nviz psmap vdigit wxplot)
DSTDIRS := $(patsubst %,$(ETCDIR)/%,compat icons scripts xml)

-ifneq ($(strip $(WXVERSION)),)
default: $(DSTFILES) menustrings.py
   $(MAKE) parsubdirs
-endif

$(ETCDIR)/%: % | $(PYDSTDIRS) $(DSTDIRS)
   $(INSTALL_DATA) $< $@

_______________________________________________
grass-commit mailing list
grass-commit@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-commit

Hi Markus,

2011/11/30 Markus Neteler <neteler@osgeo.org>:

the idea was that wx related docs should
not be generated if GRASS
is compiled without wxwidgets. That's why the
condition was added.

hm, the problem is that `--with-wxwidgets` should control only if
modules which uses wxWidgets library are compiled or not. Than we
would probably need a new switch which would optionally disable
installing wxGUI code, eg. `--disable-wxgui`.

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

On Wed, Nov 30, 2011 at 7:53 PM, Martin Landa <landa.martin@gmail.com> wrote:

2011/11/30 Markus Neteler <neteler@osgeo.org>:

the idea was that wx related docs should
not be generated if GRASS
is compiled without wxwidgets. That's why the
condition was added.

hm, the problem is that `--with-wxwidgets` should control only if
modules which uses wxWidgets library are compiled or not. Than we
would probably need a new switch which would optionally disable
installing wxGUI code, eg. `--disable-wxgui`.

Apparently I don't understand the difference :slight_smile:
Compiling with --without-wxwidgets I thought would be the way to
get only a "core GRASS" version without GUI.

Markus

Hi,

2011/11/30 Markus Neteler <neteler@osgeo.org>:

hm, the problem is that `--with-wxwidgets` should control only if
modules which uses wxWidgets library are compiled or not. Than we
would probably need a new switch which would optionally disable
installing wxGUI code, eg. `--disable-wxgui`.

Apparently I don't understand the difference :slight_smile:
Compiling with --without-wxwidgets I thought would be the way to
get only a "core GRASS" version without GUI.

no, it's not purpose of `--with(out)-widgets` switch. It was
introduced to control compilation of modules which are linked against
wxWidgets library, eg. `wximgview`. In other words, with
`--without-wxwidgets` you should get GRASS without modules which are
using wxWidgets library directly. It's not the case of wxGUI. Probably
we should think about introducing a new configure switch for disabling
wxGUI.

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

Hi,

2011/11/30 Martin Landa <landa.martin@gmail.com>:

no, it's not purpose of `--with(out)-widgets` switch. It was
introduced to control compilation of modules which are linked against
wxWidgets library, eg. `wximgview`. In other words, with
`--without-wxwidgets` you should get GRASS without modules which are
using wxWidgets library directly. It's not the case of wxGUI. Probably
we should think about introducing a new configure switch for disabling
wxGUI.

similarly `--without-python` doesn't mean that python scripts will be
no installed. It just means that the programs which are built against
python libraries will be not compiled.

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

Hi,

somewhat off-topic, but while I'm reminded of it:

building grass 7 with `make -j 8` on a muti-cpu machine ends with a
build error in the wxpython docs dir. `cd gui/wxpython/` and running
`make` has no error, so I suspect it is just a Makefile dependency thing.

building 6.4 and 6.5 completes without error. (58 sec for full compile!)

Hamish

2011/11/30 Hamish <hamish_b@yahoo.com>:

building grass 7 with `make -j 8` on a muti-cpu machine ends with a
build error in the wxpython docs dir. `cd gui/wxpython/` and running
`make` has no error, so I suspect it is just a Makefile dependency thing.

http://lists.osgeo.org/pipermail/grass-dev/2011-November/056482.html

Still not solved.

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

Martin Landa wrote:

> building grass 7 with `make -j 8` on a muti-cpu machine ends with a
> build error in the wxpython docs dir. `cd gui/wxpython/` and running
> `make` has no error, so I suspect it is just a Makefile dependency thing.

http://lists.osgeo.org/pipermail/grass-dev/2011-November/056482.html

Still not solved.

Try r49455.

--
Glynn Clements <glynn@gclements.plus.com>