[GRASS-dev] Re: shell scripts: variable bash-isms removed

John Graham wrote:

Markus

I still need to build on Solaris 10 using
make SHELL=/usr/bin/bash

or i get
gcc -L/usr/local/src/grass6/dist.sparc-sun-solaris2.10/lib
-Wl,-R,/usr/local/src/grass6/dist.sparc-sun-solaris2.10/lib
-L/usr/local/pgsql/lib -DPACKAGE=\""grassmods"\" -o
/usr/local/src/grass6/dist.sparc-sun-solaris2.10/bin/r3.out.ascii
OBJ.sparc-sun-solaris2.10/main.o -lgrass_g3d -lgrass_gis
-lgrass_datetime -lnsl -lz -lsocket -lgrass_gis -lgrass_datetime
-lnsl -lz -lsocket -lm -lnsl -lz
GISRC=/usr/local/src/grass6/dist.sparc-sun-solaris2.10/demolocation/.grassrc63
GISBASE=/usr/local/src/grass6/dist.sparc-sun-solaris2.10
PATH="/usr/local/src/grass6/dist.sparc-sun-solaris2.10/bin:$PATH"
LD_LIBRARY_PATH="/usr/local/src/grass6/dist.sparc-sun-solaris2.10/bin:/usr/local/src/grass6/dist.sparc-sun-solaris2.10/lib:"
LC_ALL=C /usr/local/src/grass6/dist.sparc-sun-solaris2.10/bin/r3.out.ascii
--html-description | grep -v '</body>\|</html>' > r3.out.ascii.tmp.html
; true
/bin/sh: !: not found
/bin/sh: !: not found
/bin/sh: !: not found

John,

is r3.out.ascii a random module with that problem or the only one?
I assume that it happens with all modules, due to

# On Linux:
...
for file in *.png *.jpg ; do \
                head -n 1 $file | grep '^#!' > /dev/null ; \
                if [ $? -ne 0 ] ; then \
                   /usr/bin/install -c -m 644 $file /home/neteler/soft/63grass_cvsexp/dist.i686-pc-linux-gnu/docs/html ; \
                fi \
                done 2> /dev/null ; true

On solaris, maybe the GRASS' install-sh is picked instead.
Can you please send the output of
grep INSTALL include/Make/Platform.make

I get on Linux:
INSTALL = /usr/bin/install -c
INSTALL_DATA = ${INSTALL} -m 644

You get?

----------------------------------------------------------------------
Following modules are missing the 'description.html' file in src code:
i.ask
i.find
photo.elev
photo.target
r.li.patchnumber
r.li.shape
r.watershed.ram
r.watershed.seg
----------------------------------------------------------------------

Above is rather harmless.

GRASS GIS compilation log
-------------------------
Started compilation: Sun Nov 26 03:11:15 PST 2006
--
Errors in:
--
Finished compilation: Sun Nov 26 03:14:26 PST 2006
(In case of errors please change into the directory with error and run
'make')

Also GEM has never worked in solaris 10 yet ... It wasnt bothering me ...

#GEM installation
tar cBf - gem/skeleton | (cd /usr/local/grass-6.3.cvs/etc ; tar xBf - )
2>/dev/null
cp gem/gem /usr/local/bin 2>/dev/null
make[1]: [real-install] Error 1 (ignored)
make[1]: Leaving directory `/usr/local/src/grass6'

Ah, this is another 'tar' candidate which needs to be updated.
There are several 'tar' candidates in the main Makefile.

Markus

John

Markus Neteler wrote:
>Hi,
>
>from IRC logs I picked this problem:
>"/usr/local/grass-6.2.1cvs/scripts/d.vect.thematic: LC_NUMERIC=C: is not
>an identifier"
>(the user works on Solaris).
>
>I have now fixed in CVS all "export" bash-isms in the scripts/
>subdirectory and changed from
>
> export VAR=value
>
>to
>
> VAR=value
> export VAR
>
>which should solve the problem.
>Backported to 6.2 as well.
>
>Markus
>

Subject: confirm 63302a2b363131375d8f37aa4f2f9a1c77fec990
From: grass-dev-request@grass.itc.it

If you reply to this message, keeping the Subject: header intact,
Mailman will discard the held message. Do this if the message is
spam. If you reply to this message and include an Approved: header
with the list password in it, the message will be approved for posting
to the list. The Approved: header can also appear in the first line
of the body of the reply.

--
Markus Neteler <neteler itc it> http://mpa.itc.it/markus/
ITC-irst - Centro per la Ricerca Scientifica e Tecnologica
MPBA - Predictive Models for Biol. & Environ. Data Analysis
Via Sommarive, 18 - 38050 Povo (Trento), Italy

Markus

r3.out.ascii is a random module with the bug ... there are too many paste here ...

grep INSTALL include/Make/Platform.make
INSTALL = /usr/local/bin/install -c
INSTALL_DATA = ${INSTALL} -m 644

/usr/local/bin/install is gnu install

John

Markus Neteler wrote:

John Graham wrote:
  

Markus

I still need to build on Solaris 10 using
make SHELL=/usr/bin/bash

or i get
gcc -L/usr/local/src/grass6/dist.sparc-sun-solaris2.10/lib -Wl,-R,/usr/local/src/grass6/dist.sparc-sun-solaris2.10/lib -L/usr/local/pgsql/lib -DPACKAGE=\""grassmods"\" -o /usr/local/src/grass6/dist.sparc-sun-solaris2.10/bin/r3.out.ascii OBJ.sparc-sun-solaris2.10/main.o -lgrass_g3d -lgrass_gis -lgrass_datetime -lnsl -lz -lsocket -lgrass_gis -lgrass_datetime -lnsl -lz -lsocket -lm -lnsl -lz
GISRC=/usr/local/src/grass6/dist.sparc-sun-solaris2.10/demolocation/.grassrc63 GISBASE=/usr/local/src/grass6/dist.sparc-sun-solaris2.10 PATH="/usr/local/src/grass6/dist.sparc-sun-solaris2.10/bin:$PATH" LD_LIBRARY_PATH="/usr/local/src/grass6/dist.sparc-sun-solaris2.10/bin:/usr/local/src/grass6/dist.sparc-sun-solaris2.10/lib:" LC_ALL=C /usr/local/src/grass6/dist.sparc-sun-solaris2.10/bin/r3.out.ascii --html-description | grep -v '</body>\|</html>' > r3.out.ascii.tmp.html ; true
/bin/sh: !: not found
    
John,

is r3.out.ascii a random module with that problem or the only one?
I assume that it happens with all modules, due to

# On Linux:
...
for file in *.png *.jpg ; do \
                head -n 1 $file | grep '^#!' > /dev/null ; \
                if [ $? -ne 0 ] ; then \
                   /usr/bin/install -c -m 644 $file /home/neteler/soft/63grass_cvsexp/dist.i686-pc-linux-gnu/docs/html ; \
                fi \
                done 2> /dev/null ; true

On solaris, maybe the GRASS' install-sh is picked instead.
Can you please send the output of
grep INSTALL include/Make/Platform.make

I get on Linux:
INSTALL = /usr/bin/install -c
INSTALL_DATA = ${INSTALL} -m 644

You get?

----------------------------------------------------------------------
Following modules are missing the 'description.html' file in src code:
i.ask
i.find
photo.elev
photo.target
r.li.patchnumber
r.li.shape
r.watershed.ram
r.watershed.seg
----------------------------------------------------------------------
    
Above is rather harmless.

GRASS GIS compilation log
-------------------------
Started compilation: Sun Nov 26 03:11:15 PST 2006
--
Errors in:
--
Finished compilation: Sun Nov 26 03:14:26 PST 2006
(In case of errors please change into the directory with error and run 'make')

Also GEM has never worked in solaris 10 yet ... It wasnt bothering me ...

#GEM installation
tar cBf - gem/skeleton | (cd /usr/local/grass-6.3.cvs/etc ; tar xBf - ) 2>/dev/null
cp gem/gem /usr/local/bin 2>/dev/null
make[1]: [real-install] Error 1 (ignored)
make[1]: Leaving directory `/usr/local/src/grass6'
    
Ah, this is another 'tar' candidate which needs to be updated.
There are several 'tar' candidates in the main Makefile.

Markus

John

Markus Neteler wrote:
    

Hi,

>from IRC logs I picked this problem:
    

"/usr/local/grass-6.2.1cvs/scripts/d.vect.thematic: LC_NUMERIC=C: is not an identifier"
(the user works on Solaris).

I have now fixed in CVS all "export" bash-isms in the scripts/
subdirectory and changed from

export VAR=value

to

VAR=value
export VAR

which should solve the problem.
Backported to 6.2 as well.

Markus

Subject: confirm 63302a2b363131375d8f37aa4f2f9a1c77fec990
From: grass-dev-request@grass.itc.it

If you reply to this message, keeping the Subject: header intact,
Mailman will discard the held message. Do this if the message is
spam. If you reply to this message and include an Approved: header
with the list password in it, the message will be approved for posting
to the list. The Approved: header can also appear in the first line
of the body of the reply.