[GRASS-dev] Renaming G3d into Rast3d

Dear devs,
i just noticed that massive renaming in the G3d library is going on.
Nothing against to follow name convention, but it would be nice if
this kind of changes are discussed in the list first, so i can prepare
myself and my G3d dependent software for it.

I only noticed the changes because my vtk-grass-bridge is not working
anymore ... .

Best regards
Soeren

Hi,

2011/8/11 Soeren Gebbert <soerengebbert@googlemail.com>:

i just noticed that massive renaming in the G3d library is going on.
Nothing against to follow name convention, but it would be nice if
this kind of changes are discussed in the list first, so i can prepare
myself and my G3d dependent software for it.

I only noticed the changes because my vtk-grass-bridge is not working
anymore ... .

sorry for inconvenience, this step should have been done much more
earlier, but nobody did it. There are more important issues - fn
naming convention in this library completely breaks standard naming
convention from other GRASS core libraries. Moreover, some of the fns
should be replaced by similar functions for GIS library (see at least
alloc.c and error.c). I decided just to break the ice :wink: Anyway I
should have to announce it. Are you interested to rename and clean up
subroutines in this library towards standard naming convention and no
overlap with other (GIS and Raster) libraries?

Thanks, Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

Hello Martin,
renaming the G3D -> Raster3d functions to follow the grass naming
convention is on my TODO list for years now ... . But i never took the
time to start, so thanks for making the first step. Unfortunately i
have currently no time to join you. :confused:

Best regards
Soeren

2011/8/11 Martin Landa <landa.martin@gmail.com>:

Hi,

2011/8/11 Soeren Gebbert <soerengebbert@googlemail.com>:

i just noticed that massive renaming in the G3d library is going on.
Nothing against to follow name convention, but it would be nice if
this kind of changes are discussed in the list first, so i can prepare
myself and my G3d dependent software for it.

I only noticed the changes because my vtk-grass-bridge is not working
anymore ... .

sorry for inconvenience, this step should have been done much more
earlier, but nobody did it. There are more important issues - fn
naming convention in this library completely breaks standard naming
convention from other GRASS core libraries. Moreover, some of the fns
should be replaced by similar functions for GIS library (see at least
alloc.c and error.c). I decided just to break the ice :wink: Anyway I
should have to announce it. Are you interested to rename and clean up
subroutines in this library towards standard naming convention and no
overlap with other (GIS and Raster) libraries?

Thanks, Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

Hi,

2011/8/11 Soeren Gebbert <soerengebbert@googlemail.com>:

renaming the G3D -> Raster3d functions to follow the grass naming
convention is on my TODO list for years now ... . But i never took the
time to start, so thanks for making the first step. Unfortunately i
have currently no time to join you. :confused:

you are welcome:-) Anyway I think that it's not good idea to develop
new features before cleaning up the library. Volunteers welcomed...

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

Martin Landa wrote:

> renaming the G3D -> Raster3d functions to follow the grass naming
> convention is on my TODO list for years now ... . But i never took the
> time to start, so thanks for making the first step. Unfortunately i
> have currently no time to join you. :confused:

you are welcome:-) Anyway I think that it's not good idea to develop
new features before cleaning up the library. Volunteers welcomed...

Regarding naming, I've attached a sed script to change camelCase to
underscores in the function names. Suggested usage:

find . -type f -name '*.[ch]' | xargs grep -l '\<Rast3d_' | xargs sed -f fixnames.sed -i

--
Glynn Clements <glynn@gclements.plus.com>

(attachments)

fixnames.sed (9.86 KB)

Hi,

2011/8/12 Glynn Clements <glynn@gclements.plus.com>:

Regarding naming, I've attached a sed script to change camelCase to
underscores in the function names. Suggested usage:

thanks, applied in r47593.

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa