[GRASS-dev] SoC projects to trunk

Hi list,

I have now brought the two SoC modules (v.generalize and
v.net.visibility) to the CVS trunk. I would appreciate it very much if
someone could check the code once again :slight_smile: just to make sure it is
suitably stable.

I would also love it if someone could help me add these new modules to
the gui. v.net.visibility should probably go next to the other v.net.*
modules, but what about generalize? Should it go under Develop map?

I'll look into how to add these there myself, but any hints are appreciated.

--Wolf

--

<:3 )---- Wolf Bergenheim ----( 8:>

For gis.m, look into:

GRASSBASE/etc/gm/gmmenu.tcl.

Just copy a menu entry and work from there. I am sure you
will find it easy enough to understand the syntax.
One hint: be careful to get closing ] brackets right.

Benjamin

Wolf Bergenheim wrote:

Hi list,

I have now brought the two SoC modules (v.generalize and
v.net.visibility) to the CVS trunk. I would appreciate it very much if
someone could check the code once again :slight_smile: just to make sure it is
suitably stable.

I would also love it if someone could help me add these new modules to
the gui. v.net.visibility should probably go next to the other v.net.*
modules, but what about generalize? Should it go under Develop map?

I'll look into how to add these there myself, but any hints are appreciated.

--Wolf

--
Benjamin Ducke, M.A.
Archäoinformatik
(Archaeoinformation Science)
Institut für Ur- und Frühgeschichte
(Inst. of Prehistoric and Historic Archaeology)
Christian-Albrechts-Universität zu Kiel
Johanna-Mestorf-Straße 2-6
D 24098 Kiel
Germany

Tel.: ++49 (0)431 880-3378 / -3379
Fax : ++49 (0)431 880-7300
www.uni-kiel.de/ufg

On 02.11.2007 13:37, Benjamin Ducke wrote:

For gis.m, look into:

GRASSBASE/etc/gm/gmmenu.tcl.

Just copy a menu entry and work from there. I am sure you
will find it easy enough to understand the syntax.
One hint: be careful to get closing ] brackets right.

Brilliant! Thanks Benjamin! It works like a charm. Committed to trunk.

Now is someone could merge these changes to the 6.3 branch I'd be a very
happy camper!

--Wolf

--

<:3 )---- Wolf Bergenheim ----( 8:>

On Fri, Nov 02, 2007 at 12:48:19PM +0100, Wolf Bergenheim wrote:

On 02.11.2007 13:37, Benjamin Ducke wrote:
> For gis.m, look into:
>
> GRASSBASE/etc/gm/gmmenu.tcl.
>
> Just copy a menu entry and work from there. I am sure you
> will find it easy enough to understand the syntax.
> One hint: be careful to get closing ] brackets right.

Brilliant! Thanks Benjamin! It works like a charm. Committed to trunk.

Now is someone could merge these changes to the 6.3 branch I'd be a very
happy camper!

Done so (including Makefile fix).

Time to get out 6.3.0RC2!

Markus

On 02.11.2007 14:16, Markus Neteler wrote:

Done so (including Makefile fix).

Yay! Thanks for that!

--Wolf

--

<:3 )---- Wolf Bergenheim ----( 8:>

Hi all!

Before Markus releases 6.3.0RC2, would it be possible to include a
small usability fix:
[#521] Provide interactive environment on startup [1] - there has been
no negative feedback about this fix (anyone willing something to
say?).

I'm currently also looking into Glynns objections on patch #515.

Maris.

1. http://wald.intevation.org/tracker/index.php?func=detail&aid=521&group_id=21&atid=205

2007/11/2, Markus Neteler <neteler@fbk.eu>:

On Fri, Nov 02, 2007 at 12:48:19PM +0100, Wolf Bergenheim wrote:
> On 02.11.2007 13:37, Benjamin Ducke wrote:
> > For gis.m, look into:
> >
> > GRASSBASE/etc/gm/gmmenu.tcl.
> >
> > Just copy a menu entry and work from there. I am sure you
> > will find it easy enough to understand the syntax.
> > One hint: be careful to get closing ] brackets right.
>
> Brilliant! Thanks Benjamin! It works like a charm. Committed to trunk.
>
> Now is someone could merge these changes to the 6.3 branch I'd be a very
> happy camper!

Done so (including Makefile fix).

Time to get out 6.3.0RC2!

Markus

_______________________________________________
grass-dev mailing list
grass-dev@grass.itc.it
http://grass.itc.it/mailman/listinfo/grass-dev

Wolf Bergenheim wrote:

I have now brought the two SoC modules (v.generalize and
v.net.visibility) to the CVS trunk.

Hi, a few cleanup issues-

Does v.net.visibility have anything to do with the other v.net.* modules,
or is it just similar in name? As the other v.net.* modules all share vector
network node system (built with v.net), I worry that if v.net.visibility has
nothing to do with this it may cause confusion and v.path.obstacles would be a
better name. As I've not used it yet, I don't know, maybe it does.

I notice on the help page:
- Still calls it v.path.obstacles in many places
- A simple screenshot would be nice, using a standard dataset and given
commands so we can reproduce it while learning
- It would be nice if the examples use a standard sample dataset
- missing <BR> before "Mentor:"
- "Last Changed:" needs to be have "$Date$" for the CVS to pick that up

I also notice that indent was run on the module at the same time as other
changes*. For a usable diff history indent changes must be committed on their
own, and with full command line options used, so that it is possible to
recreate and spot errors from new changes. As done it is very hard to follow
what the standardization changes were. See the SUBMITTING file rule 15.

* http://freegis.org/cgi-bin/viewcvs.cgi/grass6/vector/v.net.visibility/

thanks,
Hamish

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com

On 06.11.2007 05:52, Hamish wrote:

Wolf Bergenheim wrote:

I have now brought the two SoC modules (v.generalize and
v.net.visibility) to the CVS trunk.

Hi, a few cleanup issues-

Hi,

Thanks for your input :slight_smile:

Does v.net.visibility have anything to do with the other v.net.* modules,
or is it just similar in name?

v.net.visibility creates a visibility graph, which can then be further
analyzed with v.net.path to create the shortest path through or around
the obstacles. So I'd say it is very closely related to the other
v.net.* modules. (I'll add an example)

As the other v.net.* modules all share vector
network node system (built with v.net), I worry that if v.net.visibility has
nothing to do with this it may cause confusion and v.path.obstacles would be a
better name. As I've not used it yet, I don't know, maybe it does.

In a way it is like v.net in that it creates a network which can be
further analyzed with the other v.net.* modules.

I notice on the help page:
- Still calls it v.path.obstacles in many places

fixed

- A simple screenshot would be nice, using a standard dataset and given
commands so we can reproduce it while learning
- It would be nice if the examples use a standard sample dataset

I'll see if I can find something in either dataset.

- missing <BR> before "Mentor:"

fixed

- "Last Changed:" needs to be have "$Date$" for the CVS to pick that up

fixed

Thanks again for your input,
--Wolf

--

<:3 )---- Wolf Bergenheim ----( 8:>