[GRASS-dev] Source code link in Addons

Hi devs,

a power user ask me to implement source code link also in Addons, so I
looked a little bit to the code and it seems it should work already.

During addon compilation Script.make is called, inside this there is
Html.make, this is calling mkhtml.py that contains the code to add
"Source code", so I don't understand why this is not added (with wrong
url) to the HTML file?

Am I missing anything? otherwise I will check a little bit deeper in
the actual code...

--
ciao
Luca

www.lucadelu.org

Hi Luca,

On Wed, Dec 14, 2016 at 3:39 PM, Luca Delucchi <lucadeluge@gmail.com> wrote:

Hi devs,

a power user ask me to implement source code link also in Addons, so I
looked a little bit to the code and it seems it should work already.

During addon compilation Script.make is called, inside this there is
Html.make, this is calling mkhtml.py that contains the code to add
"Source code", so I don't understand why this is not added (with wrong
url) to the HTML file?

I think it all works. The point is that the Addons on the Web site are
compiled against V7.0.svn while only V7.2.svn comes with the new
source code/history link.
As soon as we enable building the addons against 7.2. it will be included.

In local 7.2 installations, with g.extension, the manual of addons
contains the desired links (try with g.manual someaddon).

So I think it is all working, just not yet visible on the Web site.

Markus

Hi :slight_smile:

I checked what Markus says, and yes the links appear in addons if I
call g.manual some-addon from 72 or 73, but I am not redirected to the
source code. Instead, I get the following:

Trac Error
No node grass/trunk/home/veroandreo/tmp/grass7-veroandreo-18093/tmppTzxLm/t.rast.out.xyz
at revision 70080

Do you get the same or is something in my PC only?

Thanks much!
Vero

2016-12-14 22:23 GMT+01:00 Markus Neteler <neteler@osgeo.org>:

Hi Luca,

On Wed, Dec 14, 2016 at 3:39 PM, Luca Delucchi <lucadeluge@gmail.com> wrote:

Hi devs,

a power user ask me to implement source code link also in Addons, so I
looked a little bit to the code and it seems it should work already.

During addon compilation Script.make is called, inside this there is
Html.make, this is calling mkhtml.py that contains the code to add
"Source code", so I don't understand why this is not added (with wrong
url) to the HTML file?

I think it all works. The point is that the Addons on the Web site are
compiled against V7.0.svn while only V7.2.svn comes with the new
source code/history link.
As soon as we enable building the addons against 7.2. it will be included.

In local 7.2 installations, with g.extension, the manual of addons
contains the desired links (try with g.manual someaddon).

So I think it is all working, just not yet visible on the Web site.

Markus
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Hi,

2016-12-15 9:01 GMT+01:00 Veronica Andreo <veroandreo@gmail.com>:

Trac Error
No node grass/trunk/home/veroandreo/tmp/grass7-veroandreo-18093/tmppTzxLm/t.rast.out.xyz
at revision 70080

you are right, links are broken. Please report on trac. Thanks, Ma

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa

Hi,

ยทยทยท

2016-12-15 22:08 GMT+01:00 Martin Landa <landa.martin@gmail.com>:

Trac Error
No node grass/trunk/home/veroandreo/tmp/grass7-veroandreo-18093/tmppTzxLm/t.rast.out.xyz
at revision 70080

you are right, links are broken. Please report on trac. Thanks, Ma

Done in #3224 (https://trac.osgeo.org/grass/ticket/3224)

Thanks :slight_smile:
Vero