[GRASS-dev] t.rast.what flags

GRASS GRASS developer
1

Hi devs,

I'm working on t.rast.what and I discovered that flags are not used in
the calling r.what module.

The comment said they are disabled for test issues [0], I think it is
more important to have these flags working and some problems test
problem instead don't use at all the flags.

What do you think?

[0] https://trac.osgeo.org/grass/browser/grass/trunk/temporal/t.rast.what/t.rast.what.py#L188

--
ciao
Luca

www.lucadelu.org

2

Hi Luca,
for what or why do you need the additional flags for r.what?

Ciao
Sören

2017-05-16 15:04 GMT+02:00 Luca Delucchi <lucadeluge@gmail.com>:

Hi devs,

I'm working on t.rast.what and I discovered that flags are not used in
the calling r.what module.

The comment said they are disabled for test issues [0], I think it is
more important to have these flags working and some problems test
problem instead don't use at all the flags.

What do you think?

[0] https://trac.osgeo.org/grass/browser/grass/trunk/temporal/t.rast.what/t.rast.what.py#L188

--
ciao
Luca

www.lucadelu.org
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

3

On 16 May 2017 at 17:18, Sören Gebbert <soerengebbert@googlemail.com> wrote:

Hi Luca,

Hi Sören,

for what or why do you need the additional flags for r.what?

I just added a new flag in r.what to return also the cat of feature
and I would add this capability also to t.rast.what because I'm doing
a new module using this feature...

Ciao
Sören

--
ciao
Luca

www.lucadelu.org

4

Feel free to modify t.rast.what. However, i found it too complicated
to add category/attribute output to r.what/t.rast.what so i
implemented t.rast.sample that does it more elegant and outputs
category and vector attributes:

https://bitbucket.org/huhabla/temporal-raster-sampling

Ciao
Sören

2017-05-16 17:38 GMT+02:00 Luca Delucchi <lucadeluge@gmail.com>:

On 16 May 2017 at 17:18, Sören Gebbert <soerengebbert@googlemail.com> wrote:

Hi Luca,

Hi Sören,

for what or why do you need the additional flags for r.what?

I just added a new flag in r.what to return also the cat of feature
and I would add this capability also to t.rast.what because I'm doing
a new module using this feature...

Ciao
Sören

--
ciao
Luca

www.lucadelu.org

5

On 16 May 2017 at 17:53, Sören Gebbert <soerengebbert@googlemail.com> wrote:

Feel free to modify t.rast.what. However, i found it too complicated
to add category/attribute output to r.what/t.rast.what so i
implemented t.rast.sample that does it more elegant and outputs
category and vector attributes:

https://bitbucket.org/huhabla/temporal-raster-sampling

ok, instead I found t.rast.what with timerow layout really useful with my scope.

I will submit small changes on t.rast.what

Ciao
Sören

--
ciao
Luca

www.lucadelu.org