[GRASS-dev] Test report: different message breaks the test

GRASS GIS GRASS GIS developer
1

Hi,

it seems that some change in error message broke the test. I’m not sure what should the the general approach in these cases. The test should be changed with the message that’s clear but the question is how precise we want the message test to be. Perhaps we want to test there is some message or that there is a string such as “SQL” or name of the column in it. Any opinions?

Vaclav

The broken test:

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-10-13-07-00/report_for_nc_basic_spm_grass7_nc/lib/python/pygrass/vector/test_geometry_attrs/index.html

2

Il 16 ott 2015 5:38 PM, “Vaclav Petras” <wenzeslaus@gmail.com> ha scritto:

Hi,

it seems that some change in error message broke the test. I’m not sure what should the the general approach in these cases. The test should be changed with the message that’s clear but the question is how precise we want the message test to be. Perhaps we want to test there is some message or that there is a string such as “SQL” or name of the column in it. Any opinions?

Yes, I can remove the test on the error message, probably I was just too pendant…
The important thing is that an exception is raised!

Pietro

3

On Fri, Oct 16, 2015 at 4:33 PM, Pietro <peter.zamb@gmail.com> wrote:

Il 16 ott 2015 5:38 PM, "Vaclav Petras" <wenzeslaus@gmail.com> ha scritto:
>
> Hi,
>
> it seems that some change in error message broke the test. I'm not sure
what should the the general approach in these cases. The test should be
changed with the message that's clear but the question is how precise we
want the message test to be. Perhaps we want to test there is some message
or that there is a string such as "SQL" or name of the column in it. Any
opinions?

Yes, I can remove the test on the error message, probably I was just too
pendant...
The important thing is that an exception is raised!

In few cases I was testing that the error message contains e.g. the name of
the raster map which does not exist and caused the error.