[GRASS-dev] Tests down to 78% (from 84%), mostly PyGRASS

GRASS GIS GRASS GIS developer
1

Hi all,

it seems that PyGRASS tests are down for some reason. This happened few days ago between r63925 and r63939.

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-02-08-00/report_for_nc_spm_08_grass7_nc/testfiles.html
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-03-08-00/report_for_nc_spm_08_grass7_nc/testfiles.html

http://trac.osgeo.org/grass/browser/grass/trunk?rev=63925
http://trac.osgeo.org/grass/browser/grass/trunk?rev=63939

See instructions how to run the tests on you own machine before the commit:

http://lists.osgeo.org/pipermail/grass-dev/2014-November/072166.html

It seems to me that the testing is really working. We are again and again finding bugs which would be missed, so please write more tests because just small portion of the code is covered.

Thanks,

Vaclav

2

On Mon, Jan 5, 2015 at 5:01 AM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

Hi all,

it seems that PyGRASS tests are down for some reason. This happened few days
ago between r63925 and r63939.

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-02-08-00/report_for_nc_spm_08_grass7_nc/testfiles.html
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-03-08-00/report_for_nc_spm_08_grass7_nc/testfiles.html

I checked this test:
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-02-08-00/report_for_nc_spm_08_grass7_nc/temporal/t.rast.to.rast3/test_strds_to_rast3/index.html

I tested like this:
GRASS 7.1.svn (nc_spm_08_grass7):~ > export GRASS_OVERWRITE=1
GRASS 7.1.svn (nc_spm_08_grass7):~ > python temporal/t.rast.to.rast3/testsuite/test_strds_to_rast3.py

The reason is that map ‘precip_i’ does not contain anything:
GRASS 7.1.svn (nc_spm_08_grass7):~ > r3.univar map=‘precip_i’ percentile=90.0 separator=pipe -g
GRASS 7.1.svn (nc_spm_08_grass7):~ >

Like r.univar, it does not report a single line when only NULL values were found.
Hence the test crashes.

Markus

3

Hi,

this test failure
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-03-08-00/report_for_nc_spm_08_grass7_nc/lib/gis/gis_lib_env_test/index.html

I have hopefully fixed in r63954, needed after libgis cleanup in r63830.
Let's see tomorrow.

Markus

4

On Mon, Jan 5, 2015 at 4:48 PM, Markus Neteler <neteler@osgeo.org> wrote:

Hi,

this test failure
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-03-08-00/report_for_nc_spm_08_grass7_nc/lib/gis/gis_lib_env_test/index.html

I have hopefully fixed in r63954, needed after libgis cleanup in r63830.

Additional fix in r63955.

It now fails only here:

GRASS 7.1.svn (nc_spm_08_grass7):~/software/grass71 > python
./lib/gis/testsuite/gis_lib_env_test.py
E..

ERROR: test_gisrc (__main__.GisLibraryTestEnv)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./lib/gis/testsuite/gis_lib_env_test.py", line 31, in test_gisrc
    libgis.G__read_gisrc_env()
AttributeError: 'module' object has no attribute 'G__read_gisrc_env'

Maybe the test is not written correctly (here: line 26)?

    25 # Force reading
    26 libgis.G__read_gisrc_env()
    27 value = libgis.G_getenv("TEST")
    28 self.assertEqual(value, "A")
    29 value = libgis.G_getenv2("TEST", libgis.G_VAR_GISRC)
    30 self.assertEqual(value, "A")

Any idea?

Markus

5

Hi Markus,

2015-01-05 17:12 GMT+01:00 Markus Neteler <neteler@osgeo.org>:

Any idea?

ops, I overlooked these issue, thanks for the fix! Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa

6

On Mon, Jan 5, 2015 at 8:27 PM, Martin Landa <landa.martin@gmail.com> wrote:

Hi Markus,

2015-01-05 17:12 GMT+01:00 Markus Neteler <neteler@osgeo.org>:

Any idea?

ops, I overlooked these issue, thanks for the fix! Martin

No problem. The only remaining thing which I don't understand how to
fix it is this:

  File "./lib/gis/testsuite/gis_lib_env_test.py", line 31, in test_gisrc
    libgis.G__read_gisrc_env()
AttributeError: 'module' object has no attribute 'G__read_gisrc_env'

Markus

7

2015-01-05 21:21 GMT+01:00 Markus Neteler <neteler@osgeo.org>:

No problem. The only remaining thing which I don't understand how to
fix it is this:

  File "./lib/gis/testsuite/gis_lib_env_test.py", line 31, in test_gisrc
    libgis.G__read_gisrc_env()
AttributeError: 'module' object has no attribute 'G__read_gisrc_env'

done in r63960 (and backported). Martin

--
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa

8

On Mon, Jan 5, 2015 at 4:15 PM, Martin Landa <landa.martin@gmail.com> wrote:

2015-01-05 21:21 GMT+01:00 Markus Neteler <neteler@osgeo.org>:
> No problem. The only remaining thing which I don't understand how to
> fix it is this:
>
> File "./lib/gis/testsuite/gis_lib_env_test.py", line 31, in test_gisrc
> libgis.G__read_gisrc_env()
> AttributeError: 'module' object has no attribute 'G__read_gisrc_env'

done in r63960 (and backported). Martin

Thanks but the tests are failing with different error now:

Traceback (most recent call last):
  File "lib/python/pygrass/raster/testsuite/test_raster.py", line 6, in
<module>
    from grass.pygrass.raster import RasterRow
  File "etc/python/grass/pygrass/raster/__init__.py", line 24, in <module>
   from grass.pygrass.gis.region import Region
  File "etc/python/grass/pygrass/gis/__init__.py", line 22, in <module>
    'icon': libgis.G_ELEMENT_ICON,
AttributeError: 'module' object has no attribute 'G_ELEMENT_ICON'

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-07-08-00/report_for_nc_spm_08_grass7_nc/testfiles.html

2015-01-07 03:01:42 63971 nc_spm_08_grass7 79% 99%

--

Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.eu/mentors/landa
_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

9

Hi Vaclav,

Il 07/gen/2015 16:11 “Vaclav Petras” wrote:

Thanks but the tests are failing with different error now:

Traceback (most recent call last):
File “lib/python/pygrass/raster/testsuite/test_raster.py”, line 6, in
from grass.pygrass.raster import RasterRow
File “etc/python/grass/pygrass/raster/init.py”, line 24, in
from grass.pygrass.gis.region import Region
File “etc/python/grass/pygrass/gis/init.py”, line 22, in
‘icon’: libgis.G_ELEMENT_ICON,
AttributeError: ‘module’ object has no attribute ‘G_ELEMENT_ICON’

I saw the error this morning. Should be fixed in r63972.

Pietro

10

On Mon, Jan 5, 2015 at 4:15 PM, Martin Landa <landa.martin@gmail.com> wrote:

2015-01-05 21:21 GMT+01:00 Markus Neteler <neteler@osgeo.org>:
> No problem. The only remaining thing which I don't understand how to
> fix it is this:
>
> File "./lib/gis/testsuite/gis_lib_env_test.py", line 31, in test_gisrc
> libgis.G__read_gisrc_env()
> AttributeError: 'module' object has no attribute 'G__read_gisrc_env'

done in r63960 (and backported). Martin

On Wed, Jan 7, 2015 at 10:37 AM, Pietro <peter.zamb@gmail.com> wrote:

Il 07/gen/2015 16:11 "Vaclav Petras" wrote:
> Thanks but the tests are failing with different error now:
>
>
> Traceback (most recent call last):
> File "lib/python/pygrass/raster/testsuite/test_raster.py", line 6, in
<module>
> from grass.pygrass.raster import RasterRow
> File "etc/python/grass/pygrass/raster/__init__.py", line 24, in
<module>
> from grass.pygrass.gis.region import Region
> File "etc/python/grass/pygrass/gis/__init__.py", line 22, in <module>
> 'icon': libgis.G_ELEMENT_ICON,
> AttributeError: 'module' object has no attribute 'G_ELEMENT_ICON'

I saw the error this morning. Should be fixed in r63972.

Pietro

To see if the tests are successful before you commit anything use inside
GRASS session:

python -m grass.gunittest.main --location nc_spm_grass7 --location-type nc

where "nc_spm_grass7" is your GRASS GIS sample NC SPM location. Read more
about running tests here:

http://grass.osgeo.org/grass71/manuals/libpython/gunittest_testing.html#testing-with-gunittest-package-in-general

I went through the tests and there is still several issues (ignoring the
once caused by different maps in NC full and basic):

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-09-08-00/report_for_nc_spm_08_grass7_nc/testfiles.html

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-09-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/test_doctests/index.html
NameError: name 'Region' is not defined

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-09-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/raster/test_history/index.html
OpenError: The map does not exist, I can't open in 'r' mode
(probably missing map but the error message should be better)

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-09-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/modules/test_doctests/index.html
AttributeError: 'module' object has no attribute 'grid'

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-09-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/shell/test_doctests/index.html
AttributeError: 'module' object has no attribute 'conversion'

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-09-08-00/report_for_nc_spm_08_grass7_nc/lib/python/pygrass/gis/test_doctests/index.html
AttributeError: 'module' object has no attribute 'region'

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-09-08-00/report_for_nc_spm_08_grass7_nc/temporal/t.rast.to.rast3/test_strds_to_rast3/index.html
RuntimeError: Module call r3.univar(...) ended successfully but we were
expecting output and got nothing. There were no error messages.
(see #2269, http://trac.osgeo.org/grass/ticket/2269)

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2015-01-09-08-00/report_for_nc_spm_08_grass7_nc/temporal/t.rast.accumulate/test.t.rast.accumulate/index.html
(hard to tell, it is an bash script)