[GRASS-dev] Tests failing with "requires string, <type 'unicode'> provided"

GRASS GIS GRASS GIS developer
1

A lot of tests are failing:

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-05-02-07-00/report_for_nc_basic_spm_grass7_nc/testfiles.html
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-05-03-07-00/report_for_nc_basic_spm_grass7_nc/testfiles.html

Seems like PyGRASS related marameter checking:

The Parameter require a string, <type ‘unicode’> instead is provided

For example:

ERROR: test_1 (main.TestUnregister)
Perform several unregistration operations

…
ValueError: The Parameter require a string, <type ‘unicode’> instead is provided: u’mapset = “__temporal_t_unregister_test_unregister” AND (name = “a1” OR name = “a2” OR name = “a3”)’

The change should be somewhere here:

https://trac.osgeo.org/grass/log/grass/trunk?rev=68369&stop_rev=68347

2

On Fri, May 13, 2016 at 5:48 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

A lot of tests are failing:

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-05-02-07-00/report_for_nc_basic_spm_grass7_nc/testfiles.html
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-05-03-07-00/report_for_nc_basic_spm_grass7_nc/testfiles.html

Seems like PyGRASS related marameter checking:

The Parameter <where> require a string, <type 'unicode'> instead is provided

For example:

ERROR: test_1 (__main__.TestUnregister)
Perform several unregistration operations
----------------------------------------------------------------------
...
ValueError: The Parameter <where> require a string, <type 'unicode'> instead
is provided: u'mapset = "__temporal_t_unregister_test_unregister" AND (name
= "a1" OR name = "a2" OR name = "a3")'

The change should be somewhere here:

https://trac.osgeo.org/grass/log/grass/trunk?rev=68369&stop_rev=68347

/me guessing
Could it be this change?

Author: hcho
Date: 2016-03-15 01:56:28 -0700 (Tue, 15 Mar 2016)
New Revision: 68061

Modified:
   grass/trunk/lib/gis/parser.c
Log:
G_recreate_command: Add empty answers.
Fix the command history for e.g., v.edit where="". Without this fix,
where="" is not included, which makes an invalid command.

which looks like a valid improvement to me. If it is this one, perhaps
the tests need some update?

Markus

3

Hi,

On Fri, May 13, 2016 at 5:48 PM, Vaclav Petras <wenzeslaus@gmail.com> wrote:

A lot of tests are failing:

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-05-02-07-00/report_for_nc_basic_spm_grass7_nc/testfiles.html
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-05-03-07-00/report_for_nc_basic_spm_grass7_nc/testfiles.html

Seems like PyGRASS related marameter checking:

The Parameter <where> require a string, <type 'unicode'> instead is provided

the commit: r68465, fix the tests:

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-05-20-07-00/report_for_nc_basic_spm_grass7_nc/testfiles.html

All the best

Pietro