[GRASS-dev] tickets to solve for GRASS 6.4.2 release

On Aug 31, 2011, at 8:05 PM, grass-dev-request@lists.osgeo.org wrote:

Date: Wed, 31 Aug 2011 16:59:04 +0200
From: Markus Metz <markus.metz.giswork@googlemail.com>
Subject: Re: [GRASS-dev] tickets to solve for GRASS 6.4.2 release
To: GRASS developers list <grass-dev@lists.osgeo.org>
Message-ID:
       <CAG+h=FHhATWe-Ofv+3B4Upk7MiyXB_Vm7kKONt-gaXP+6ux31Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Aug 31, 2011 at 4:32 PM, Markus Neteler <neteler@osgeo.org> wrote:

On Wed, Aug 31, 2011 at 3:20 PM, Markus Metz
<markus.metz.giswork@googlemail.com> wrote:

Hi all,

the list of blocker and critical tickets for 6.4.2 is reassuringly short:

Here some more issues (GRASS 6.4 bugs and wishes from Geostat2011):

Some of the new wxGUI features are experimental. If we decide on
feature freeze, these features must be removed. If we decide on
keeping and fixing them, this will delay the 6.4.2 release because the
time needed to fix them is a function of the number of devs looking at
these features x the time these devs have x the complexity of these
features.

New features in the wxGUI are often applied to all branches at once
and haven't enjoyed a lot of testing. IMHO this is a question of
keeping this door to 6.4.2 open or close it.

*. hard-coded file extensions in wxGUI raster import, breaks with
non-standard suffix + raster importer: .asc is not supported for
ArcINFO ASCII files when using directory bulk import
--> we would need a list of allowed extensions per format (see
gui/wxpython/gui_modules/gselect.py)

The new raster importer is fairly new and experimental and somehow
sneaked into 6.4.2

* raster importer: when changing format, the selected directory is
cleared but should remain
--> open

The new raster importer is fairly new and experimental and somehow
sneaked into 6.4.2
The standard r.in.gdal GUI works fine.

* graphical modeler: dynamically read in module list + path
--> the locally installed Addons are not shown in the list.
==> right, addons are also not shown in the search tree or the menu,
please report it on trac
Reported as: #1420 (wxGUI: modeller) – GRASS GIS
--> open

The new graphical modeler is fairly new and experimental and somehow
sneaked into 6.4.2

* display of attrcol in windows wxGUI crashes (d.vect)
--> open

This is #1184, right? Should be fixed together with #1158, to be confirmed.

* wxGUI windows: manuals tab: bind arrow keys / pgup / pgdown to
scrolling for easier navigation
- ML: it's working for me, you just need to click on the manual for
the focus. Do you mean to set the focus automatically when the page is
entered?
- MM: this focus thing is a bit difficult, and dangerous to fiddle
around with because MS Windows has different focus ?handling than
Linux/Mac --> preserve portability
--> open

I tend to say --> won't fix or worksforme because in MS Windows you
have to set the focus manually to a window before you can use arrow
keys / pgup / pgdown / tab to navigate between fields within that
window. If that is changed, the default OS behaviour is changed which
is probably causing confusion and trouble.

Markus M

If raster importer and graphical modeler are removed, then it seems from other posts that all blocker items are resolved. We we want to consider keeping either of these, it sounds from the error report that the raster importer bug may be relatively easy to fix. The modeler is very cool but still in development AFAICT. I'll try some more testing. In any case, the modeler must have docs before any real release.

Michael

2011/8/31 Michael Barton <michael.barton@asu.edu>:

If raster importer and graphical modeler are removed, then it seems from other posts that all blocker items are resolved. We we want to consider keeping either of these, it sounds from the error report that the raster importer bug may be relatively easy to fix. The modeler is very cool but still in

better fix then remove... Well, reported issue about modeler is wish, not bug.

development AFAICT. I'll try some more testing. In any case, the modeler must have docs before any real release.

Feel free to extent the documentation... BTW, there is not only
modeler with incomplete docs...

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

On Wed, Aug 31, 2011 at 7:09 PM, Martin Landa <landa.martin@gmail.com> wrote:

2011/8/31 Michael Barton <michael.barton@asu.edu>:

If raster importer and graphical modeler are removed, then it seems from other posts that all blocker items are resolved. We we want to consider keeping either of these, it sounds from the error report that the raster importer bug may be relatively easy to fix. The modeler is very cool but still in

better fix then remove... Well, reported issue about modeler is wish, not bug.

Regarding the import/link dialogs, I had a look at GdalImportDialog in
gdialogs.py. Maybe the easiest would be to replace the format selector
with a simple text field where the user can enter a file extension
which will then be used to filter files, plus a button to apply the
filter.

Otherwise the import dialog must come up with a list of all possible
file name extensions associated to a GDAL/OGR format. Bearing in mind
that e.g. Linux does not need any file name extensions and extensions
can be completely arbitrary, the import dialog can not possibly be
clever enough to cater for all possibilities.

Just a suggestion,

Markus M

I have to know how it works to write the docs.

If I have a chance to work it out I can add to them.

Michael
______________________________
C. Michael Barton
Director, Center for Social Dynamics & Complexity
Professor of Anthropology, School of Human Evolution & Social Change
Arizona State University
Tempe, AZ 85287-2402
USA

voice: 480-965-6262 (SHESC), 480-727-9746 (CSDC)
fax: 480-965-7671(SHESC), 480-727-0709 (CSDC)
www: http://csdc.asu.edu, http://shesc.asu.edu
    http://www.public.asu.edu/~cmbarton

On Aug 31, 2011, at 10:09 AM, Martin Landa wrote:

2011/8/31 Michael Barton <michael.barton@asu.edu>:

If raster importer and graphical modeler are removed, then it seems from other posts that all blocker items are resolved. We we want to consider keeping either of these, it sounds from the error report that the raster importer bug may be relatively easy to fix. The modeler is very cool but still in

better fix then remove... Well, reported issue about modeler is wish, not bug.

development AFAICT. I'll try some more testing. In any case, the modeler must have docs before any real release.

Feel free to extent the documentation... BTW, there is not only
modeler with incomplete docs...

Martin

--
Martin Landa <landa.martin gmail.com> * Studijní program Geodézie a kartografie – GeoWikiCZ

On Aug 31, 2011, at 10:09 AM, Martin Landa wrote:

2011/8/31 Michael Barton <michael.barton@asu.edu>:

If raster importer and graphical modeler are removed, then it seems from other posts that all blocker items are resolved. We we want to consider keeping either of these, it sounds from the error report that the raster importer bug may be relatively easy to fix. The modeler is very cool but still in

better fix then remove... Well, reported issue about modeler is wish, not bug.

development AFAICT. I'll try some more testing. In any case, the modeler must have docs before any real release.

Feel free to extent the documentation... BTW, there is not only
modeler with incomplete docs...

Martin

--
Martin Landa <landa.martin gmail.com> * Studijní program Geodézie a kartografie – GeoWikiCZ

PS. When I tried to work it out in 7, there *seemed* to be a number of bugs with lines not connecting, shapes not appearing, buttons not responding. But sometimes it worked and sometimes not. If I can figure out how it is supposed to work it will be easier to ID bugs to fix. I'll try it more this week and weekend and see how it goes.

Michael

2011/8/31 Michael Barton <Michael.Barton@asu.edu>:

PS. When I tried to work it out in 7, there *seemed* to be a number of bugs with lines not connecting, shapes not appearing, buttons not responding. But sometimes it worked and sometimes not. If I can figure out how it is supposed to work it will be easier to ID bugs to fix. I'll try it more this week and weekend and see how it goes.

usually you don't need to define relations manually, they are defined
automatically by actions. Please report concrete bugs on trac.

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

On Wed, Aug 31, 2011 at 7:20 PM, Markus Metz
<markus.metz.giswork@googlemail.com> wrote:

Regarding the import/link dialogs, I had a look at GdalImportDialog in
gdialogs.py. Maybe the easiest would be to replace the format selector
with a simple text field where the user can enter a file extension
which will then be used to filter files, plus a button to apply the
filter.

Yes, something like in the "downloadthemAll" Firefox extension would be neat.

Otherwise the import dialog must come up with a list of all possible
file name extensions associated to a GDAL/OGR format.

... which are sometimes hard to guess since people invent all kind of
unusual extensions for regular formats...

Bearing in mind
that e.g. Linux does not need any file name extensions and extensions
can be completely arbitrary, the import dialog can not possibly be
clever enough to cater for all possibilities.

Just a suggestion,

A nice one.

Markus

2011/8/31 Markus Neteler <neteler@osgeo.org>:

On Wed, Aug 31, 2011 at 7:20 PM, Markus Metz
<markus.metz.giswork@googlemail.com> wrote:

Regarding the import/link dialogs, I had a look at GdalImportDialog in
gdialogs.py. Maybe the easiest would be to replace the format selector
with a simple text field where the user can enter a file extension
which will then be used to filter files, plus a button to apply the
filter.

I would not replace format selector, we can just add textctrl where
user can type alternative extension. Will do it.

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

2011/8/31 Martin Landa <landa.martin@gmail.com>:

2011/8/31 Markus Neteler <neteler@osgeo.org>:

On Wed, Aug 31, 2011 at 7:20 PM, Markus Metz
<markus.metz.giswork@googlemail.com> wrote:

Regarding the import/link dialogs, I had a look at GdalImportDialog in
gdialogs.py. Maybe the easiest would be to replace the format selector
with a simple text field where the user can enter a file extension
which will then be used to filter files, plus a button to apply the
filter.

I would not replace format selector, we can just add textctrl where
user can type alternative extension. Will do it.

please try r48008 (devbr6).

* choose directory mode
* set directory name
* set format
* change extension, list of layer updated

Martin

--
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa

On Wed, Aug 31, 2011 at 9:29 PM, Martin Landa <landa.martin@gmail.com> wrote:

2011/8/31 Martin Landa <landa.martin@gmail.com>:

2011/8/31 Markus Neteler <neteler@osgeo.org>:

On Wed, Aug 31, 2011 at 7:20 PM, Markus Metz
<markus.metz.giswork@googlemail.com> wrote:

Regarding the import/link dialogs, I had a look at GdalImportDialog in
gdialogs.py. Maybe the easiest would be to replace the format selector
with a simple text field where the user can enter a file extension
which will then be used to filter files, plus a button to apply the
filter.

I would not replace format selector, we can just add textctrl where
user can type alternative extension. Will do it.

please try r48008 (devbr6).

* choose directory mode
* set directory name
* set format
* change extension, list of layer updated

Cool. I backported both r48007 and r48008 to my local 6.4 and it
works for me.

Small obstacle: some (many?) formats come with predefined extension,
others not. If that could be completely populated to have one default
extension per format, that would be perfect. I can help to populate the
list. Or just do that for those extensions not being delivered from GDAL? I am
not sure why some have a default extension and others not.

The list of default GDAL raster extensions is coded here:
grep GDAL_DMD_EXTENSION frmts/*/*.cpp
frmts/aaigrid/aaigriddataset.cpp: poDriver->SetMetadataItem(
GDAL_DMD_EXTENSION, "asc" );
frmts/adrg/adrgdataset.cpp: poDriver->SetMetadataItem(
GDAL_DMD_EXTENSION, "gen" );
frmts/adrg/srpdataset.cpp: poDriver->SetMetadataItem(
GDAL_DMD_EXTENSION, "img" );
...

and for OGR:
grep CPLGetExtension ogr/ogrsf_frmts/*/*.cpp | grep pszFilename
ogr/ogrsf_frmts/aeronavfaa/ograeronavfaadatasource.cpp:
!EQUAL(CPLGetExtension(pszFilename), "dat") )
ogr/ogrsf_frmts/bna/ogrbnadatasource.cpp: if( !(EQUAL(
CPLGetExtension(pszFilename), "bna" )
ogr/ogrsf_frmts/dwg/ogrdwgdatasource.cpp: if(
!EQUAL(CPLGetExtension(pszFilename),"dwg") )
...

Maybe not really helpful but to populate/check the list.

Markus

I'll test. This is 6.4 svn, 6.5, or 7?

Michael
______________________________
C. Michael Barton
Director, Center for Social Dynamics & Complexity
Professor of Anthropology, School of Human Evolution & Social Change
Arizona State University
Tempe, AZ 85287-2402
USA

voice: 480-965-6262 (SHESC), 480-727-9746 (CSDC)
fax: 480-965-7671(SHESC), 480-727-0709 (CSDC)
www: http://csdc.asu.edu, http://shesc.asu.edu
    http://www.public.asu.edu/~cmbarton

On Aug 31, 2011, at 12:29 PM, Martin Landa wrote:

2011/8/31 Martin Landa <landa.martin@gmail.com>:

2011/8/31 Markus Neteler <neteler@osgeo.org>:

On Wed, Aug 31, 2011 at 7:20 PM, Markus Metz
<markus.metz.giswork@googlemail.com> wrote:

Regarding the import/link dialogs, I had a look at GdalImportDialog in
gdialogs.py. Maybe the easiest would be to replace the format selector
with a simple text field where the user can enter a file extension
which will then be used to filter files, plus a button to apply the
filter.

I would not replace format selector, we can just add textctrl where
user can type alternative extension. Will do it.

please try r48008 (devbr6).

* choose directory mode
* set directory name
* set format
* change extension, list of layer updated

Martin

--
Martin Landa <landa.martin gmail.com> * Studijní program Geodézie a kartografie – GeoWikiCZ

On Wed, Aug 31, 2011 at 9:48 PM, Michael Barton <Michael.Barton@asu.edu> wrote:

I'll test. This is 6.4 svn, 6.5, or 7?

devbr6, so 6.5.svn.

Markus