[GRASS-dev] v.clean -- thresholds & G_message

Hi,

just a small note, thresholds used in v.clean should be tested for
being a valid non-negative value (the patch).

There are two problems:

1) mixing of printf (stderr, ) & G_message (see [1]).

2) the function G_message (or G_waring ...) removes all redundant
spaces from the original message.

  G_message(_("+---------------------------------+---------------+"));
  G_message(_("| Tool | Threshold |"));
  G_message(_("+---------------------------------+---------------+"));

->

+---------------------------------+---------------+
| Tool | Threshold |
+---------------------------------+---------------+

Best, Martin

[1] http://grass.itc.it/pipermail/grass-dev/2006-November/027532.html

--
Martin Landa <landa.martin@gmail.com> * http://gama.fsv.cvut.cz/~landa *

(attachments)

v_clean-1.diff.gz (742 Bytes)

hallo,
imho this is more "output" then "message". I suggest to add flag -t for
tabular output

jachym
On Tue, Nov 21, 2006 at 12:12:11PM +0100, Martin Landa wrote:

Hi,

just a small note, thresholds used in v.clean should be tested for
being a valid non-negative value (the patch).

There are two problems:

1) mixing of printf (stderr, ) & G_message (see [1]).

2) the function G_message (or G_waring ...) removes all redundant
spaces from the original message.

  G_message(_("+---------------------------------+---------------+"));
  G_message(_("| Tool | Threshold |"));
  G_message(_("+---------------------------------+---------------+"));

->

+---------------------------------+---------------+
| Tool | Threshold |
+---------------------------------+---------------+

Best, Martin

[1] http://grass.itc.it/pipermail/grass-dev/2006-November/027532.html

--
Martin Landa <landa.martin@gmail.com> * http://gama.fsv.cvut.cz/~landa *

_______________________________________________
grass-dev mailing list
grass-dev@grass.itc.it
http://grass.itc.it/mailman/listinfo/grass-dev

--
Jachym Cepicky
e-mail: jachym.cepicky@centrum.cz
URL: http://les-ejk.cz
GPG: http://www.les-ejk.cz/pgp/jachym_cepicky-gpg.pub
-----------------------------------------
OFFICE:
Department of Geoinformation Technologies
Zemedelska 3
613 00, Brno
Czech Republick
e-mail: xcepicky@node.mendelu.cz
URL: http://mapserver.mendelu.cz
Tel.: +420 545 134 514

Martin Landa wrote:

just a small note, thresholds used in v.clean should be tested for
being a valid non-negative value (the patch).

There are two problems:

1) mixing of printf (stderr, ) & G_message (see [1]).

Martin,

FYI: this has been discussed a bit in
http://intevation.de/rt/webrt?serial_num=4524

BTW, talking of v.clean bugs - there are few other unresolved issues:
http://intevation.de/rt/webrt?serial_num=4225
https://intevation.de/rt/webrt?serial_num=3681
https://intevation.de/rt/webrt?serial_num=4547

Maciek