[GRASS-dev] v.generalize smoothing loop support

hi all
i try make contours from DEM ASTER and i was successfull but contorus is ugly i try use v.generalze but this function cant change firt and las point , but some contrours is like loop (first and last point is the same) so after smoothing with sliging_averaging algo part around start point look_ahead wide was unchanged iwas so ugly , so i write patch which implementing loop line support , check if line is loop (start and endpoint is same ) and smooting correctly, is it usabel for others ?

attachment:
black is war contours, blue is orig algo and red is with my patch

--
MSc. Miroslav Talasek
Developer, Team leader
Seznam.cz, a.s.
Prague
Czech Republic

tel.:+420 234 694 722
fax: +420 234 694 115
gsm: +420 608 934 724
jabber: mirecta@jabber.cz
work-email: miroslav.talasek@firma.seznam.cz
email: miroslav.talasek@seznam.cz
web:http://photo.talasek.sk

(attachments)

old.jpg
with_loop_support.jpg
orig.jpg

On Wed, Apr 17, 2013 at 10:54 AM, Miroslav Talasek
<miroslav.talasek@seznam.cz> wrote:

hi all
i try make contours from DEM ASTER and i was successfull but contorus is
ugly i try use v.generalze but this function cant change firt and las point
, but some contrours is like loop (first and last point is the same) so
after smoothing with sliging_averaging algo part around start point
look_ahead wide was unchanged iwas so ugly , so i write patch which
implementing loop line support , check if line is loop (start and endpoint
is same ) and smooting correctly, is it usabel for others ?

Yes, I think this is usuable for others. Do you mind sending the patch?

Markus M

attachment:
black is war contours, blue is orig algo and red is with my patch

--
MSc. Miroslav Talasek
Developer, Team leader
Seznam.cz, a.s.
Prague
Czech Republic

tel.:+420 234 694 722
fax: +420 234 694 115
gsm: +420 608 934 724
jabber: mirecta@jabber.cz
work-email: miroslav.talasek@firma.seznam.cz
email: miroslav.talasek@seznam.cz
web:http://photo.talasek.sk

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

is it ok ?
it add new parameter loop_support which would be 1 or 0 for loop line support in

sliging_averaging algo

On 04/17/2013 12:46 PM, Markus Metz wrote:

On Wed, Apr 17, 2013 at 10:54 AM, Miroslav Talasek
<miroslav.talasek@seznam.cz> wrote:

hi all
i try make contours from DEM ASTER and i was successfull but contorus is
ugly i try use v.generalze but this function cant change firt and las point
, but some contrours is like loop (first and last point is the same) so
after smoothing with sliging_averaging algo part around start point
look_ahead wide was unchanged iwas so ugly , so i write patch which
implementing loop line support , check if line is loop (start and endpoint
is same ) and smooting correctly, is it usabel for others ?

Yes, I think this is usuable for others. Do you mind sending the patch?

Markus M

attachment:
black is war contours, blue is orig algo and red is with my patch

--
MSc. Miroslav Talasek
Developer, Team leader
Seznam.cz, a.s.
Prague
Czech Republic

tel.:+420 234 694 722
fax: +420 234 694 115
gsm: +420 608 934 724
jabber: mirecta@jabber.cz
work-email: miroslav.talasek@firma.seznam.cz
email: miroslav.talasek@seznam.cz
web:http://photo.talasek.sk

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

(attachments)

v.genealize.patch (6.82 KB)

it this path ok ?
do you use it ?

On Mon, Apr 22, 2013 at 10:40 AM, Miroslav Talasek
<miroslav.talasek@seznam.cz> wrote:

it this path ok ?
do you use it ?

I have added your loop support in r56252, with slight modifications:
loop support is activated with the -l flag.

Thanks for the contribution!

Markus M

On 04/17/2013 02:47 PM, Miroslav Talasek wrote:

is it ok ?
it add new parameter loop_support which would be 1 or 0 for loop line
support in

sliging_averaging algo

On 04/17/2013 12:46 PM, Markus Metz wrote:

On Wed, Apr 17, 2013 at 10:54 AM, Miroslav Talasek
<miroslav.talasek@seznam.cz> wrote:

hi all
i try make contours from DEM ASTER and i was successfull but contorus is
ugly i try use v.generalze but this function cant change firt and las point
, but some contrours is like loop (first and last point is the same) so
after smoothing with sliging_averaging algo part around start point
look_ahead wide was unchanged iwas so ugly , so i write patch which
implementing loop line support , check if line is loop (start and endpoint
is same ) and smooting correctly, is it usabel for others ?

Yes, I think this is usuable for others. Do you mind sending the patch?

Markus M

attachment:
black is war contours, blue is orig algo and red is with my patch

--
MSc. Miroslav Talasek
Developer, Team leader
Seznam.cz, a.s.
Prague
Czech Republic

tel.:+420 234 694 722
fax: +420 234 694 115
gsm: +420 608 934 724
jabber: mirecta@jabber.cz
work-email: miroslav.talasek@firma.seznam.cz
email: miroslav.talasek@seznam.cz
web:http://photo.talasek.sk

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

On Tue, May 14, 2013 at 4:46 PM, Markus Metz
<markus.metz.giswork@gmail.com> wrote:

On Mon, Apr 22, 2013 at 10:40 AM, Miroslav Talasek
<miroslav.talasek@seznam.cz> wrote:

it this path ok ?
do you use it ?

I have added your loop support in r56252, with slight modifications:
loop support is activated with the -l flag.

Now the smoothing algorithms boyle, chaiken, distance_weighting,
hermite, snakes also have loop support.

Markus M

On 04/17/2013 02:47 PM, Miroslav Talasek wrote:

is it ok ?
it add new parameter loop_support which would be 1 or 0 for loop line
support in

sliging_averaging algo

On 04/17/2013 12:46 PM, Markus Metz wrote:

On Wed, Apr 17, 2013 at 10:54 AM, Miroslav Talasek
<miroslav.talasek@seznam.cz> wrote:

hi all
i try make contours from DEM ASTER and i was successfull but contorus is
ugly i try use v.generalze but this function cant change firt and las point
, but some contrours is like loop (first and last point is the same) so
after smoothing with sliging_averaging algo part around start point
look_ahead wide was unchanged iwas so ugly , so i write patch which
implementing loop line support , check if line is loop (start and endpoint
is same ) and smooting correctly, is it usabel for others ?

Yes, I think this is usuable for others. Do you mind sending the patch?

Markus M

attachment:
black is war contours, blue is orig algo and red is with my patch

--
MSc. Miroslav Talasek
Developer, Team leader
Seznam.cz, a.s.
Prague
Czech Republic

tel.:+420 234 694 722
fax: +420 234 694 115
gsm: +420 608 934 724
jabber: mirecta@jabber.cz
work-email: miroslav.talasek@firma.seznam.cz
email: miroslav.talasek@seznam.cz
web:http://photo.talasek.sk

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

_______________________________________________
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

On Wed, May 15, 2013 at 4:26 PM, Markus Metz
<markus.metz.giswork@gmail.com> wrote:

On Tue, May 14, 2013 at 4:46 PM, Markus Metz
<markus.metz.giswork@gmail.com> wrote:

On Mon, Apr 22, 2013 at 10:40 AM, Miroslav Talasek
<miroslav.talasek@seznam.cz> wrote:

it this path ok ?
do you use it ?

I have added your loop support in r56252, with slight modifications:
loop support is activated with the -l flag.

Now the smoothing algorithms boyle, chaiken, distance_weighting,
hermite, snakes also have loop support.

Excellent - I have added this to

http://trac.osgeo.org/grass/wiki/Grass7/NewFeatures#Vectormodules

(@devs: please remember to add new cool stuff there :slight_smile:

thanks
markusN

On Wed, May 15, 2013 at 5:03 PM, Markus Neteler <neteler@osgeo.org> wrote:

On Wed, May 15, 2013 at 4:26 PM, Markus Metz
<markus.metz.giswork@gmail.com> wrote:

On Tue, May 14, 2013 at 4:46 PM, Markus Metz
<markus.metz.giswork@gmail.com> wrote:

On Mon, Apr 22, 2013 at 10:40 AM, Miroslav Talasek
<miroslav.talasek@seznam.cz> wrote:

it this path ok ?
do you use it ?

I have added your loop support in r56252, with slight modifications:
loop support is activated with the -l flag.

Now the smoothing algorithms boyle, chaiken, distance_weighting,
hermite, snakes also have loop support.

Excellent - I have added this to

http://trac.osgeo.org/grass/wiki/Grass7/NewFeatures#Vectormodules

Loop support is now the default for all smoothing methods.

(@devs: please remember to add new cool stuff there :slight_smile:

Updated accordingly.

Markus M