[GRASS-dev] v.transform - RT #5210

Hi,

I have tried to remove interactive functionality from v.transform (see
[1]). Any objections to committing the changes to CVS?

Martin

[1] https://intevation.de/rt/webrt?serial_num=5210&display=History

--
Martin Landa <landa.martin@gmail.com> * http://gama.fsv.cvut.cz/~landa *

(attachments)

v-transform.diff.gz (3.36 KB)

Martin,

I didn't know that v.transform had any interactive functionality. How was it
accessed?

My only concern is that v.transform is used in the TclTk georectifier. It
uses the point file option. Let me know if any of the options or flags have
changed for this command.

Michael

On 2/23/07 11:29 AM, "Martin Landa" <landa.martin@gmail.com> wrote:

Hi,

I have tried to remove interactive functionality from v.transform (see
[1]). Any objections to committing the changes to CVS?

Martin

[1] https://intevation.de/rt/webrt?serial_num=5210&display=History

__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

Michael Barton wrote:

I didn't know that v.transform had any interactive functionality.

  vector/v.transform/ask_trans.c

How was it accessed?

If you specify neither -s nor pointsfile=, you get a vask form.

Except that it doesn't work since Radim increased MAX_COOR from 10 to
1000 (you end up with a 1007-line vask form, which won't work).

  revision 1.4
  date: 2004/11/13 12:29:36; author: radim; state: Exp; lines: +1 -1
  noninteractively

IOW, the interactive mode hasn't worked for the last two years.

My only concern is that v.transform is used in the TclTk georectifier. It
uses the point file option. Let me know if any of the options or flags have
changed for this command.

The patch marks -s as "superseded"; it still works, but the intention
for future versions is that failure to specify a pointsfile= option
will cause the shift/rotation parameters to be used.

--
Glynn Clements <glynn@gclements.plus.com>

Martin Landa wrote:

I have tried to remove interactive functionality from v.transform (see
[1]). Any objections to committing the changes to CVS?

IIRC that ineractive code isn't currently working.

I only object to removal if the (unused) interactive code includes
functionality that the non-interactive mode doesn't supply (yet). If
removed it will for all practical purposes be lost forever. If left
inactive maybe someone will merge it one day; the extra code bloat
is minor vs. the cost of duplicated development time.

I looked at this some months ago and whiel I don't remember all the
details, at that point I decided to leave the unused code in, either
because it wasn't fully merged into non-interactive mode, or it
contained something interesting.

e.g. RMS error reporting?

If I'm wrong about unported features and interesting things, then by
all means please do remove it.

Hamish

Hi,

OK, I only disabled interactive functionality, the code has not been removed.

Martin

2007/2/26, Hamish <hamish_nospam@yahoo.com>:

Martin Landa wrote:
>
> I have tried to remove interactive functionality from v.transform (see
> [1]). Any objections to committing the changes to CVS?

IIRC that ineractive code isn't currently working.

I only object to removal if the (unused) interactive code includes
functionality that the non-interactive mode doesn't supply (yet). If
removed it will for all practical purposes be lost forever. If left
inactive maybe someone will merge it one day; the extra code bloat
is minor vs. the cost of duplicated development time.

I looked at this some months ago and whiel I don't remember all the
details, at that point I decided to leave the unused code in, either
because it wasn't fully merged into non-interactive mode, or it
contained something interesting.

e.g. RMS error reporting?

If I'm wrong about unported features and interesting things, then by
all means please do remove it.

Hamish

--
Martin Landa <landa.martin@gmail.com> * http://gama.fsv.cvut.cz/~landa *