[GRASS-dev] vector lib compile error in trunk

After r37270 I get a compile error in trunk/lib/vector/diglib

The portability test in diglib is no longer passed, probably because
portable.c and port_init.c have been modified. According to the
changeset it (the compile error) doesn't make sense, but I observed that
too when I put in LFS support. The files test32.ok and test64.ok must be
created anew, preferably after some testing.

Anybody else getting this compile error?

Best,
Markus M

Hi,

2009/5/21 Markus GRASS <markus.metz.giswork@googlemail.com>:

After r37270 I get a compile error in trunk/lib/vector/diglib

The portability test in diglib is no longer passed, probably because
portable.c and port_init.c have been modified. According to the
changeset it (the compile error) doesn't make sense, but I observed that
too when I put in LFS support. The files test32.ok and test64.ok must be
created anew, preferably after some testing.

Anybody else getting this compile error?

not me on 32bit, LFS enabled. Hm, probably the changes should be reverted(??)

Martin

--
Martin Landa <landa.martin gmail.com> * http://gama.fsv.cvut.cz/~landa

Martin Landa wrote:

Hi,

2009/5/21 Markus GRASS <markus.metz.giswork@googlemail.com>:
  

After r37270 I get a compile error in trunk/lib/vector/diglib

The portability test in diglib is no longer passed, probably because
portable.c and port_init.c have been modified. According to the
changeset it (the compile error) doesn't make sense, but I observed that
too when I put in LFS support. The files test32.ok and test64.ok must be
created anew, preferably after some testing.

Anybody else getting this compile error?
    
not me on 32bit, LFS enabled. Hm, probably the changes should be reverted(??)
  

No need to revert IMHO, the changes do not look serious, it was just
documentation and adding const where necessary when I had a look at the
changeset.

BTW, I got the compile error on Linux 64bit, LFS enabled, after make
distclean. test.c may need a close look, then test32.ok and test64.ok
need to be created anew and tested on different systems, with and
without LFS (that's what I did before submitting LFS to the vector
libs). Unfortunately I have currently neither the resources nor the time
to do some testing on my side. I can't really judge how important that
portability test is, a good reason to make sure it is passed?

Markus M

Hi,

found it and fixed it in r37344. Looks like I was the culprit :frowning:

Markus M

Martin Landa wrote:

Hi,

2009/5/21 Markus GRASS <markus.metz.giswork@googlemail.com>:
  

After r37270 I get a compile error in trunk/lib/vector/diglib

The portability test in diglib is no longer passed, probably because
portable.c and port_init.c have been modified. According to the
changeset it (the compile error) doesn't make sense, but I observed that
too when I put in LFS support. The files test32.ok and test64.ok must be
created anew, preferably after some testing.

Anybody else getting this compile error?
    
not me on 32bit, LFS enabled. Hm, probably the changes should be reverted(??)

Martin