[GRASS-dev] viewshed and iostream issues

On Aug 5, 2008, at 7:34 PM, <grass-dev-request@lists.osgeo.org> wrote:

From: Laura Toma <ltoma@bowdoin.edu>

Date: August 5, 2008 7:34:15 PM GMT-07:00

To: Paul Kelly <paul-grass@stjohnspoint.co.uk>, grass-dev@lists.osgeo.org

Cc: Will <willster3021@gmail.com>

Subject: [GRASS-dev] viewshed and iostream issues

Viewshed does not immediately compile with the iostream library in grass. Over the last years there were a few changes to it, but were never merged them into the grass trunk because they did not seem important enough at the time. Now that both viewshed and terraflow use the same library, I don’t think that it makes sense to try to make viewshed compile with an older version; instead, I would rather update the library. I looked over the grass svn logs and the only significant changes to iostream that I could see are the following:

  1. #ifdef MINGW32 (windows compatibility)
  2. char* replaced with std::string (Andy Danner’s patch a few weeks ago)
    (is there anything else?)

I have merged these changes into my most recent version of iostream, which I am attaching; it is split into headers (include_iostream.tar), and cc files (lib_iostream.tar). If you place them into grass_trunk/include/iostream/ and grass_trunk/lib/iostream/ respectively, the library, terraflow and viewshed all compile and run (macosx 10.4).

This is a start to get r.viewshed to compile and run and get some feedback. If the general opinion is to keep the library unchanged, I guess we’ll have to modify viewshed, which is doable, though not particularly exciting.

-Laura

Laura, Will, and Paul,

I’m very much looking forward to being able to test out this new module.

Michael