[GRASS-dev] what does -a in i.rectify do?

GRASS GRASS developer
1

Dear All,

I'm trying to cleanup i.rectify manual. I don't see any difference
between -a (Rectify all images in group) set and not set - in either
case all raster maps in the group are rectified. Is this a bug or am I
missing something?

Would it hurt if I chenged the module's options descriptions to comply
with GRASS lingo (eg. "raster map" instead of "file" etc.).

Best
Maciek

--
Maciej Sieczka
www.sieczka.org

2

On Sat, Jul 5, 2008 at 7:43 PM, Maciej Sieczka <tutey@o2.pl> wrote:

Dear All,

I'm trying to cleanup i.rectify manual. I don't see any difference
between -a (Rectify all images in group) set and not set - in either
case all raster maps in the group are rectified. Is this a bug or am I
missing something?

Not sure... in the code there is :
    ifile = G_define_standard_option(G_OPT_R_INPUT);
    ifile->required = NO;
...
    if (!ifile->answers)
        a->answer = 1; /* force all */

    /* Find out how files on command line */
    if (!a->answer) {
        for (m = 0; ifile->answers[m]; m++) {
            k = m;
        }
        k++;
    }

Would it hurt if I chenged the module's options descriptions to comply
with GRASS lingo (eg. "raster map" instead of "file" etc.).

In both 6.4.svn and trunk it is now:
i.rectify [-ca] [input=name] extension=string order=value [--verbose]

Standardization we should do in GRASS 7
http://grass.osgeo.org/wiki/GRASS_7_ideas_collection#Parameters_standardization

Markus

3

Markus Neteler pisze:

On Sat, Jul 5, 2008 at 7:43 PM, Maciej Sieczka <tutey@o2.pl> wrote:

Would it hurt if I chenged the module's options descriptions to
comply with GRASS lingo (eg. "raster map" instead of "file" etc.).

In both 6.4.svn and trunk it is now: i.rectify [-ca] [input=name]
extension=string order=value [--verbose]

Standardization we should do in GRASS 7 http://grass.osgeo.org/wiki/GRASS_7_ideas_collection#Parameters_standardization

I do not mean to change *options names* of course! I was going to change
their *descriptions*, eg.:

1. "Name of the imagery group" -> "Input imagery group name" (to make it
clear i's the input)

2. "Output file extension" -> "Output raster maps extension" (term
"file" is ambigious in GRASS).

Is this acceptable?

--
Maciej Sieczka
www.sieczka.org

4

On Sun, Jul 6, 2008 at 12:14 PM, Maciej Sieczka <tutey@o2.pl> wrote:

Markus Neteler pisze:

On Sat, Jul 5, 2008 at 7:43 PM, Maciej Sieczka <tutey@o2.pl> wrote:

I was going to change their *descriptions*, eg.:

1. "Name of the imagery group" -> "Input imagery group name" (to make it
clear i's the input)

2. "Output file extension" -> "Output raster maps extension" (term
"file" is ambigious in GRASS).

Is this acceptable?

Sorry, I made a mess in my previous commit. Now it is:

i.rectify [-ca] group=name [input=name[,name,...]] extension=string
...
Parameters:
      group Name of input imagery group
      input Name of input raster map(s)
     extension Output file extension (inputfile(s) + extension)
      order Rectification polynom order (1-3)

So the first is already solved, the second, yes, should be fixed
in the C code.

Markus

5

Markus Neteler pisze:

On Sat, Jul 5, 2008 at 7:43 PM, Maciej Sieczka <tutey@o2.pl> wrote:

I'm trying to cleanup i.rectify manual. I don't see any difference
between -a (Rectify all images in group) set and not set - in either
case all raster maps in the group are rectified. Is this a bug or am I
missing something?

Not sure... in the code there is :
    ifile = G_define_standard_option(G_OPT_R_INPUT);
    ifile->required = NO;
...
    if (!ifile->answers)
        a->answer = 1; /* force all */

    /* Find out how files on command line */
    if (!a->answer) {
        for (m = 0; ifile->answers[m]; m++) {
            k = m;
        }
        k++;
    }

Getting back to this - anybody knows what's the difference between -a set and not set?

Maciek

--
Maciej Sieczka
www.sieczka.org