[GRASS-dev] wxGUI scatterplot: add wx.BeginBusyCursor and wx.EndBusyCursor

GRASS GIS GRASS GIS developer
1

Hi,

when plotting "larger" data (eg two landsat channels or whatever)
with the Scatterplot tool, then the calculation starts while not
showing the cursor busy. The user may assume that the thing is crashed
while it indeed simply calculates... Then the plot comes up and all is
fine.

I would like to add
    wx.BeginBusyCursor()
...
    wx.EndBusyCursor()

somewhere in wxplot/dialogs.py but I don't really know where that's needed.

A few other wxGUI tools may also lack this cursor change.

thanks for hints,
Markus

2

would you mind testing this diff?

(attachments)

scatter.diff (611 Bytes)

···

On Tue, Oct 27, 2015 at 6:04 AM, Markus Neteler <neteler@osgeo.org> wrote:

Hi,

when plotting “larger” data (eg two landsat channels or whatever)
with the Scatterplot tool, then the calculation starts while not
showing the cursor busy. The user may assume that the thing is crashed
while it indeed simply calculates… Then the plot comes up and all is
fine.

I would like to add
wx.BeginBusyCursor()
…
wx.EndBusyCursor()

somewhere in wxplot/dialogs.py but I don’t really know where that’s needed.

A few other wxGUI tools may also lack this cursor change.

thanks for hints,
Markus

grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

3

On Tue, Oct 27, 2015 at 4:11 PM, Anna Petrášová <kratochanna@gmail.com> wrote:

would you mind testing this diff?

Sure - unfortunately no difference...

Markus

4

On Tue, Oct 27, 2015 at 11:37 AM, Markus Neteler <neteler@osgeo.org> wrote:

On Tue, Oct 27, 2015 at 4:11 PM, Anna Petrášová <kratochanna@gmail.com>
wrote:
> would you mind testing this diff?

Sure - unfortunately no difference...

Hmm,what about adding wx.Yield() just after the wx.BeginBusyCursor()?

Markus

5

On Tue, Oct 27, 2015 at 4:39 PM, Anna Petrášová <kratochanna@gmail.com> wrote:

On Tue, Oct 27, 2015 at 11:37 AM, Markus Neteler <neteler@osgeo.org> wrote:
Hmm,what about adding wx.Yield() just after the wx.BeginBusyCursor()?

Bingo, now it works.

The histogram tool is affected, too, say, it would be great to have
the busy cursor also there.

Markus

6

It’s in trunk now for histogram, scatter plot and profile tool. Not sure about backporting, it should be safe, but you never know…

···

On Tue, Oct 27, 2015 at 11:54 AM, Markus Neteler <neteler@osgeo.org> wrote:

On Tue, Oct 27, 2015 at 4:39 PM, Anna Petrášová <kratochanna@gmail.com> wrote:

On Tue, Oct 27, 2015 at 11:37 AM, Markus Neteler <neteler@osgeo.org> wrote:
Hmm,what about adding wx.Yield() just after the wx.BeginBusyCursor()?

Bingo, now it works.

The histogram tool is affected, too, say, it would be great to have
the busy cursor also there.

Markus

7

On Wed, Oct 28, 2015 at 3:36 AM, Anna Petrášová <kratochanna@gmail.com> wrote:

It's in trunk now for histogram, scatter plot and profile tool. Not sure about backporting, it should be safe, but you never know...

I have backported it locally and it works fine. Way less confusing as
it was before when the GUI seemed to be frozen...

Markus

8

Hi again,

histogram and scatterplot are fine.

one suggestion: in the profile tool, it should not put the busy cursor
when waiting for the next point to be digitized in the map. At time
the user will not dare to click again while s/he could...

Markus

9

On Wed, Oct 28, 2015 at 4:20 AM, Markus Neteler <neteler@osgeo.org> wrote:

Hi again,

histogram and scatterplot are fine.

one suggestion: in the profile tool, it should not put the busy cursor
when waiting for the next point to be digitized in the map. At time
the user will not dare to click again while s/he could...

ok, done in r66640.

Anna

Markus

10

On Wed, Oct 28, 2015 at 2:41 PM, Anna Petrášová <kratochanna@gmail.com> wrote:

On Wed, Oct 28, 2015 at 4:20 AM, Markus Neteler <neteler@osgeo.org> wrote:

Hi again,

histogram and scatterplot are fine.

one suggestion: in the profile tool, it should not put the busy cursor
when waiting for the next point to be digitized in the map. At time
the user will not dare to click again while s/he could...

ok, done in r66640.

thanks. I highly recommend the backport of the remaining two cursor
changes. I can do that if you prefer.

Markus

11

On Wed, Oct 28, 2015 at 11:22 AM, Markus Neteler <neteler@osgeo.org> wrote:

On Wed, Oct 28, 2015 at 2:41 PM, Anna Petrášová <kratochanna@gmail.com>
wrote:
> On Wed, Oct 28, 2015 at 4:20 AM, Markus Neteler <neteler@osgeo.org>
wrote:
>>
>> Hi again,
>>
>> histogram and scatterplot are fine.
>>
>> one suggestion: in the profile tool, it should not put the busy cursor
>> when waiting for the next point to be digitized in the map. At time
>> the user will not dare to click again while s/he could...
>
>
> ok, done in r66640.

thanks. I highly recommend the backport of the remaining two cursor
changes. I can do that if you prefer.

Yes, please do, thank you.

Markus

12

On Wed, Oct 28, 2015 at 4:25 PM, Anna Petrášová <kratochanna@gmail.com> wrote:
...

Yes, please do, thank you.

Done in r66642.

thanks again for the rapid support. Also our students here appreciated that!

Markus