[GRASS5] [bug #4111] (grass) d.m crashes

this bug's URL: http://intevation.de/rt/webrt?serial_num=4111
-------------------------------------------------------------------------

Subject: d.m crashes

Platform: Mac OSX
grass binary for platform: Compiled from Sources
GRASS Version: 6.1.cvs checked out 02222006

Kirk Wythers. I noticed that d.m crashes now upon startup. The error message is:

GRASS 6.1.cvs (minnesota_utm):~ > d.m
GRASS 6.1.cvs (minnesota_utm):~ > Error in startup script: child process exited abnormally
    while executing
"close $input"
    (procedure "Dm::create" line 38)
    invoked from within
"Dm::create"
    (procedure "main" line 33)
    invoked from within
"main $argc $argv"
    (file "/usr/local/grass-6.1.cvs/etc/dm/d.m.tcl" line 1629)

-------------------------------------------- Managed by Request Tracker

Request Tracker wrote:

this bug's URL: http://intevation.de/rt/webrt?serial_num=4111
-------------------------------------------------------------------------

Subject: d.m crashes

Platform: Mac OSX
grass binary for platform: Compiled from Sources
GRASS Version: 6.1.cvs checked out 02222006

Kirk Wythers. I noticed that d.m crashes now upon startup. The error message is:

GRASS 6.1.cvs (minnesota_utm):~ > d.m
GRASS 6.1.cvs (minnesota_utm):~ > Error in startup script: child process exited abnormally
    while executing
"close $input"
    (procedure "Dm::create" line 38)
    invoked from within
"Dm::create"
    (procedure "main" line 33)
    invoked from within
"main $argc $argv"
    (file "/usr/local/grass-6.1.cvs/etc/dm/d.m.tcl" line 1629)

The "close $input" should be within the catch, as $input won't be
valid if the open command fails.

While glancing at the code, I also noticed the following in both
Dm::displmon and Dm::monitor:

    return
  close $input

The close needs to come before the return.

--
Glynn Clements <glynn@gclements.plus.com>

I've done this now. So hopefully it is finally solved. Thanks for the
advice.

Michael
______________________________
Michael Barton, Professor of Anthropology
School of Human Evolution and Social Change
Arizona State University
Tempe, AZ 85287-2402
USA

voice: 480-965-6262; fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton

From: Glynn Clements <glynn@gclements.plus.com>
Date: Wed, 22 Feb 2006 17:54:39 +0000
To: Request Tracker <grass-bugs@intevation.de>
Cc: <grass5@grass.itc.it>, Michael Barton <michael.barton@asu.edu>
Subject: Re: [GRASS5] [bug #4111] (grass) d.m crashes

Request Tracker wrote:

this bug's URL: http://intevation.de/rt/webrt?serial_num=4111
-------------------------------------------------------------------------

Subject: d.m crashes

Platform: Mac OSX
grass binary for platform: Compiled from Sources
GRASS Version: 6.1.cvs checked out 02222006

Kirk Wythers. I noticed that d.m crashes now upon startup. The error message
is:

GRASS 6.1.cvs (minnesota_utm):~ > d.m
GRASS 6.1.cvs (minnesota_utm):~ > Error in startup script: child process
exited abnormally
    while executing
"close $input"
    (procedure "Dm::create" line 38)
    invoked from within
"Dm::create"
    (procedure "main" line 33)
    invoked from within
"main $argc $argv"
    (file "/usr/local/grass-6.1.cvs/etc/dm/d.m.tcl" line 1629)

The "close $input" should be within the catch, as $input won't be
valid if the open command fails.

While glancing at the code, I also noticed the following in both
Dm::displmon and Dm::monitor:

    return
close $input

The close needs to come before the return.

--
Glynn Clements <glynn@gclements.plus.com>