[GRASS5] [bug #746] (grass) Change all G_put_map_row() -> G_put_c_raster_row() ?

GRASS GRASS developer
1

Hi Markus

mneteler wrote (Tue, May 29 2001 10:06:11):

Subject: Change all G_put_map_row() -> G_put_c_raster_row() ?

grass downloaded at: CVS Server, Germany

There are still > 70 occurencies of the deprecated function G_put_map_row()
within the sources. Question is to change them to G_put_c_raster_row() for
proper zero/NULL handling:

Is there a G_put_raster_row(..., ..., dtatType) function? If so you should
change the calls to G_put_raster_row(..., ..., CELL) instead. These types of
functions modularize the code. The G_put_[cfd]_raster_row() functions should
become static functions of whatever file they are in. That is, all calls that
want to put a raster row should call G_put_raster_row(..., ..., dtatType)
which in turn calls the appropriate static G_put_[cfd]_raster_row() function.
My todo list includes doing this for the null_val.c since I already made some
changes to that file. I just didn't have time to go through the code and
change the calls yet.

Anyway, that's just my 2 cents worth.

Justin Hickey

PS Sorry about the duplicate Markus, but I don't think I can change the "reply
to" field in RT

-------------------------------------------- Managed by Request Tracker

From neteler Tue May 29 10:20:03 2001
Return-Path: <neteler>
Received: by hgeo02.geog.uni-hannover.de (SMI-8.6/SMI-SVR4)
  id KAA18898; Tue, 29 May 2001 10:20:03 +0100
Date: Tue, 29 May 2001 10:20:03 +0100
From: Markus Neteler <neteler@geog.uni-hannover.de>
To: grass5 developers list <grass5@geog.uni-hannover.de>
Message-ID: <20010529102003.E18447@hgeo02.geog.uni-hannover.de>
Mail-Followup-To: grass5 developers list <grass5@geog.uni-hannover.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
Subject: [GRASS5] added test for LAPACK/BLAS in configure[.in]
Sender: grass5-admin@geog.uni-hannover.de
Errors-To: grass5-admin@geog.uni-hannover.de
X-BeenThere: grass5@geog.uni-hannover.de
X-Mailman-Version: 2.0.5
Precedence: bulk
List-Help: <mailto:grass5-request@geog.uni-hannover.de?subject=help>
List-Post: <mailto:grass5@geog.uni-hannover.de>
List-Subscribe: <http://www.geog.uni-hannover.de/mailman/listinfo/grass5&gt;,
  <mailto:grass5-request@geog.uni-hannover.de?subject=subscribe>
List-Id: GRASS 5 Developers mailing list <grass5.geog.uni-hannover.de>
List-Unsubscribe: <http://www.geog.uni-hannover.de/mailman/listinfo/grass5&gt;,
  <mailto:grass5-request@geog.uni-hannover.de?subject=unsubscribe>
List-Archive: <http://www.geog.uni-hannover.de/pipermail/grass5/&gt;
Status: O
Content-Length: 686
Lines: 20

Hi,

as some more work is to be done to eliminate the "Numerical
recipes in C" functions from GRASS, I have added a test to
configure configure.in src/CMD/head/head.in

for LAPACK/BLAS libs (used for src/libes/gmath lib).

The idea is to move all numerical functions from the individual modules into
gmath lib (especially from the image processing modules). Perhaps the gmath
lib shall be splitted into basic functions not needing the LAPACK/BLAS (from
www.netlib.org) and a fully featured gmath lib with LAPACK/BLAS support.
gmath currently operates as a wrapper to LAPACK/BLAS (written by David D.
Gray).

Please let me know if the configure changes break anything.

Thanks,

Markus

From neteler Tue May 29 13:51:54 2001
Return-Path: <neteler>
Received: by hgeo02.geog.uni-hannover.de (SMI-8.6/SMI-SVR4)
  id NAA20225; Tue, 29 May 2001 13:51:54 +0100
Date: Tue, 29 May 2001 13:51:53 +0100
From: Markus Neteler <neteler@geog.uni-hannover.de>
To: Justin Hickey via RT <grass-bugs@intevation.de>
Cc: grass5 developers list <grass5@geog.uni-hannover.de>
Subject: Re: [GRASS5] [bug #746] (grass) Change all G_put_map_row() -> G_put_c_raster_row() ?
Message-ID: <20010529135153.I18447@hgeo02.geog.uni-hannover.de>
Mail-Followup-To: Justin Hickey via RT <grass-bugs@intevation.de>,
  grass5 developers list <grass5@geog.uni-hannover.de>
References: <20010529083205.90D01139EE@mailman.intevation.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010529083205.90D01139EE@mailman.intevation.de>; from grass-bugs@intevation.de on Tue, May 29, 2001 at 10:32:05AM +0200
Sender: grass5-admin@geog.uni-hannover.de
Errors-To: grass5-admin@geog.uni-hannover.de
X-BeenThere: grass5@geog.uni-hannover.de
X-Mailman-Version: 2.0.5
Precedence: bulk
List-Help: <mailto:grass5-request@geog.uni-hannover.de?subject=help>
List-Post: <mailto:grass5@geog.uni-hannover.de>
List-Subscribe: <http://www.geog.uni-hannover.de/mailman/listinfo/grass5&gt;,
  <mailto:grass5-request@geog.uni-hannover.de?subject=subscribe>
List-Id: GRASS 5 Developers mailing list <grass5.geog.uni-hannover.de>
List-Unsubscribe: <http://www.geog.uni-hannover.de/mailman/listinfo/grass5&gt;,
  <mailto:grass5-request@geog.uni-hannover.de?subject=unsubscribe>
List-Archive: <http://www.geog.uni-hannover.de/pipermail/grass5/&gt;
Status: O
Content-Length: 1641
Lines: 47

On Tue, May 29, 2001 at 10:32:05AM +0200, Justin Hickey via RT wrote:

Hi Markus

mneteler wrote (Tue, May 29 2001 10:06:11):

> Subject: Change all G_put_map_row() -> G_put_c_raster_row() ?
>
> grass downloaded at: CVS Server, Germany
>
> There are still > 70 occurencies of the deprecated function G_put_map_row()
> within the sources. Question is to change them to G_put_c_raster_row() for
> proper zero/NULL handling:

Is there a G_put_raster_row(..., ..., dtatType) function? If so you should
change the calls to G_put_raster_row(..., ..., CELL) instead. These types of
functions modularize the code. The G_put_[cfd]_raster_row() functions should
become static functions of whatever file they are in. That is, all calls that
want to put a raster row should call G_put_raster_row(..., ..., dtatType)
which in turn calls the appropriate static G_put_[cfd]_raster_row() function.

Hi Justin,

Ok, so we would have the change

G_put_map_row() -> G_put_raster_row(..., ..., , CELL_TYPE);

If no objections, I will change all the 77 occurencies.

My todo list includes doing this for the null_val.c since I already made some
changes to that file. I just didn't have time to go through the code and
change the calls yet.

Anyway, that's just my 2 cents worth.

Justin Hickey

PS Sorry about the duplicate Markus, but I don't think I can change the
"reply to" field in RT

You can simply write to "grass5" and cc to "grass-bugs@intevation.de". Then
RT will catch the mail and add to the bug. No need to enter the RT for such
communication [this will be the test :slight_smile: ]

Cheers

Markus